add benchmarking and performance improvements

Author: jkyberneees

bench.ts

@@ -0,0 +1,64 @@
+import { run, bench, group, baseline } from 'mitata';
+import httpNext from './index'
+import httpPrevious from '0http-bun'
+
+function setupRouter(router) {
+  router.use((req, next) => {
+    return next()
+  })
+
+  router.get('/', () => {
+    return new Response()
+  })
+  router.get('/:id', async (req) => {
+    return new Response(req.params.id)
+  })
+  router.get('/:id/error', () => {
+    throw new Error('Error')
+  })
+}
+
+const { router } = httpNext()
+setupRouter(router)
+
+const { router: routerPrevious } = httpPrevious()
+setupRouter(routerPrevious)
+
+group('Next Router', () => {
+  baseline('Base URL', () => {
+    router.fetch(new Request(new URL('http://localhost/')))
+  })
+  bench('Parameter URL', () => {
+    router.fetch(new Request(new URL('http://localhost/0')))
+  })
+  bench('Not Found URL', () => {
+    router.fetch(new Request(new URL('http://localhost/0/404')))
+  })
+  bench('Error URL', () => {
+    router.fetch(new Request(new URL('http://localhost/0/error')))
+  })
+})
+
+group('Previous Router', () => {
+  baseline('Base URL', () => {
+    routerPrevious.fetch(new Request(new URL('http://localhost/')))
+  })
+  bench('Parameter URL', () => {
+    routerPrevious.fetch(new Request(new URL('http://localhost/0')))
+  })
+  bench('Not Found URL', () => {
+    routerPrevious.fetch(new Request(new URL('http://localhost/0/404')))
+  })
+  bench('Error URL', () => {
+    routerPrevious.fetch(new Request(new URL('http://localhost/0/error')))
+  })
+})
+
+await run({
+  silent: false,
+  avg: true,
+  json: false,
+  colors: true,
+  min_max: false,
+  percentiles: false
+})

lib/next.js

@@ -1,19 +1,17 @@
 module.exports = function next (middlewares, req, index, defaultRoute, errorHandler) {
-  const middleware = middlewares[index]
-  if (!middleware) {
+  if (index >= middlewares.length) {
     return defaultRoute(req)
   }
 
-  function step (err) {
-    if (err) {
-      return errorHandler(err, req)
-    } else {
-      return next(middlewares, req, index + 1, defaultRoute, errorHandler)
-    }
-  }
+  const middleware = middlewares[index++]
 
   try {
-    return middleware(req, step)
+    return middleware(req, (err) => {
+      if (err) {
+        return errorHandler(err, req)
+      }
+      return next(middlewares, req, index, defaultRoute, errorHandler)
+    })
   } catch (err) {
     return errorHandler(err, req)
   }

lib/router/sequential.js

@@ -1,25 +1,22 @@
-/* global Response */
-
 const Trouter = require('trouter')
 const next = require('./../next')
 
+const status404 = {
+  status: 404
+}
+const status500 = {
+  status: 500
+}
+
 module.exports = (config = {}) => {
   if (!config.defaultRoute) {
     config.defaultRoute = () => {
-      const res = new Response(null, {
-        status: 404
-      })
-
-      return res
+      return new Response(null, status404)
     }
   }
   if (!config.errorHandler) {
     config.errorHandler = (err) => {
-      const res = new Response(err.message, {
-        status: 500
-      })
-
-      return res
+      return new Response(err.message, status500)
     }
   }
 
@@ -43,8 +40,6 @@ module.exports = (config = {}) => {
 
     req.path = url.pathname || '/'
     req.query = url.queryparams
-    req.search = url.search
-    req.hostname = url.hostname
 
     const match = router.find(req.method, req.path)
     if (match.handlers.length > 0) {

package.json

@@ -14,6 +14,10 @@
     "type": "git",
     "url": "git+https://github.com/BackendStack21/0http-bun.git"
   },
+  "devDependencies": {
+    "0http-bun": "^1.0.0",
+    "mitata": "^0.1.11"
+  },
   "keywords": [
     "http",
     "server",