linting

Author: jkyberneees

lib/router/sequential.js

@@ -58,14 +58,14 @@ module.exports = (config = {}) => {
    */
   let cache = null
   if (cacheSize > 0) {
-    cache = new Cache({ 
+    cache = new Cache({
       max: cacheSize,
       updateAgeOnGet: false, // Disable age updates for better performance
       updateAgeOnHas: false
     })
   } else if (cacheSize < 0) {
     // Reduced from 100k to 50k for better memory efficiency while maintaining performance
-    cache = new Cache({ 
+    cache = new Cache({
       max: 50000,
       updateAgeOnGet: false,
       updateAgeOnHas: false

lib/utils/queryparams.js

@@ -7,7 +7,7 @@ const EMPTY_QUERY = Object.freeze(Object.create(null))
 module.exports = (req, url) => {
   // Single indexOf call - more efficient than multiple operations
   const questionMarkIndex = url.indexOf('?')
-  
+
   if (questionMarkIndex === -1) {
     // Fast path: no query string
     req.path = url
@@ -17,7 +17,7 @@ module.exports = (req, url) => {
 
   // Use Object.create(null) for prototype pollution protection
   const query = Object.create(null)
-  
+
   // Extract path and search in one operation each
   req.path = url.slice(0, questionMarkIndex)
   const search = url.slice(questionMarkIndex + 1)
@@ -30,13 +30,13 @@ module.exports = (req, url) => {
 
   // Process query parameters with optimized URLSearchParams handling
   const searchParams = new URLSearchParams(search.replace(/\[\]=/g, '='))
-  
+
   for (const [name, value] of searchParams.entries()) {
     // Use Set for O(1) dangerous property lookup instead of multiple string comparisons
     if (DANGEROUS_PROPERTIES.has(name)) {
       continue // Skip dangerous property names
     }
-    
+
     const existing = query[name]
     if (existing !== undefined) {
       // Optimized array handling - check type once, then branch

tooling/advanced-pollution-test.js

@@ -12,35 +12,35 @@ console.log('Advanced prototype pollution protection test...\n')
 const testCases = [
   // Standard URLSearchParams parsing might decode these differently
   '/test?__proto__=polluted',
-  '/test?constructor=polluted', 
+  '/test?constructor=polluted',
   '/test?prototype=polluted',
-  
+
   // URL encoded versions
-  '/test?%5F%5Fproto%5F%5F=polluted',  // __proto__
-  '/test?constructor%2Eprototype=polluted',  // constructor.prototype
-  
+  '/test?%5F%5Fproto%5F%5F=polluted', // __proto__
+  '/test?constructor%2Eprototype=polluted', // constructor.prototype
+
   // Multiple same-name parameters (should create arrays)
   '/test?__proto__=value1&__proto__=value2',
   '/test?constructor=value1&constructor=value2',
-  
+
   // Mixed dangerous and safe parameters
-  '/test?safe=value&__proto__=polluted&another=safe',
+  '/test?safe=value&__proto__=polluted&another=safe'
 ]
 
 console.log('Before tests:')
 console.log('- Object.prototype.polluted:', Object.prototype.polluted)
 console.log('- Object.prototype.testProp:', Object.prototype.testProp)
 
 // Mock request/response objects
-function createMockReq(url) {
+function createMockReq (url) {
   return {
     method: 'GET',
-    url: url,
+    url,
     headers: {}
   }
 }
 
-function createMockRes() {
+function createMockRes () {
   return {
     statusCode: 200,
     writeHead: () => {},
@@ -54,18 +54,18 @@ const router = sequential()
 // Test each case
 testCases.forEach((testUrl, index) => {
   console.log(`\n--- Test ${index + 1}: ${testUrl} ---`)
-  
+
   const req = createMockReq(testUrl)
   const res = createMockRes()
-  
+
   // Mock a simple route handler
   router.get('/test', (req, res) => {
     console.log('Query keys:', Object.keys(req.query))
     console.log('Query values:', req.query)
     console.log('Prototype:', Object.getPrototypeOf(req.query))
     res.end()
   })
-  
+
   try {
     router.lookup(req, res)
   } catch (error) {
@@ -80,6 +80,7 @@ console.log('- Object.prototype.testProp:', Object.prototype.testProp)
 // Test if we can access dangerous properties through any means
 try {
   const testObj = {}
+  /* eslint-disable no-proto */
   console.log('- testObj.__proto__:', testObj.__proto__)
   console.log('- testObj.constructor:', testObj.constructor)
 } catch (e) {

tooling/performance-test.js

@@ -42,15 +42,15 @@ const scenarios = [
 ]
 
 // Mock request/response objects
-function createMockReq(url) {
+function createMockReq (url) {
   return {
     method: 'GET',
-    url: url,
+    url,
     headers: {}
   }
 }
 
-function createMockRes() {
+function createMockRes () {
   return {
     statusCode: 200,
     writeHead: () => {},
@@ -63,35 +63,35 @@ function createMockRes() {
 for (const config of testConfigs) {
   console.log(`📊 Testing: ${config.name}`)
   console.log('─'.repeat(50))
-  
+
   for (const scenario of scenarios) {
     const router = sequential({ cacheSize: config.cacheSize })
     scenario.setup(router)
-    
+
     // Warm up
     for (let i = 0; i < 1000; i++) {
       const req = createMockReq(scenario.url)
       const res = createMockRes()
       router.lookup(req, res)
     }
-    
+
     // Benchmark
     const iterations = 50000
     const start = process.hrtime.bigint()
-    
+
     for (let i = 0; i < iterations; i++) {
       const req = createMockReq(scenario.url)
       const res = createMockRes()
       router.lookup(req, res)
     }
-    
+
     const end = process.hrtime.bigint()
     const totalTime = Number(end - start)
     const avgTime = totalTime / iterations
-    
+
     console.log(`  ${scenario.name.padEnd(25)} ${(avgTime / 1000).toFixed(2).padStart(8)} µs/op`)
   }
-  
+
   console.log()
 }
 
@@ -105,22 +105,22 @@ const queryTests = [
   '/path?simple=value',
   '/path?a=1&b=2&c=3&d=4&e=5',
   '/path?arr=1&arr=2&arr=3&arr=4',
-  '/path?complex=val&simple=test&arr=1&arr=2&encoded=%20%21',
+  '/path?complex=val&simple=test&arr=1&arr=2&encoded=%20%21'
 ]
 
 for (const url of queryTests) {
   const iterations = 100000
   const start = process.hrtime.bigint()
-  
+
   for (let i = 0; i < iterations; i++) {
     const req = {}
     queryparams(req, url)
   }
-  
+
   const end = process.hrtime.bigint()
   const totalTime = Number(end - start)
   const avgTime = totalTime / iterations
-  
+
   const queryDesc = url.includes('?') ? `${url.split('?')[1].split('&').length} params` : 'no query'
   console.log(`  ${queryDesc.padEnd(15)} ${(avgTime / 1000).toFixed(2).padStart(8)} µs/op`)
 }
@@ -143,7 +143,7 @@ for (let i = 0; i < 10000; i++) {
     `/users/${i}?query=test`,
     `/nonexistent/${i}`
   ]
-  
+
   for (const url of urls) {
     const req = createMockReq(url)
     const res = createMockRes()

tooling/prototype-pollution-test.js

@@ -18,7 +18,7 @@ router.get('/test', (req, res) => {
   console.log('Has __proto__ property:', '__proto__' in req.query)
   console.log('Has constructor property:', 'constructor' in req.query)
   console.log('Query object prototype:', Object.getPrototypeOf(req.query))
-  
+
   res.writeHead(200, { 'Content-Type': 'application/json' })
   res.end(JSON.stringify({
     query: req.query,
@@ -41,15 +41,15 @@ const testCases = [
 console.log('Before tests - Object.prototype.polluted:', Object.prototype.polluted)
 
 // Mock request/response objects for testing
-function createMockReq(url) {
+function createMockReq (url) {
   return {
     method: 'GET',
-    url: url,
+    url,
     headers: {}
   }
 }
 
-function createMockRes() {
+function createMockRes () {
   let data = ''
   return {
     statusCode: 200,
@@ -63,10 +63,10 @@ function createMockRes() {
 // Test each case
 testCases.forEach((testUrl, index) => {
   console.log(`\n--- Test ${index + 1}: ${testUrl} ---`)
-  
+
   const req = createMockReq(testUrl)
   const res = createMockRes()
-  
+
   try {
     router.lookup(req, res)
     const responseData = JSON.parse(res._getData())

tooling/queryparams-benchmark.js

@@ -8,15 +8,15 @@ const queryparams = require('../lib/utils/queryparams')
 
 // Test cases that cover different scenarios
 const testCases = [
-  '/path',                                    // No query string
-  '/path?',                                  // Empty query string  
-  '/path?simple=value',                      // Single parameter
-  '/path?a=1&b=2&c=3',                      // Multiple parameters
-  '/path?arr=1&arr=2&arr=3',                // Array parameters
+  '/path', // No query string
+  '/path?', // Empty query string
+  '/path?simple=value', // Single parameter
+  '/path?a=1&b=2&c=3', // Multiple parameters
+  '/path?arr=1&arr=2&arr=3', // Array parameters
   '/path?complex=val1&simple=val2&arr=1&arr=2', // Mixed parameters
-  '/path?encoded=%20%21%40%23',             // URL encoded values
-  '/path?empty=&another=value',             // Empty values
-  '/path?dangerous=safe&normal=value',      // Safe parameters with dangerous-sounding names
+  '/path?encoded=%20%21%40%23', // URL encoded values
+  '/path?empty=&another=value', // Empty values
+  '/path?dangerous=safe&normal=value' // Safe parameters with dangerous-sounding names
 ]
 
 console.log('Micro-benchmarking queryparams performance...\n')
@@ -33,25 +33,25 @@ for (let i = 0; i < 1000; i++) {
 testCases.forEach((url, index) => {
   const iterations = 100000
   const req = {}
-  
+
   console.log(`Test ${index + 1}: ${url}`)
-  
+
   const start = process.hrtime.bigint()
-  
+
   for (let i = 0; i < iterations; i++) {
     // Create a fresh req object each time to avoid caching effects
     const testReq = {}
     queryparams(testReq, url)
   }
-  
+
   const end = process.hrtime.bigint()
   const totalTime = Number(end - start)
   const avgTime = totalTime / iterations
-  
+
   console.log(`  ${iterations.toLocaleString()} iterations`)
   console.log(`  Average: ${(avgTime / 1000).toFixed(2)} µs per operation`)
   console.log(`  Total: ${(totalTime / 1000000).toFixed(2)} ms`)
-  
+
   // Verify the result is correct
   queryparams(req, url)
   console.log(`  Result: path="${req.path}", query keys=[${Object.keys(req.query).join(', ')}]`)
@@ -62,7 +62,7 @@ testCases.forEach((url, index) => {
 console.log('Security verification:')
 const securityTests = [
   '/test?__proto__=polluted',
-  '/test?constructor=dangerous', 
+  '/test?constructor=dangerous',
   '/test?prototype=unsafe',
   '/test?safe=value&__proto__=attack&normal=ok'
 ]