bugfix version checking

Author: martin-raden

ChangeLog

@@ -16,9 +16,22 @@
 
 - fix deprecation warning
 
+# CopomuS.py
+
+- bugfix version checking
+
 ################################################################################  
 ################################################################################
 
+250219 Martin Raden
+ * python/CopomuS.py
+ * python/copomus/IntaRNA.py
+   * bugfix version checking (old string comparison fails for "3.12" < "3.7")
+
+250214 Martin Raden
+ + conda-build-env.yml : environment to build IntaRNA
+ * new github build workflow
+
 250213 Martin Raden
  * R/IntaRNA_plotRegions.R
    * fix deprecation warning when using element_lines() with ggplot >= 3.4.0

python/CopomuS.py

@@ -11,9 +11,6 @@
 import sys
 from platform import python_version
 
-if python_version() < __python_min__:
-    sys.stderr.write(f'CopomuS requires python >= {__python_min__}\n')
-    sys.exit(1)
 
 import csv
 from tempfile import gettempdir
@@ -26,6 +23,10 @@
 from copomus.mutation_generators import get_generator
 
 
+if IntaRNA.version_tuple(python_version()) < IntaRNA.version_tuple(__python_min__):
+    sys.stderr.write(f'CopomuS requires python >= {__python_min__}\n')
+    sys.exit(1)
+
 
 class CopomuS:
     def __init__(self):

python/copomus/IntaRNA.py

@@ -11,17 +11,25 @@ class IntaRNA:
     def __init__(self):
         pass
 
+    @staticmethod
+    def version_tuple(versionstring: str):
+        """
+        Decomposes a version string into a tuple of entries
+        :param versionstring: The string encoding of a version, i.e. dot-separated numbers
+        """
+        return tuple(map(int, versionstring.split('.')))
+
     @staticmethod
     def check_binary(required_version: str):
         """
-        Checks weather or not the IntaRNA binary can be found in PATH and exits with returncode 1 if not found.
+        Checks weather or not the IntaRNA binary can be found in PATH and exits with return code 1 if not found.
         :param required_version: The minimum required version for IntaRNA
         """
         p = run('IntaRNA --version', shell=True, stdout=PIPE, stderr=PIPE, universal_newlines=True)
         if p.returncode:
             sys.stderr.write('Please add the IntaRNA binary to your PATH.\n')
             sys.exit(1)
-        if p.stdout.split('\n')[0].split()[1] < required_version:
+        if IntaRNA.version_tuple(p.stdout.split('\n')[0].split()[1]) < IntaRNA.version_tuple(required_version):
             sys.stderr.write(f'This tool requires IntaRNA version {required_version}, please upgrade\n')
             sys.exit(1)