Skip to content

Commit 5710bdb

Browse files
committed
Fix method field when scanning for data sets
1 parent 460c222 commit 5710bdb

File tree

2 files changed

+27
-16
lines changed

2 files changed

+27
-16
lines changed

EnrichmentMapPlugin/src/main/java/org/baderlab/csplugins/enrichmentmap/view/mastermap/EditDataSetPanel.java

Lines changed: 23 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -120,8 +120,15 @@ public DataSetParameters createDataSetParameters() {
120120

121121
@AfterInjection
122122
private void createContents() {
123+
createBody();
124+
if(initDataSet != null) {
125+
initialize(initDataSet);
126+
}
127+
}
128+
129+
130+
private void createBody() {
123131
nameText = pathTextFactory.create("* Name:", null);
124-
nameText.setText(initDataSet != null ? initDataSet.getName() : null);
125132
nameText.getTextField().getDocument().addDocumentListener(SwingUtil.simpleDocumentListener(() ->
126133
firePropertyChange(PROP_NAME, null, getDisplayName())
127134
));
@@ -137,32 +144,18 @@ private void createContents() {
137144
makeSmall(analysisLabel, analysisTypeCombo);
138145

139146
enrichments1Text = pathTextFactory.create("* Enrichments:", FileBrowser.Filter.ENRICHMENT);
140-
enrichments1Text.setText(initDataSet != null ? initDataSet.getFiles().getEnrichmentFileName1() : null);
141-
142147
enrichments2Text = pathTextFactory.create("Enrichments 2:", FileBrowser.Filter.ENRICHMENT);
143-
enrichments2Text.setText(initDataSet != null ? initDataSet.getFiles().getEnrichmentFileName2() : null);
144-
145148
gmtText = pathTextFactory.create("GMT:", FileBrowser.Filter.GMT);
146-
gmtText.setText(initDataSet != null ? initDataSet.getFiles().getGMTFileName() : null);
147-
148149
expressionsText = pathTextFactory.create("Expressions:", FileBrowser.Filter.EXPRESSION);
149-
expressionsText.setText(initDataSet != null ? initDataSet.getFiles().getExpressionFileName() : null);
150-
151150
ranksText = pathTextFactory.create("Ranks:", FileBrowser.Filter.RANK);
152-
ranksText.setText(initDataSet != null ? initDataSet.getFiles().getRankedFile() : null);
153-
154151
classesText = pathTextFactory.create("Classes:", FileBrowser.Filter.CLASS);
155-
classesText.setText(initDataSet != null ? initDataSet.getFiles().getClassFile() : null);
156152
classesText.getTextField().getDocument().addDocumentListener(SwingUtil.simpleDocumentListener(this::updateClasses));
157153

158154
JLabel positive = new JLabel("Positive:");
159155
JLabel negative = new JLabel("Negative:");
160156
positiveText = new JTextField();
161157
negativeText = new JTextField();
162-
positiveText.setText(initDataSet != null ? initDataSet.getFiles().getPhenotype1() : null);
163-
negativeText.setText(initDataSet != null ? initDataSet.getFiles().getPhenotype2() : null);
164158
makeSmall(positive, negative, positiveText, negativeText);
165-
166159

167160
GroupLayout layout = new GroupLayout(this);
168161
setLayout(layout);
@@ -261,6 +254,21 @@ private void createContents() {
261254
}
262255

263256

257+
private void initialize(DataSetParameters initDataSet) {
258+
nameText.setText(initDataSet.getName());
259+
DataSetFiles files = initDataSet.getFiles();
260+
enrichments1Text.setText(files.getEnrichmentFileName1());
261+
enrichments2Text.setText(files.getEnrichmentFileName2());
262+
gmtText.setText(files.getGMTFileName());
263+
expressionsText.setText(files.getExpressionFileName());
264+
ranksText.setText(files.getRankedFile());
265+
classesText.setText(files.getClassFile());
266+
positiveText.setText(files.getPhenotype1());
267+
negativeText.setText(files.getPhenotype2());
268+
analysisTypeCombo.setSelectedItem(ComboItem.of(initDataSet.getMethod()));
269+
}
270+
271+
264272
@Override
265273
public List<String> validateInput() {
266274
List<String> err = new ArrayList<>();

EnrichmentMapPlugin/src/main/java/org/baderlab/csplugins/enrichmentmap/view/mastermap/PathTextField.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,10 @@ public String getText() {
7272
}
7373

7474
public void setText(String textValue) {
75-
textField.setText(textValue);
75+
if(textValue != null) {
76+
textField.setText(textValue);
77+
textField.setCaretPosition(textValue.length());
78+
}
7679
}
7780

7881
public void hideError() {

0 commit comments

Comments
 (0)