Skip to content

Commit 59ad601

Browse files
committed
Use dataset for hypergeometric universe
1 parent 61cae3c commit 59ad601

File tree

2 files changed

+17
-13
lines changed

2 files changed

+17
-13
lines changed

EnrichmentMapPlugin/src/main/java/org/baderlab/csplugins/enrichmentmap/model/UniverseType.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,16 +12,16 @@ public enum UniverseType {
1212
USER_DEFINED;
1313

1414

15-
public int getGeneUniverse(EnrichmentMap map, String dataset, int userDefinedUniverseSize) {
16-
GeneExpressionMatrix expressionSets = map.getDataSet(dataset).getExpressionSets();
15+
public int getGeneUniverse(EnrichmentMap map, String datasetName, int userDefinedUniverseSize) {
16+
EMDataSet dataset = map.getDataSet(datasetName);
1717
switch(this) {
1818
default:
1919
case GMT:
20-
return map.getNumberOfGenes();
20+
return dataset.getGeneSetGenes().size(); // number of un-filtered genes from the original GMT file (GMT)
2121
case EXPRESSION_SET:
22-
return expressionSets.getExpressionUniverse();
22+
return dataset.getExpressionSets().getExpressionUniverse();
2323
case INTERSECTION:
24-
return expressionSets.getExpressionMatrix().size();
24+
return dataset.getExpressionSets().getExpressionMatrix().size();
2525
case USER_DEFINED:
2626
return userDefinedUniverseSize;
2727
}

EnrichmentMapPlugin/src/main/java/org/baderlab/csplugins/enrichmentmap/view/postanalysis/PAWeightPanel.java

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -342,9 +342,11 @@ private JPanel createHypergeomCard() {
342342
}
343343

344344
private JPanel createHypergeomSamplePanel() {
345-
JLabel title = new JLabel("Genes in sample (n)");
346-
hyperIntersectButton = new JRadioButton("Intersection");
347-
JRadioButton hyperSigButton = new JRadioButton("Signature gene set");
345+
JLabel title = new JLabel("Signature Genes to Use");
346+
hyperIntersectButton = new JRadioButton("Filtered Signature Gene Sets");
347+
hyperIntersectButton.setToolTipText("Signature genes are restricted to just genes that are also found in the current dataset.");
348+
JRadioButton hyperSigButton = new JRadioButton("Signature Gene Sets");
349+
hyperSigButton.setToolTipText("Signature gene set contains all loaded genes.");
348350
makeSmall(title, hyperSigButton, hyperIntersectButton);
349351

350352
ButtonGroup buttonGroup = new ButtonGroup();
@@ -644,7 +646,7 @@ public FilterMetricSet getResults() {
644646
return results;
645647
}
646648

647-
public FilterMetric createFilterMetric(String dataset) {
649+
public FilterMetric createFilterMetric(String datasetName) {
648650
String text = rankTestTextField.getText();
649651
double value = Double.parseDouble(text);
650652
PostAnalysisFilterType type = getFilterType();
@@ -660,18 +662,20 @@ public FilterMetric createFilterMetric(String dataset) {
660662
return new FilterMetric.Specific(value);
661663
case HYPERGEOM:
662664
UniverseType universeType = getUniverseType();
663-
int universe = universeType.getGeneUniverse(map, dataset, getUserDefinedUniverseSize());
665+
int userDefined = getUserDefinedUniverseSize();
666+
int universe = universeType.getGeneUniverse(map, datasetName, userDefined);
664667
FilterMetric.Hypergeom hyperFilterMetric = new FilterMetric.Hypergeom(value, universe);
665668
if(hyperIntersectButton.isSelected()) {
666-
Set<Integer> universeGenes = map.getAllEnrichmentGenes();
669+
EMDataSet dataset = map.getDataSet(datasetName);
670+
Set<Integer> universeGenes = dataset.getGeneSetGenes();
667671
hyperFilterMetric.setUniverseFilter(universeGenes);
668672
}
669673
return hyperFilterMetric;
670674
case MANN_WHIT_TWO_SIDED:
671675
case MANN_WHIT_GREATER:
672676
case MANN_WHIT_LESS:
673-
String rankingName = mannWhitRanks.get(dataset);
674-
Ranking ranking = rankingName == null ? null : map.getDataSet(dataset).getRanks().get(rankingName);
677+
String rankingName = mannWhitRanks.get(datasetName);
678+
Ranking ranking = rankingName == null ? null : map.getDataSet(datasetName).getRanks().get(rankingName);
675679
return new FilterMetric.MannWhit(type, value, rankingName, ranking);
676680
default:
677681
return null;

0 commit comments

Comments
 (0)