Skip to content

Commit 95881c2

Browse files
committed
Add 'qvalueColumn' argument to 'build-table' command.
Refs #416
1 parent 208d772 commit 95881c2

File tree

1 file changed

+12
-7
lines changed
  • EnrichmentMapPlugin/src/main/java/org/baderlab/csplugins/enrichmentmap/commands/tunables

1 file changed

+12
-7
lines changed

EnrichmentMapPlugin/src/main/java/org/baderlab/csplugins/enrichmentmap/commands/tunables/TableTunables.java

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,12 @@ public class TableTunables {
2020
@Tunable(required=true, description="Name of column that contains the list of genes.")
2121
public String genesColumn;
2222

23-
@Tunable(required=true, description="Name of column that contains p values.")
23+
@Tunable(description="Name of column that contains p values. At least one of 'pvalueColumn' or 'qvalueColumn' must be provided.")
2424
public String pvalueColumn;
2525

26+
@Tunable(description="Name of column that contains q values. At least one of 'pvalueColumn' or 'qvalueColumn' must be provided.")
27+
public String qvalueColumn;
28+
2629
@Tunable(description="Name of column that contains the gene set description (optional).")
2730
public String descriptionColumn;
2831

@@ -51,14 +54,18 @@ private CyTable getTable() {
5154
public TableParameters getTableParameters() throws IllegalArgumentException {
5255
CyTable table = getTable();
5356
if(table == null)
54-
throw new IllegalArgumentException("Table '" + table + "' is invalid.");
57+
throw new IllegalArgumentException("Table '" + this.table + "' is invalid.");
5558

59+
if(pvalueColumn == null && qvalueColumn == null)
60+
throw new IllegalArgumentException("At least one of 'pvalueColumn' or 'qvalueColumn' must be provided.");
61+
5662
validateColumn(table, nameColumn, false, String.class, true);
5763
validateColumn(table, genesColumn, true, String.class, true);
58-
validateColumn(table, pvalueColumn, false, Double.class, true);
5964
validateColumn(table, descriptionColumn, false, String.class, false);
65+
validateColumn(table, pvalueColumn, false, Double.class, false);
66+
validateColumn(table, qvalueColumn, false, Double.class, false);
6067

61-
return new TableParameters(table, nameColumn, genesColumn, pvalueColumn, null, descriptionColumn, null);
68+
return new TableParameters(table, nameColumn, genesColumn, pvalueColumn, qvalueColumn, descriptionColumn, null);
6269
}
6370

6471

@@ -69,10 +76,8 @@ private static void validateColumn(CyTable table, String name, boolean isList, C
6976
return;
7077

7178
CyColumn column = table.getColumn(name);
72-
if(column == null && required)
73-
throw new IllegalArgumentException("Column '" + name + "' is invalid.");
7479
if(column == null)
75-
return;
80+
throw new IllegalArgumentException("Column '" + name + "' is invalid.");
7681

7782
// if the column exists it must still be of the required type
7883
if((isList && !column.getListElementType().equals(type)) || (!isList && !column.getType().equals(type)))

0 commit comments

Comments
 (0)