Skip to content

Commit e61d073

Browse files
committed
Use FDR q-value for STRING import.
1 parent 78bb8a1 commit e61d073

File tree

4 files changed

+34
-7
lines changed

4 files changed

+34
-7
lines changed

EnrichmentMapPlugin/src/main/java/org/baderlab/csplugins/enrichmentmap/commands/tunables/TableTunables.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ public TableParameters getTableParameters() throws IllegalArgumentException {
5858
validateColumn(table, pvalueColumn, false, Double.class, true);
5959
validateColumn(table, descriptionColumn, false, String.class, false);
6060

61-
return new TableParameters(table, nameColumn, genesColumn, pvalueColumn, descriptionColumn, null);
61+
return new TableParameters(table, nameColumn, genesColumn, pvalueColumn, null, descriptionColumn, null);
6262
}
6363

6464

EnrichmentMapPlugin/src/main/java/org/baderlab/csplugins/enrichmentmap/model/TableParameters.java

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,16 +15,26 @@ public class TableParameters {
1515
private final String nameColumn;
1616
private final String genesColumn;
1717
private final String pvalueColumn;
18+
private final String qvalueColumn;
1819
private final Optional<String> descriptionColumn;
1920

2021
private final @Nullable Predicate<CyRow> filter;
2122

2223

23-
public TableParameters(CyTable table, String nameColumn, String genesColumn, String pvalueColumn, String descriptionColumn, Predicate<CyRow> filter) {
24+
public TableParameters(
25+
CyTable table,
26+
String nameColumn,
27+
String genesColumn,
28+
String pvalueColumn,
29+
String qvalueColumn,
30+
String descriptionColumn,
31+
Predicate<CyRow> filter
32+
) {
2433
this.table = Objects.requireNonNull(table);
2534
this.nameColumn = Objects.requireNonNull(nameColumn);
2635
this.genesColumn = Objects.requireNonNull(genesColumn);
27-
this.pvalueColumn = Objects.requireNonNull(pvalueColumn);
36+
this.pvalueColumn = pvalueColumn;
37+
this.qvalueColumn = qvalueColumn;
2838
this.descriptionColumn = Optional.ofNullable(descriptionColumn);
2939
this.filter = filter;
3040
}
@@ -44,6 +54,10 @@ public String getGenesColumn() {
4454
public String getPvalueColumn() {
4555
return pvalueColumn;
4656
}
57+
58+
public String getQvalueColumn() {
59+
return qvalueColumn;
60+
}
4761

4862
public Optional<String> getDescriptionColumn() {
4963
return descriptionColumn;

EnrichmentMapPlugin/src/main/java/org/baderlab/csplugins/enrichmentmap/parsers/LoadEnrichmentsFromTableTask.java

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,10 +48,21 @@ public void run(TaskMonitor taskMonitor) {
4848
if(filter == null || filter.test(row)) {
4949
List<String> genes = row.getList(tableParams.getGenesColumn(), String.class);
5050
String name = row.get(tableParams.getNameColumn(), String.class);
51-
Double pvalue = row.get(tableParams.getPvalueColumn(), Double.class);
51+
52+
Double pvalue = null;
53+
if(tableParams.getPvalueColumn() != null)
54+
pvalue = row.get(tableParams.getPvalueColumn(), Double.class);
55+
if(pvalue == null)
56+
pvalue = 1.0;
57+
58+
Double qvalue = null;
59+
if(tableParams.getQvalueColumn() != null)
60+
qvalue = row.get(tableParams.getQvalueColumn(), Double.class);
61+
if(qvalue == null)
62+
qvalue = 1.0;
5263

5364
// Skip row if data is invalid in any way
54-
if(genes == null || genes.isEmpty() || name == null || name.isEmpty() || pvalue == null)
65+
if(genes == null || genes.isEmpty() || name == null || name.isEmpty())
5566
continue;
5667

5768
String description = null;
@@ -72,12 +83,14 @@ public void run(TaskMonitor taskMonitor) {
7283
int gsSize = gs.getGenes().size();
7384
genesets.put(name, gs);
7485

75-
GenericResult result = new GenericResult(name, description, pvalue, gsSize);
86+
GenericResult result = new GenericResult(name, description, pvalue, gsSize, qvalue);
7687
enrichments.getEnrichments().put(name, result);
7788
}
7889
tm.inc();
7990
}
8091

92+
map.getParams().setFDR(tableParams.getQvalueColumn() != null);
93+
8194
// TODO if we add support for fdr q-value column then make sure to set the following...
8295
// dataset.getMap().getParams().setFDR(FDR);
8396
}

EnrichmentMapPlugin/src/main/java/org/baderlab/csplugins/enrichmentmap/view/creation/genemania/StringDialogPage.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ public DataSetParameters getDataSetParameters() {
5858
CyTable table = getStringTable(tableManager);
5959

6060
TableParameters tableParams =
61-
new TableParameters(table, NAME_COLUMN, GENES_COLUMN, FDR_COLUMN, DESC_COLUMN, filter);
61+
new TableParameters(table, NAME_COLUMN, GENES_COLUMN, null, FDR_COLUMN, DESC_COLUMN, filter);
6262

6363
return new DataSetParameters(dataSetName, tableParams);
6464
}

0 commit comments

Comments
 (0)