Skip to content

Commit fbe3378

Browse files
committed
Clean up chart section of main panel.
1 parent 2ef340e commit fbe3378

File tree

2 files changed

+10
-41
lines changed

2 files changed

+10
-41
lines changed

EnrichmentMapPlugin/src/main/java/org/baderlab/csplugins/enrichmentmap/view/control/ControlPanel.java

Lines changed: 4 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -458,10 +458,7 @@ JScrollPane getScrollPane() {
458458

459459
protected JButton getResetStyleButton() {
460460
if (resetStyleButton == null) {
461-
resetStyleButton = new JButton(ICON_REFRESH);
462-
resetStyleButton.setFont(serviceRegistrar.getService(IconManager.class).getIconFont(13.0f));
463-
resetStyleButton.setToolTipText("Reset Style");
464-
461+
resetStyleButton = new JButton("Reset Style");
465462
if (isAquaLAF())
466463
resetStyleButton.putClientProperty("JButton.buttonType", "gradient");
467464
}
@@ -496,10 +493,8 @@ class EMViewControlPanel extends AbstractViewControlPanel {
496493

497494
private DataSetSelector dataSetSelector;
498495
private JCheckBox publicationReadyCheck;
499-
private JButton setEdgeWidthButton;
500496
private JButton showLegendButton;
501497

502-
private JLabel aaLink;
503498
private JComboBox<ChartData> chartDataCombo;
504499
private JComboBox<ChartType> chartTypeCombo;
505500
private JComboBox<ColorScheme> chartColorsCombo;
@@ -718,8 +713,8 @@ private JPanel createFilterPanel() {
718713

719714
private JPanel createStylePanel() {
720715
makeSmall(chartDataLabel, chartTypeLabel, chartColorsLabel);
721-
makeSmall(getAutoAnnotateOpenLink(), getChartDataCombo(), getChartTypeCombo(), getChartColorsCombo(), getShowChartLabelsCheck());
722-
makeSmall(getPublicationReadyCheck(), getShowLegendButton(), getSetEdgeWidthButton(), getResetStyleButton());
716+
makeSmall(getChartDataCombo(), getChartTypeCombo(), getChartColorsCombo(), getShowChartLabelsCheck());
717+
makeSmall(getPublicationReadyCheck(), getShowLegendButton(), getResetStyleButton());
723718

724719
final JPanel panel = new JPanel();
725720
panel.setBorder(LookAndFeelUtil.createTitledBorder("Style"));
@@ -738,7 +733,6 @@ private JPanel createStylePanel() {
738733
)
739734
.addPreferredGap(ComponentPlacement.RELATED)
740735
.addGroup(layout.createParallelGroup(LEADING, true)
741-
.addComponent(getAutoAnnotateOpenLink(), DEFAULT_SIZE, DEFAULT_SIZE, Short.MAX_VALUE)
742736
.addComponent(getChartDataCombo(), DEFAULT_SIZE, DEFAULT_SIZE, Short.MAX_VALUE)
743737
.addComponent(getChartTypeCombo(), DEFAULT_SIZE, DEFAULT_SIZE, Short.MAX_VALUE)
744738
.addComponent(getChartColorsCombo(), DEFAULT_SIZE, DEFAULT_SIZE, Short.MAX_VALUE)
@@ -747,16 +741,13 @@ private JPanel createStylePanel() {
747741
)
748742
)
749743
.addGroup(layout.createSequentialGroup()
750-
.addComponent(getSetEdgeWidthButton(), PREFERRED_SIZE, DEFAULT_SIZE, PREFERRED_SIZE)
751-
.addPreferredGap(ComponentPlacement.UNRELATED)
752744
.addComponent(getShowLegendButton(), PREFERRED_SIZE, DEFAULT_SIZE, PREFERRED_SIZE)
753745
.addPreferredGap(ComponentPlacement.UNRELATED)
754746
.addComponent(getResetStyleButton(), PREFERRED_SIZE, DEFAULT_SIZE, PREFERRED_SIZE)
755747
)
756748
);
757749

758750
layout.setVerticalGroup(layout.createSequentialGroup()
759-
.addComponent(getAutoAnnotateOpenLink())
760751
.addGroup(layout.createParallelGroup(CENTER, false)
761752
.addComponent(chartDataLabel)
762753
.addComponent(getChartDataCombo(), PREFERRED_SIZE, DEFAULT_SIZE, PREFERRED_SIZE)
@@ -773,7 +764,6 @@ private JPanel createStylePanel() {
773764
.addComponent(getPublicationReadyCheck(), PREFERRED_SIZE, DEFAULT_SIZE, PREFERRED_SIZE)
774765
.addPreferredGap(ComponentPlacement.UNRELATED)
775766
.addGroup(layout.createParallelGroup(CENTER, false)
776-
.addComponent(getSetEdgeWidthButton(), PREFERRED_SIZE, DEFAULT_SIZE, PREFERRED_SIZE)
777767
.addComponent(getShowLegendButton(), PREFERRED_SIZE, DEFAULT_SIZE, PREFERRED_SIZE)
778768
.addComponent(getResetStyleButton(), PREFERRED_SIZE, DEFAULT_SIZE, PREFERRED_SIZE)
779769
)
@@ -892,15 +882,6 @@ DataSetSelector getDataSetSelector() {
892882
}
893883
return dataSetSelector;
894884
}
895-
896-
JLabel getAutoAnnotateOpenLink() {
897-
if (aaLink == null) {
898-
aaLink = SwingUtil.createLinkLabel("Use AutoAnnotate to find clusters of similar gene-sets");
899-
aaLink.setVisible(dependencyChecker.isCommandAvailable("autoannotate", "open"));
900-
aaLink.setBorder(BorderFactory.createEmptyBorder(0, 8, 4, 0));
901-
}
902-
return aaLink;
903-
}
904885

905886

906887
JComboBox<ChartData> getChartDataCombo() {
@@ -1019,15 +1000,7 @@ JCheckBox getPublicationReadyCheck() {
10191000
return publicationReadyCheck;
10201001
}
10211002

1022-
JButton getSetEdgeWidthButton() {
1023-
if (setEdgeWidthButton == null) {
1024-
setEdgeWidthButton = new JButton("Set Signature Edge Width...");
1025-
if (isAquaLAF())
1026-
setEdgeWidthButton.putClientProperty("JButton.buttonType", "gradient");
1027-
}
1028-
return setEdgeWidthButton;
1029-
}
1030-
1003+
10311004
JButton getShowLegendButton() {
10321005
if (showLegendButton == null) {
10331006
showLegendButton = new JButton("Show Legend...");

EnrichmentMapPlugin/src/main/java/org/baderlab/csplugins/enrichmentmap/view/control/ControlPanelMediator.java

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
import java.awt.event.ActionEvent;
1414
import java.awt.event.ActionListener;
1515
import java.awt.event.ItemEvent;
16-
import java.awt.event.MouseAdapter;
1716
import java.awt.event.MouseEvent;
1817
import java.util.ArrayList;
1918
import java.util.Collection;
@@ -585,14 +584,6 @@ private void addListeners(EMViewControlPanel viewPanel, EnrichmentMap map) {
585584
map.getParams().getCreateDistinctEdges()
586585
);
587586
});
588-
589-
viewPanel.getAutoAnnotateOpenLink().addMouseListener(new MouseAdapter() {
590-
@Override public void mouseClicked(MouseEvent e) {
591-
var task = autoAnnotateOpenTaskProvider.get();
592-
syncTaskManager.execute(new TaskIterator(task));
593-
}
594-
});
595-
596587
viewPanel.getChartDataCombo().addItemListener(evt -> {
597588
if (!updating && evt.getStateChange() == ItemEvent.SELECTED) {
598589
updating = true;
@@ -631,7 +622,7 @@ private void addListeners(EMViewControlPanel viewPanel, EnrichmentMap map) {
631622

632623
// MKTODO we should have a warning dialog when resetting the entire style
633624
viewPanel.getResetStyleButton().addActionListener(evt -> resetStyle(map, viewPanel));
634-
viewPanel.getSetEdgeWidthButton().addActionListener(evt -> showEdgeWidthDialog());
625+
// viewPanel.getSetEdgeWidthButton().addActionListener(evt -> showEdgeWidthDialog());
635626
viewPanel.getShowLegendButton().addActionListener(evt -> showLegendDialog());
636627

637628
viewPanel.updateChartDataCombo();
@@ -1006,6 +997,11 @@ private JPopupMenu getOptionsMenu() {
1006997

1007998
menu.addSeparator();
1008999

1000+
1001+
JMenuItem setEdgeWidthItem = new JMenuItem("Set Signature Edge Width...");
1002+
setEdgeWidthItem.addActionListener(evt -> showEdgeWidthDialog());
1003+
menu.add(setEdgeWidthItem);
1004+
10091005
menu.add(new JMenuItem(showAboutDialogActionProvider.get()));
10101006

10111007
return menu;

0 commit comments

Comments
 (0)