Merge pull request #816 from timis1/BAEL-102141

BAEL-102141 Review warnings in kotlin-build job

Author: alvin577austria

core-kotlin-modules/core-kotlin-advanced/src/test/kotlin/com/baeldung/reflection/KClassUnitTest.kt

@@ -43,6 +43,7 @@ class KClassUnitTest {
         val listClass = ArrayList::class
 
         val list = listClass.createInstance()
+        @Suppress("USELESS_IS_CHECK")
         assertTrue(list is ArrayList)
     }
 

core-kotlin-modules/core-kotlin-advanced/src/test/kotlin/com/baeldung/reflection/KMethodUnitTest.kt

@@ -70,6 +70,7 @@ class KMethodUnitTest {
         assertEquals("mutableProperty", mProperty.name)
         assertTrue(mProperty.isLateinit)
         assertFalse(mProperty.isConst)
+        @Suppress("USELESS_IS_CHECK")
         assertTrue(mProperty is KMutableProperty<*>)
     }
 

core-kotlin-modules/core-kotlin-arrays/src/main/kotlin/com/baeldung/array/ArrayAssociate.kt

@@ -1,6 +1,6 @@
 package com.baeldung.array
 
-fun main(args: Array<String>) {
+fun main() {
     val fruits = arrayOf("Pear", "Apple", "Papaya", "Banana")
     println(fruits.associate { Pair(it, it.length) })
     println(fruits.associateBy { it.length })

core-kotlin-modules/core-kotlin-arrays/src/main/kotlin/com/baeldung/array/ArrayReorder.kt

@@ -11,7 +11,7 @@ fun printArray(array: Array<Int>) {
     println()
 }
 
-fun main(args: Array<String>) {
+fun main() {
     var numbers = initArray()
     printArray(numbers)
 

core-kotlin-modules/core-kotlin-arrays/src/main/kotlin/com/baeldung/array/arrayTraversalUnitTest.kt

@@ -2,7 +2,7 @@ package com.baeldung.array
 
 val dice = arrayOf(1, 2, 3, 4, 5, 6)
 
-fun main(args: Array<String>) {
+fun main() {
     // Traversal using for loop
     for (faceValue in dice) {
         println(faceValue)

core-kotlin-modules/core-kotlin-collections-list-2/src/test/kotlin/removeNullAndEmptyValues/RemoveNullAndEmptyValuesUnitTest.kt

@@ -39,6 +39,7 @@ class RemoveNullAndEmptyValuesUnitTest {
                 iterator.remove()
             }
         }
+        @Suppress("UNCHECKED_CAST")
         return listWithNullsAndEmpty as List<String>
     }
 }

core-kotlin-modules/core-kotlin-collections/src/main/kotlin/com/baeldung/sorting/SortingExample.kt

@@ -25,6 +25,7 @@ fun <T : kotlin.Comparable<T>> getSimpleComparator() : Comparator<T> {
 
 fun getComplexComparator() {
     val complexComparator = compareBy<Pair<Int, String>>({it.first}, {it.second})
+    print("Complex comparator result: $complexComparator" )
 }
 
 fun nullHandlingUsage() {

core-kotlin-modules/core-kotlin-files/src/test/kotlin/com/baeldung/deletefile/DeleteFileUnitTest.kt

@@ -3,27 +3,31 @@ package com.baeldung.deletefile
 import org.junit.jupiter.api.Assertions.*
 import org.junit.jupiter.api.Test
 import java.io.File
+import kotlin.io.path.ExperimentalPathApi
+import kotlin.io.path.deleteRecursively
+import kotlin.io.path.exists
+import kotlin.io.path.pathString
 
 class DeleteFileUnitTest {
 
     @Test
     fun `given file path when deleteFile called then file is deleted`() {
-        val tempFile = createTempFile()
+        val tempFile = kotlin.io.path.createTempFile()
         assertTrue(tempFile.exists())
 
-        deleteFile(tempFile.absolutePath)
+        deleteFile(tempFile.pathString)
 
         assertFalse(tempFile.exists())
     }
 
     @Test
     fun `given directory when deleteDirectory called then directory and its contents are deleted`() {
-        val tempDir = createTempDir()
-        val tempFileInDir = File(tempDir, "tempFile.txt").apply { createNewFile() }
+        val tempDir = kotlin.io.path.createTempDirectory()
+        val tempFileInDir = File(tempDir.toFile(), "tempFile.txt").apply { createNewFile() }
         assertTrue(tempDir.exists())
         assertTrue(tempFileInDir.exists())
 
-        deleteDirectory(tempDir)
+        deleteDirectory(tempDir.toFile())
 
         assertFalse(tempDir.exists())
         assertFalse(tempFileInDir.exists())
@@ -38,17 +42,18 @@ class DeleteFileUnitTest {
         }
     }
 
+    @OptIn(ExperimentalPathApi::class)
     @Test
     fun `given directory when deleteDirectory called then directory and its contents are deleted recursively`() {
-        val tempDir = createTempDir()
-        val innerTempDir = File(tempDir, "innerTempDir").apply { mkdir() }
+        val tempDir = kotlin.io.path.createTempDirectory()
+        val innerTempDir = File(tempDir.toFile(), "innerTempDir").apply { mkdir() }
         val tempFileInDir = File(innerTempDir, "tempFile.txt").apply { createNewFile() }
 
         assertTrue(tempDir.exists())
         assertTrue(innerTempDir.exists())
         assertTrue(tempFileInDir.exists())
 
-        tempDir.deleteContentsRecursively()
+        tempDir.deleteRecursively()
 
         assertFalse(tempDir.exists())
         assertFalse(innerTempDir.exists())

core-kotlin-modules/core-kotlin-lang-2/src/test/kotlin/com/baeldung/nullsafety/NullSafetyUnitTest.kt

@@ -11,7 +11,7 @@ class NullSafetyUnitTest {
     @Test
     fun givenNonNullableField_whenAssignValueToIt_thenNotNeedToCheckAgainstNull() {
         //given
-        var a: String = "value"
+        val a: String = "value"
         //a = null compilation error
 
         //then
@@ -21,15 +21,11 @@ class NullSafetyUnitTest {
     @Test
     fun givenNullableField_whenReadValue_thenNeedToCheckAgainstNull() {
         //given
-        var b: String? = "value"
+        val b: String?
         b = null
 
         //when
-        if (b != null) {
-
-        } else {
-            assertNull(b)
-        }
+        assertNull(b)
     }
 
     @Test
@@ -122,7 +118,7 @@ class NullSafetyUnitTest {
     @Test
     fun givenNullableField_whenUsingDoubleExclamationMarkOperatorOnNull_thenThrowNPE() {
         //given
-        var b: String? = "value"
+        val b: String?
         b = null
 
         //when

core-kotlin-modules/core-kotlin-lang-2/src/test/kotlin/com/baeldung/scope/ScopeFunctionsUnitTest.kt

@@ -10,6 +10,7 @@ class ScopeFunctionsUnitTest {
         var called : Boolean = false
 
         fun info(message: String) {
+            println("Message is: $message")
             called = true
         }