Merge pull request #793 from timis1/BAEL-95490

BAEL-95490 Review warnings in kotlin-build job

Author: alvin577austria

core-kotlin-modules/core-kotlin-2/src/main/kotlin/com/baeldung/alias/TypeAlias.kt

@@ -5,12 +5,14 @@ import java.util.concurrent.CompletableFuture
 typealias CreditCard = String
 fun linkCard(card: CreditCard) {
     // omitted
+    println(card)
 }
 
 fun main() {
     val cc: CreditCard = "1234****"
     linkCard(cc)
-    val other = cc.toUpperCase()
+    val other = cc.uppercase()
+    println("CreditCard uppercase: $other")
     linkCard("1234****")
 }
 

core-kotlin-modules/core-kotlin-2/src/main/kotlin/com/baeldung/staticinit/Static.kt

@@ -3,7 +3,7 @@ package com.baeldung.staticinit
 class Static {
 
     companion object {
-        lateinit var answer: String
+        var answer: String
 
         init {
             answer = "42"

core-kotlin-modules/core-kotlin-2/src/test/kotlin/com/baeldung/varargs/Vararg.kt

@@ -10,7 +10,9 @@ fun printStrings(vararg vs: String) {
     vs.forEach { println(it) } // Array<String>
 }
 
-fun createUser(vararg roles: String, username: String, age: Int) {}
+fun createUser(vararg roles: String, username: String, age: Int) {
+    println("Input params. roles: $roles, username: $username, age: $age")
+}
 
 fun main() {
     createUser("admin", "user", username = "me", age = 42)

core-kotlin-modules/core-kotlin-3/src/main/kotlin/com/baeldung/getterssetters/Book.kt

@@ -9,7 +9,7 @@ class Book {
 
     val title: String = DEFAULT_TITLE
         get() {
-            return field.toUpperCase()
+            return field.uppercase()
         }
 
     var rating: Int = 5

core-kotlin-modules/core-kotlin-3/src/main/kotlin/com/baeldung/initblock/Person.kt

@@ -24,5 +24,5 @@ class Person(val firstName: String, val lastName: String) {
 }
 
 fun main() {
-    val p = Person("dehghani")
+    Person("dehghani")
 }

core-kotlin-modules/core-kotlin-3/src/test/kotlin/com/baeldung/getterssetters/BookUnitTest.kt

@@ -18,7 +18,7 @@ class BookUnitTest {
     fun `Given a Book instance, When title property is read, Then custom getter is called`() {
         val book = Book()
 
-        assertEquals(DEFAULT_TITLE.toUpperCase(), book.title)
+        assertEquals(DEFAULT_TITLE.uppercase(), book.title)
     }
 
 

core-kotlin-modules/core-kotlin-4/src/main/kotlin/com/baeldung/hof/HTTPClientStub.kt

@@ -9,9 +9,12 @@ val clientExecutor: ExecutorService = Executors.newSingleThreadExecutor()
 val image = "CDBmleEGw\"V.\t_1᪉-nm@FiUsQuGҘ*-*bQӘ4?`q;?7y1Z~ᡷ}V=BX!%S>TtecHkmdXhi3".encodeToByteArray()
 
 class HTTPClientStub {
-    fun get(imageUrl: URL): Response = Response(200) { image }
+    fun get(imageUrl: URL): Response = Response(200) {
+        println("Image URL is: $imageUrl")
+        image
+    }
     fun put(url: String, body: ByteArray) {
-
+        println("Input params. URL: $url, body: $body")
     }
 }
 

core-kotlin-modules/core-kotlin-4/src/main/kotlin/com/baeldung/hof/HigherOrderFunctions.kt

@@ -60,7 +60,7 @@ fun unrefactoredFunction(imageUrl: URL, objectId: String) {
 
     val imageData = imageResponse.receive()
 
-    val cdnResponse = try {
+    try {
         clientExecutor.submit(Callable { client.put("$CDN_URL/$objectId", imageData) })
             .get(10L, TimeUnit.SECONDS)
     } catch (ex: Exception) {

core-kotlin-modules/core-kotlin-4/src/main/kotlin/com/baeldung/run/RunClass.kt

@@ -14,7 +14,7 @@ class RunClass {
     }
 }
 
-fun main(args: Array<String>) {
+fun main() {
     println("Running the main function")
     RunClass().printInsideClass()
 }

core-kotlin-modules/core-kotlin-4/src/test/kotlin/com/baeldung/varargSpread/VarargSpread.kt

@@ -32,7 +32,7 @@ class VarargSpread {
         val listOfStrings = listOf("ab", "cd")
         assertTrue { concat(*strings) == "abcd" }
         assertTrue { concat2(*strings) == "01abcd" }
-        assertTrue { concat3(strings = *strings, initialValue = "01") == "01abcd" }
+        assertTrue { concat3(strings = strings, initialValue = "01") == "01abcd" }
         assertTrue { concat(*strings, "ef", *moreStrings) == "abcdefghij" }
         assertTrue { concat(*listOfStrings.toTypedArray()) == "abcd" }
     }