BAEL-8537: adaptation to article

Author: LeoHelfferich

core-kotlin-modules/core-kotlin-12/src/main/kotlin/com/baeldung/formatting/NumberFormat.kt

@@ -11,9 +11,6 @@ interface NumberFormat {
 
     /**
      * Returns provided number as string with thousands separator.
-     *
-     * 1000 -> '1.000'
-     * 750000 -> '750.000'
      */
     fun formatted(number: Int): String
 }

core-kotlin-modules/core-kotlin-12/src/test/kotlin/com/baeldung/formatting/NumberFormatUnitTest.kt

@@ -9,29 +9,23 @@ import org.assertj.core.api.Assertions.assertThat
 class NumberFormatUnitTest : ShouldSpec({
 
     // Dynamic generation of tests for each implementation
-    nameToImplementationPairs.forEach { (type, function) ->
+    nameToImplementationPairs.forEach { (name, function) ->
 
         // Property based test (for each implementation)
-        should("return correctly formatted string by $type") {
+        should("return correctly formatted string with $name implementation") {
             checkAll(Arb.positiveInt()) { number ->
                 var result = function(number)
 
-                // Check with regex
                 assertThat(result).containsPattern("^(\\d{1,3}(\\.\\d{3})*|\\d+)$")
-                // Check against original, by removing the separators
                 assertThat(number.toString()).isEqualTo(result.replace(".", ""))
-
-                // Check for general presence & absence of separators
-                if (number > 999) assertThat(result).contains(".")
-                else assertThat(result).doesNotContain(".")
             }
         }
 
-        givenToExpectedPairs.forEach { (number, expected) ->
+        givenToExpectedPairs.forEach { (givenNumber, expectedString) ->
 
             // Parameterised; Example based test
-            should("return expected string '$expected' for $number by $type") {
-                assertThat(function(number)).isEqualTo(expected)
+            should("return '$expectedString' for $givenNumber with $name implementation") {
+                assertThat(function(givenNumber)).isEqualTo(expectedString)
             }
         }