Merge pull request #1360 from yadavan88/warning-rewrite

Fixed many compiler warnings after Scala 3.4 migration

Author: lor6

play-scala/dependency-injection/app/models/Order.scala

@@ -3,7 +3,8 @@ package models
 import play.api.libs.json.Json
 
 object Order {
-  implicit val writes = Json.writes[Order]
+  implicit val writes: play.api.libs.json.OWrites[models.Order] =
+    Json.writes[Order]
 }
 
 case class Order(id: Long, userId: Long, date: Long, isEnterprise: Boolean)

play-scala/dependency-injection/app/models/User.scala

@@ -5,5 +5,6 @@ import play.api.libs.json.Json
 case class User(id: Long, name: String)
 
 object User {
-  implicit val writes = Json.writes[User]
+  implicit val writes: play.api.libs.json.OWrites[models.User] =
+    Json.writes[User]
 }

play-scala/rest-api/app/controllers/TodoListController.scala

@@ -14,8 +14,11 @@ class TodoListController @Inject() (
   todoList += TodoListItem(1, "test", true)
   todoList += TodoListItem(2, "some other value", false)
 
-  implicit val todoListJson = Json.format[TodoListItem]
-  implicit val newTodoListJson = Json.format[NewTodoListItem]
+  implicit val todoListJson: play.api.libs.json.OFormat[models.TodoListItem] =
+    Json.format[TodoListItem]
+  implicit val newTodoListJson
+    : play.api.libs.json.OFormat[models.NewTodoListItem] =
+    Json.format[NewTodoListItem]
 
   // curl localhost:9000/todo
   def getAll(): Action[AnyContent] = Action {

scala-2-modules/scala2-core/README.md

@@ -8,4 +8,5 @@
 - [Introduction to Macros in Scala 2](https://www.baeldung.com/scala/scala2-macros)
 - [Demystifying View and Context Bounds](https://www.baeldung.com/scala/view-context-bounds)
 - [Introduction to Scala](https://www.baeldung.com/scala/scala-intro)
-- [Exception Handling in Scala](https://www.baeldung.com/scala/exception-handling)
+- [Exception Handling in Scala](https://www.baeldung.com/scala/exception-handling)
+- [Usages of Underscore (_) in Scala](https://www.baeldung.com/scala/underscore)

scala-core-modules/scala-core-2/src/main/scala/com/baeldung/scala/underscore/UnderscoreUsages.scala renamed to scala-2-modules/scala2-core/src/main/scala-2/com/baeldung/scala/underscore/UnderscoreUsages.scala

@@ -25,8 +25,8 @@ object ArbitraryArityUnionType extends App {
 
   sealed trait AOrB[A, B]
   object AOrB {
-    implicit def aInstance[A, B](a: A) = new AOrB[A, B] {}
-    implicit def bInstance[A, B](b: B) = new AOrB[A, B] {}
+    implicit def aInstance[A, B](a: A): AOrB[A, B] = new AOrB[A, B] {}
+    implicit def bInstance[A, B](b: B): AOrB[A, B] = new AOrB[A, B] {}
   }
 
   def isIntOrString[T <% String AOrB Int](t: T): String = t match {

scala-2-modules/scala2-core/src/main/scala-2/com/baeldung/scala/uniontypes/ArbitraryArityUnionType.scala

@@ -1,8 +1,9 @@
 package com.baeldung.scala.underscore
 
-import com.baeldung.scala.underscore.UnderscoreUsages._
 import org.scalatest.matchers.should.Matchers
 import org.scalatest.wordspec.AnyWordSpec
+import UnderscoreUsages._
+
 class UnderscoreUsagesUnitTest extends AnyWordSpec with Matchers {
 
   "The underscore" should {
@@ -48,7 +49,7 @@ class UnderscoreUsagesUnitTest extends AnyWordSpec with Matchers {
       b shouldBe "b"
 
       text = "a,b,c,d,e"
-      val Array(a2, _*) = text.split(",")
+      val Array(a2, _*) = text.split(","): @unchecked
       a2 shouldBe "a"
 
       val Array(a3, b3, _, d, e) = text.split(",")

scala-core-modules/scala-core-2/src/test/scala/com/baeldung/scala/underscore/UnderscoreUsagesUnitTest.scala renamed to scala-2-modules/scala2-core/src/test/scala-2/com/baeldung/scala/underscore/UnderscoreUsagesUnitTest.scala

@@ -28,9 +28,10 @@ object GuavaCacheCustomMemoizationKeyConfig {
   val memoizedUnderlyingCustomKeyGuavaCache =
     CacheBuilder.newBuilder().maximumSize(10000L).build[String, Entry[User]]
 
-  implicit val customKeyCacheConfig = CacheConfig(memoization =
-    MemoizationConfig(toStringConverter = CustomKeyGenerator)
-  )
+  implicit val customKeyCacheConfig: scalacache.CacheConfig =
+    CacheConfig(memoization =
+      MemoizationConfig(toStringConverter = CustomKeyGenerator)
+    )
 
   implicit val guavaCache: Cache[User] = GuavaCache(
     memoizedUnderlyingCustomKeyGuavaCache

scala-2-modules/scala2-libraries/src/main/scala-2/com/baeldung/cache/service/SyncQueryCustomMemoizeKeyService.scala

@@ -18,12 +18,15 @@ object Protocol {
 }
 
 object impl {
-  implicit val localDateConvert = localDateConfigConvert(
-    DateTimeFormatter.ISO_DATE
-  )
-  implicit val localDateTimeConvert = localDateTimeConfigConvert(
-    DateTimeFormatter.ISO_DATE_TIME
-  )
+  implicit val localDateConvert: pureconfig.ConfigConvert[java.time.LocalDate] =
+    localDateConfigConvert(
+      DateTimeFormatter.ISO_DATE
+    )
+  implicit val localDateTimeConvert
+    : pureconfig.ConfigConvert[java.time.LocalDateTime] =
+    localDateTimeConfigConvert(
+      DateTimeFormatter.ISO_DATE_TIME
+    )
 }
 
 final case class Port(number: Int) extends AnyVal

scala-2-modules/scala2-libraries/src/main/scala-2/com/baeldung/scala/pureconfig/Configs.scala

@@ -138,9 +138,12 @@ class ShapelessUnitTest extends AnyWordSpec with Matchers {
     "calculate length of variant input types" in {
       import shapeless._
       object polyLength extends Poly1 {
-        implicit val listCase = at[List[Int]](i => i.length)
-        implicit val stringCase = at[String](d => d.length)
-        implicit val arrayCase = at[Array[Int]](d => d.length)
+        implicit val listCase: polyLength.Case.Aux[List[Int], Int] =
+          at[List[Int]](i => i.length)
+        implicit val stringCase: polyLength.Case.Aux[String, Int] =
+          at[String](d => d.length)
+        implicit val arrayCase: polyLength.Case.Aux[Array[Int], Int] =
+          at[Array[Int]](d => d.length)
       }
 
       val list = List(1, 2) :: "123" :: Array(1, 2, 3, 4) :: HNil