SCALA-185: Rename the test folder and add the scope to dependencies a… (#1280)

* SCALA-185: Rename the test folder and add the scope to dependencies at the module level.

* SCALA-185: Improve the poms to reduce repetition

* SCALA-185: Improve the poms to reduce repetition

Author: oforero

scala-with-maven/hello-rest/pom.xml

@@ -19,14 +19,10 @@
       <groupId>org.scala-lang</groupId>
       <artifactId>scala3-library_3</artifactId>
     </dependency>
-    <dependency>
-      <groupId>org.scalatest</groupId>
-      <artifactId>scalatest_3</artifactId>
-    </dependency>
     <dependency>
       <groupId>org.typelevel</groupId>
       <artifactId>cats-effect_3</artifactId>
-      <version>3.5.4</version> <!-- Use the latest version -->
+      <version>3.5.4</version>
     </dependency>
     <dependency>
       <groupId>org.http4s</groupId>

scala-with-maven/hello-world/pom.xml

@@ -13,7 +13,6 @@
 
   <artifactId>hello-world</artifactId>
 
-
   <dependencies>
     <dependency>
       <groupId>org.scala-lang</groupId>
@@ -29,42 +28,12 @@
   </dependencies>
 
   <build>
-    <sourceDirectory>src/main/scala</sourceDirectory>
-    <testSourceDirectory>src/tests/scala</testSourceDirectory>
     <plugins>
-      <plugin>
-        <groupId>net.alchim31.maven</groupId>
-        <artifactId>scala-maven-plugin</artifactId>
-        <version>4.8.1</version>
-        <configuration>
-          <recompileMode>incremental</recompileMode>
-          <scalaVersion>${scala.version}</scalaVersion>
-          <javacArgs>
-            <javacArg>-Xlint:unchecked</javacArg>
-            <javacArg>-Xlint:deprecation</javacArg>
-          </javacArgs>
-        </configuration>
-        <executions>
-          <execution>
-            <goals>
-              <goal>compile</goal>
-              <goal>testCompile</goal>
-            </goals>
-          </execution>
-        </executions>
-      </plugin>
       <plugin>
         <groupId>org.scalatest</groupId>
         <artifactId>scalatest-maven-plugin</artifactId>
-        <version>2.2.0</version>
-        <executions>
-          <execution>
-            <goals>
-              <goal>test</goal>
-            </goals>
-          </execution>
-        </executions>
-      </plugin>      
+      </plugin>
     </plugins>
   </build>
+
 </project>

scala-with-maven/hello-world/src/tests/scala/HelloWorldSpec.scala renamed to scala-with-maven/hello-world/src/test/scala/HelloWorldSpec.scala

@@ -25,7 +25,6 @@
         <groupId>org.scalatest</groupId>
         <artifactId>scalatest_3</artifactId>
         <version>3.2.18</version>
-        <scope>test</scope>
       </dependency>
     </dependencies>  
   </dependencyManagement>
@@ -34,4 +33,49 @@
     <module>hello-world</module>
     <module>hello-rest</module>
   </modules>
+
+  <build>
+    <sourceDirectory>src/main/scala</sourceDirectory>
+    <testSourceDirectory>src/test/scala</testSourceDirectory>
+    <pluginManagement>
+      <plugins>
+        <plugin>
+          <groupId>org.scalatest</groupId>
+          <artifactId>scalatest-maven-plugin</artifactId>
+          <version>2.2.0</version>
+          <executions>
+            <execution>
+              <goals>
+                <goal>test</goal>
+              </goals>
+            </execution>
+          </executions>
+        </plugin>
+      </plugins>
+    </pluginManagement>
+    <plugins>
+      <plugin>
+        <groupId>net.alchim31.maven</groupId>
+        <artifactId>scala-maven-plugin</artifactId>
+        <version>4.8.1</version>
+        <configuration>
+          <recompileMode>incremental</recompileMode>
+          <scalaVersion>${scala.version}</scalaVersion>
+          <javacArgs>
+            <javacArg>-Xlint:unchecked</javacArg>
+            <javacArg>-Xlint:deprecation</javacArg>
+          </javacArgs>
+        </configuration>
+        <executions>
+          <execution>
+            <goals>
+              <goal>compile</goal>
+              <goal>testCompile</goal>
+            </goals>
+          </execution>
+        </executions>
+      </plugin>
+    </plugins>
+  </build>
+
 </project>