Skip to content

Commit 2a280fc

Browse files
Fixes the practice page 400 error (oppia#21830)
* fix practice page * fix frontend tests
1 parent 8c4d0b6 commit 2a280fc

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

core/templates/pages/oppia-root/routing/access-validation-backend-api.service.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ describe('Access validation backend api service', () => {
143143
it('should validate access to practice session page', fakeAsync(() => {
144144
let classroomUrlFragment = 'classroom';
145145
let topicUrlFragment = 'topic';
146-
let selectedSubtopicIds = [1, 2, 3];
146+
let selectedSubtopicIds = '[1,2,3]';
147147

148148
spyOn(urlInterpolationService, 'interpolateUrl').and.returnValue(
149149
'/access_validation_handler/can_access_practice_session_page/' +

core/templates/pages/oppia-root/routing/access-validation-backend-api.service.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ export class AccessValidationBackendApiService {
191191
validateAccessToPracticeSessionPage(
192192
classroomUrlFragment: string,
193193
topicUrlFragment: string,
194-
selectedSubtopicIds: number[]
194+
selectedSubtopicIds: string
195195
): Promise<void> {
196196
let url = this.urlInterpolationService.interpolateUrl(
197197
this.PRACTICE_SESSION_PAGE_ACCESS_VALIDATOR,
@@ -202,7 +202,7 @@ export class AccessValidationBackendApiService {
202202
);
203203
const params = new HttpParams().set(
204204
'selected_subtopic_ids',
205-
JSON.stringify(selectedSubtopicIds)
205+
selectedSubtopicIds
206206
);
207207
return this.http.get<void>(url, {params}).toPromise();
208208
}

core/templates/pages/practice-session-page/practice-session-page-auth.guard.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ export class PracticeSessionAccessGuard implements CanActivate {
4141
route: ActivatedRouteSnapshot,
4242
state: RouterStateSnapshot
4343
): Promise<boolean> {
44-
const selectedSubtopicIds = route.queryParams.selected_subtopic_ids;
44+
const selectedSubtopicIds = route.queryParams.selected_subtopic_ids || '';
4545
const classroomUrlFragment =
4646
route.paramMap.get('classroom_url_fragment') || '';
4747
const topicUrlFragment = route.paramMap.get('topic_url_fragment') || '';

0 commit comments

Comments
 (0)