Fix for new players MMR roles

Author: robotzurg

src/utils/algorithms/calculateMMR.ts

@@ -2,8 +2,9 @@ import {
   getQueueSettings,
   getUsersNeedingRoleUpdates,
   updatePlayerMmrAll,
+  countPlayerGames,
 } from '../queryDB'
-import type { Matches, Queues, teamResults } from 'psqlDB'
+import type { Queues, teamResults } from 'psqlDB'
 import { setUserQueueRole } from 'utils/queueHelpers'
 import { clamp } from 'lodash-es'
 
@@ -130,7 +131,6 @@ export async function calculatePredictedMMR(
 
 export async function calculateNewMMR(
   queueId: number,
-  matchData: Matches,
   queueSettings: Queues,
   teamResults: teamResults,
   winningTeamId: number,
@@ -143,8 +143,13 @@ export async function calculateNewMMR(
         queueSettings.default_elo,
       )
 
-    const playerMMRChanges: Array<{ user_id: string; oldMMR: number; newMMR: number }> = []
+    const playerMMRChanges: Array<{
+      user_id: string
+      oldMMR: number
+      newMMR: number
+    }> = []
     const updatePromises: Promise<void>[] = []
+    let roleUpdateUsers: string[] = []
 
     for (const ts of teamStats) {
       const isWinner = ts.isWinner
@@ -170,23 +175,29 @@ export async function calculateNewMMR(
         updatePromises.push(
           updatePlayerMmrAll(queueId, player.user_id, newMMR, newVolatility),
         )
+
+        const gamesPlayed = await countPlayerGames(queueId, player.user_id)
+        if (gamesPlayed === 1) {
+          roleUpdateUsers.push(player.user_id)
+        }
       }
 
       ts.team.score = isWinner ? 1 : 0
     }
 
     await Promise.all(updatePromises)
 
-    const usersNeedingRoleUpdate = await getUsersNeedingRoleUpdates(
+    // Get users who need role updates due to MMR threshold changes
+    let usersNeedingRoleUpdate = await getUsersNeedingRoleUpdates(
       queueId,
       playerMMRChanges,
     )
 
-    if (usersNeedingRoleUpdate.length > 0) {
+    roleUpdateUsers = roleUpdateUsers.concat(usersNeedingRoleUpdate).flat()
+
+    if (roleUpdateUsers.length > 0) {
       await Promise.all(
-        usersNeedingRoleUpdate.map((userId) =>
-          setUserQueueRole(queueId, userId),
-        ),
+        roleUpdateUsers.map((userId) => setUserQueueRole(queueId, userId)),
       )
     }
 

src/utils/matchHelpers.ts

@@ -760,7 +760,6 @@ export async function endMatch(
 
   teamResults = await calculateNewMMR(
     queueId,
-    matchData,
     queueSettings,
     teamResultsData,
     winningTeamId,

src/utils/queryDB.ts

@@ -13,7 +13,6 @@ import {
 } from 'psqlDB'
 import { client, getGuild } from '../client'
 import { QueryResult } from 'pg'
-import { setUserQueueRole } from './queueHelpers'
 import { endMatch } from './matchHelpers'
 
 // Get the helper role
@@ -281,6 +280,23 @@ export async function getAllQueueRoles(
   return res.rows
 }
 
+// Count completed games for a user in a queue
+export async function countPlayerGames(
+  queueId: number,
+  userId: string,
+): Promise<number> {
+  const res = await pool.query(
+    `
+    SELECT COUNT(CASE WHEN m.winning_team IS NOT NULL THEN 1 END)::integer as games_played
+    FROM match_users mu
+    JOIN matches m ON m.id = mu.match_id
+    WHERE mu.user_id = $1 AND m.queue_id = $2
+    `,
+    [userId, queueId],
+  )
+  return res.rows[0]?.games_played ?? 0
+}
+
 // get a users highest queue role
 export async function getUserQueueRole(
   queueId: number,