🔧 update type hints for query parameters and update ruff lint rules

Author: BalconyJH

nonebot_plugin_paper/__init__.py

@@ -7,7 +7,7 @@
 require("nonebot_plugin_apscheduler")
 from nonebot.plugin import PluginMetadata, inherit_supported_adapters
 
-from .command import paper_cmd  # noqa
+from .command import paper_cmd  # noqa: F401
 from .config import Config
 from .utils import connection_verification
 

nonebot_plugin_paper/command.py

@@ -1,3 +1,5 @@
+from typing import Optional
+
 from aioarxiv.client.arxiv_client import ArxivClient, SortCriterion, SortOrder
 from arclet.alconna import Alconna, Args, Subcommand
 from nonebot.log import logger
@@ -47,9 +49,9 @@ async def handle_search(
     uninfo: Uninfo,
     unimsg: UniMsg,
     number: Query[int] = AlconnaQuery("number", 1),
-    sort: Query[SortCriterion | None] = AlconnaQuery("sort", None),
-    order: Query[SortOrder | None] = AlconnaQuery("order", None),
-    start: Query[int | None] = AlconnaQuery("start", None),
+    sort: Query[Optional[SortCriterion]] = AlconnaQuery("sort", None),
+    order: Query[Optional[SortOrder]] = AlconnaQuery("order", None),
+    start: Query[Optional[int]] = AlconnaQuery("start", None),
 ):
     logger.debug(f"Searching for {keyword} by {uninfo.user.id}")
     async with ArxivClient() as client:
@@ -68,10 +70,10 @@ async def handle_search(
 
 
 @paper_cmd.assign("id")
-async def handle_id(id: str, state: T_State, uninfo: Uninfo, unimsg: UniMsg):
-    logger.debug(f"Searching for {id} by {uninfo.user.id}")
+async def handle_id(paper_id: str, state: T_State, uninfo: Uninfo, unimsg: UniMsg):
+    logger.debug(f"Searching for {paper_id} by {uninfo.user.id}")
     img = await capture_element(
-        f"https://arxiv.org/abs/{id}",
+        f"https://arxiv.org/abs/{paper_id}",
         element="#abs-outer > div.leftcolumn",
     )
     await UniMessage(Image(raw=img)).finish(reply_to=True)

pyproject.toml

@@ -75,32 +75,95 @@ line-ending = "lf"
 
 [tool.ruff.lint]
 select = [
-    "F", # Pyflakes
-    "W", # pycodestyle warnings
+    "F", # pyflakes
     "E", # pycodestyle errors
+    "W", # pycodestyle warnings
     "I", # isort
+    "N", # PEP8-naming
     "UP", # pyupgrade
+    "YTT", # flake8-2020
     "ASYNC", # flake8-async
+    # "S",     # flake8-bandit
+    "BLE", # flake8-blind-except
+    # "FBT",   # flake8-boolean-trap
     "B", # flake8-bugbear
+    "A", # flake8-builtins
+    "COM", # flake8-commas
     "C4", # flake8-comprehensions
     "DTZ", # flake8-datetimez
     "T10", # flake8-debugger
+    # "FA",    # flake8-future-annotations
+    "ISC", # flake8-implicit-str-concat
+    "ICN", # flake8-import-conventions
+    "PIE", # flake8-pie
     "T20", # flake8-print
     "PYI", # flake8-pyi
-    "PT", # flake8-pytest-style
     "Q", # flake8-quotes
+    "RSE", # flake8-raise
+    "RET", # flake8-return
+    "SLOT", # flake8-slots
     "SIM", # flake8-simplify
     "TID", # flake8-tidy-imports
-    "PLE", # Pylint errors
-    "NPY", # NumPy-specific rules
+    # "TC",   # flake8-type-checking
+    # "ARG",   # flake8-unused-arguments
+    "PTH", # flake8-use-pathlib
+    # "ERA",   # eradicate
+    "PD", # pandas-vet
+    "PGH", # pygrep-hooks
+    "PL", # pylint
+    "TRY", # tryceratops
+    "FLY", # flynt
+    "FAST", # FastAPI
+    "PERF", # Perflint
+    "FURB", # refurb
     "RUF", # Ruff-specific rules
 ]
 ignore = [
-    "E402", # module-import-not-at-top-of-file
-    "RUF001", # ambiguous-unicode-character-string
-    "RUF002", # ambiguous-unicode-character-docstring
-    "RUF003", # ambiguous-unicode-character-comment
+    "C901",
+    "T201",
+    "E731",
+    "PT023",
+    "B010", #  Do not call `setattr` with a constant attribute value.
+    "SIM105", # Use `contextlib.suppress`
+    "B008", # Do not perform function call in argument defaults
+    "RUF100", # Unused `noqa` directive
+    "TC003", # Move xxx into a type-checking block
+    "E402", # module level import not at top of file
+    "E501", # 过长的行由 ruff format 处理, 剩余的都是字符串
+    "UP035", # pyupgrade, 但 typing.Callable 的导入会报错
+    "TRY003",
+    "TRY301", # 为啥非要把 raise 丢进另外一个 inner fn 里
+    "BLE001", # except Exception as e
+    "PGH003", # 要求 `# type: ignore` 提供理由，但 pyright 和 mypy 等都不是统一标准。
+    "PLC0414", # 用 import-as 表示 re-export
+    "N818", # 要求所有自定义错误以 Error 作后缀，但我们不这么做
+    "RET502", # return = return None
+    "RET503", # 就要 implicit return none
+    "PLC0105", # 我们已经用 R 表示协变，Q 表示逆变了
+    "PLR0913", # 参数就那么多的，你用 builder 什么的不是更逆天？
+    "SIM108", # 迫真 simplicy
+    "RUF001", # String contains ambiguous `，` (FULLWIDTH COMMA). Did you mean `,` (COMMA)?
+    "RUF002", # Docstring contains ambiguous `，` (FULLWIDTH COMMA). Did you mean `,` (COMMA)?
+    "RUF009", # 我不想要额外的全局变量。
+    "UP038", # instance(..., X | Y) 还是太超前了
+    "RUF003", # 中文注释里用全角符号怎么你了
+    "SLOT000", # 动态类型需求，主要是 json5 backend
+    "PLR0911", "PLR0912", "PLR0915", # 复杂度高点怎么你了
+    "PYI041", # int 和 float 在运行时的类型没有交集（互不成立 issubclass）
+    "PLW2901", # shallow 怎么你了
+    "S101", # assert 怎么你了，非要 RuntimeError 吗
+    "PLR2004", # magic number 怎么你了
+    "TRY004", # 我要抛啥错误我清楚
+    "COM812", # 强制尾随逗号
+    "TID252", # 相对导入
+    "ISC001", # format warning
+    "N801", # Class name should use CapWords convention
+    "N802", # Function name should be lowercase
+    "N804", # First argument of a class method should be named `cls`
+    "N805", # First argument of a method should be named `self`
+    "N806", # Variable in function should be lowercase
 ]
+flake8-quotes = { inline-quotes = "double", multiline-quotes = "double" }
 
 [tool.ruff.lint.isort]
 force-sort-within-sections = true