Added Extra Asserts To Verify ID lengths

Created checks to monitor ID lengths as a courtesy

Author: abaldwin-Bandwidth

src/test/java/com/bandwidth/MessagingApiTests.java

@@ -49,6 +49,9 @@ public void testCreateMessage() throws Exception {
         ApiResponse<BandwidthMessage> apiResponse = controller.createMessage(ACCOUNT_ID, body);
         assertEquals("Response Code is not 202", 202, apiResponse.getStatusCode());
         BandwidthMessage response = apiResponse.getResult();
+        assertNotNull("Message ID is null", response.getId());
+        assertFalse("Message ID is empty", response.getId().isEmpty());
+        assertEquals("Message ID is not 29 characters", 29, response.getId().length());
         assertEquals("Application ID not equal", MESSAGING_APPLICATION_ID, response.getApplicationId());
         assertEquals("To phone number not equal", USER_NUMBER, response.getTo().get(0));
         assertEquals("From phone number not equal", BW_NUMBER, response.getFrom());

src/test/java/com/bandwidth/MfaApiTests.java

@@ -44,6 +44,7 @@ public void testMfaMessaging() throws Exception {
         TwoFactorMessagingResponse response = apiResponse.getResult();
         assertNotNull("MessageID is null", response.getMessageId());
         assertFalse("MessageID is empty", response.getMessageId().isEmpty());
+        assertEquals("MessageID is not 29 characters", 29, response.getMessageId().length());
     }
 
     @Test
@@ -63,6 +64,7 @@ public void testMfaVoice() throws Exception {
         TwoFactorVoiceResponse response = apiResponse.getResult();
         assertNotNull("CallID is null", response.getCallId());
         assertFalse("CallID is empty", response.getCallId().isEmpty());
+        assertEquals("CallID is not 47 characters", 47, response.getCallId().length());
     }
 
     @Test

src/test/java/com/bandwidth/TnLookupApiTests.java

@@ -39,6 +39,7 @@ public void testPhoneNumberLookup() throws Exception {
         OrderResponse orderResponse = orderApiResponse.getResult();
         assertNotNull("RequestID is null", orderResponse.getRequestId());
         assertFalse("RequestID is empty", orderResponse.getRequestId().isEmpty());
+        assertEquals("Request ID is not 36 characters", 36, orderResponse.getRequestId().length());
         assertTrue(
                 "Status is not a valid value",
                 orderResponse.getStatus().equals("COMPLETE") ||
@@ -52,6 +53,7 @@ public void testPhoneNumberLookup() throws Exception {
         OrderStatus statusResponse = statusApiResponse.getResult();
         assertNotNull("RequestID is null", statusResponse.getRequestId());
         assertFalse("RequestId is empty", statusResponse.getRequestId().isEmpty());
+        assertEquals("Request ID is not 36 characters", 36, statusResponse.getRequestId().length());
         assertTrue(
                 "Status is not a valid value",
                 statusResponse.getStatus().equals("COMPLETE") ||
@@ -60,4 +62,4 @@ public void testPhoneNumberLookup() throws Exception {
                         statusResponse.getStatus().equals("IN_PROGRESS")
                 );
     }
-}
+}

src/test/java/com/bandwidth/VoiceApiTests.java

@@ -41,6 +41,9 @@ public void testCreateCallAndGetCallState() throws Exception {
         assertEquals("Response Code is not 201", 201, createCallApiResponse.getStatusCode());
 
         CreateCallResponse createCallResponse = createCallApiResponse.getResult();
+        assertNotNull("Call ID is null", createCallResponse.getCallId());
+        assertFalse("Call ID is empty", createCallResponse.getCallId().isEmpty());
+        assertEquals("Call ID is not 47 characters", 47, createCallResponse.getCallId().length());
         assertEquals("Application ID for create call not equal", VOICE_APPLICATION_ID, createCallResponse.getApplicationId());
         assertEquals("To phone number for create call not equal", USER_NUMBER, createCallResponse.getTo());
         assertEquals("From phone number for create call not equal", BW_NUMBER, createCallResponse.getFrom());
@@ -84,6 +87,9 @@ public void testCreateCallWithAmdAndGetCallState() throws Exception {
         assertEquals("Response Code is not 201", 201, createCallApiResponse.getStatusCode());
 
         CreateCallResponse createCallResponse = createCallApiResponse.getResult();
+        assertNotNull("Call ID is null", createCallResponse.getCallId());
+        assertFalse("Call ID is empty", createCallResponse.getCallId().isEmpty());
+        assertEquals("Call ID is not 36 characters", 36, createCallResponse.getCallId().length());
         assertEquals("Application ID for create call not equal", VOICE_APPLICATION_ID, createCallResponse.getApplicationId());
         assertEquals("To phone number for create call not equal", USER_NUMBER, createCallResponse.getTo());
         assertEquals("From phone number for create call not equal", BW_NUMBER, createCallResponse.getFrom());

src/test/java/com/bandwidth/WebRtcApiTests.java

@@ -29,7 +29,7 @@ public void initTest(){
         controller = client.getWebRtcClient().getAPIController();
     }
 
-    // Break this into multiple tests when we have a proper test environment and there aren't dependency issues
+    // Break this into multiple tests when our test environment is more robust and there aren't dependency issues
     @Test
     public void testWebRtcParticipantSessionManagement() throws Exception {
         // Create a participant
@@ -48,6 +48,7 @@ public void testWebRtcParticipantSessionManagement() throws Exception {
         assertNotNull("Participant is null", participantCreationResponse.getParticipant());
         assertNotNull("Participant ID is null", participantCreationResponse.getParticipant().getId());
         assertFalse("Participant ID is empty", participantCreationResponse.getParticipant().getId().isEmpty());
+        assertEquals("Participant ID is not 36 characters", 36, participantCreationResponse.getParticipant().getId().length());
         assertEquals(
                 "Publish Permissions do not match",
                 participantCreationRequest.getPublishPermissions(),
@@ -75,6 +76,7 @@ public void testWebRtcParticipantSessionManagement() throws Exception {
         assertNotNull("Participant is null", participantFetchResponse);
         assertNotNull("Participant ID is null", participantFetchResponse.getId());
         assertFalse("Participant ID is empty", participantFetchResponse.getId().isEmpty());
+        assertEquals("Participant ID is not 36 characters", participantFetchResponse.getId().length());
         assertEquals(
                 "Publish Permissions do not match",
                 participantCreationRequest.getPublishPermissions(),
@@ -102,6 +104,7 @@ public void testWebRtcParticipantSessionManagement() throws Exception {
         Session sessionCreationResponse = sessionCreationApiResponse.getResult();
         assertNotNull("Session ID is null", sessionCreationResponse.getId());
         assertFalse("Session ID is empty", sessionCreationResponse.getId().isEmpty());
+        assertEquals("Session ID is not 36 characters", sessionCreationResponse.getId().length());
         assertEquals("Session Tags do not match", sessionCreationRequest.getTag(), sessionCreationResponse.getTag());
 
         // Get a session