properly return undefined instaed of [undefined] with empty results

BryanZWu · BryanZWu · commit 1a67f9bc7d3d · 2020-06-22T17:52:19.000-04:00
diff --git a/lib/application.js b/lib/application.js
@@ -105,7 +105,7 @@ Application.prototype.getSipPeers = function(query, callback){
       return callback(err);
     }
     let sipPeers = res.associatedSipPeers.associatedSipPeer;
-    if(!Array.isArray(sipPeers)){
+    if(!Array.isArray(sipPeers) && sipPeers){
       sipPeers = [sipPeers];
     }
     callback(null,sipPeers);
diff --git a/lib/sipPeer.js b/lib/sipPeer.js
@@ -86,7 +86,7 @@ SipPeer.prototype.listApplications = function(callback) {
     }
     else {
       var apps = results.applicationSettings;
-      if (!Array.isArray(apps.httpMessagingV2AppId)) {
+      if (!Array.isArray(apps.httpMessagingV2AppId) && apps.httpMessagingV2AppId) {
         apps.httpMessagingV2AppId = [apps.httpMessagingV2AppId]
       }
       callback(null, apps)

Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,7 @@ Application.prototype.getSipPeers = function(query, callback){`
`105`	`105`	`return callback(err);`
`106`	`106`	`}`
`107`	`107`	`let sipPeers = res.associatedSipPeers.associatedSipPeer;`
`108`		`- if(!Array.isArray(sipPeers)){`
	`108`	`+ if(!Array.isArray(sipPeers) && sipPeers){`
`109`	`109`	`sipPeers = [sipPeers];`
`110`	`110`	`}`
`111`	`111`	`callback(null,sipPeers);`
Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ SipPeer.prototype.listApplications = function(callback) {`
`86`	`86`	`}`
`87`	`87`	`else {`
`88`	`88`	`var apps = results.applicationSettings;`
`89`		`- if (!Array.isArray(apps.httpMessagingV2AppId)) {`
	`89`	`+ if (!Array.isArray(apps.httpMessagingV2AppId) && apps.httpMessagingV2AppId) {`
`90`	`90`	`apps.httpMessagingV2AppId = [apps.httpMessagingV2AppId]`
`91`	`91`	`}`
`92`	`92`	`callback(null, apps)`