change aplpication to singular in sippeer and specify appId in readme

Author: BryanZWu

README.md

@@ -708,14 +708,15 @@ numbers.SipPeer.get(function(err,sipPeer){
 
 ```Javascript
 numbers.SipPeer.get(function(err,sipPeer){
-  // List applications associated with this peer
-  sipPeer.listApplications(callback);
+  // List application associated with this peer
+  sipPeer.listApplication(callback);
 
   // Associate an application with this peer
-  sipPeer.editApplications({httpMessagingV2AppId: [appId]}, callback);
+  var appId = "my-application-id";
+  sipPeer.editApplication({httpMessagingV2AppId: appId}, callback);
 
   // Dissociate all applications with this peer
-  sipPeer.removeApplications(callback);
+  sipPeer.removeApplication(callback);
 ```
 
 

lib/sipPeer.js

@@ -78,7 +78,7 @@ SipPeer.prototype.moveTns = function(numbers, callback){
   this.client.makeRequest("post", url, {sipPeerTelephoneNumbers: {fullNumber: numbers}}, callback);
 };
 
-SipPeer.prototype.listApplications = function(callback) {
+SipPeer.prototype.listApplication = function(callback) {
   var url = this.client.concatAccountPath(SITE_PATH + "/" + this.siteId + "/" + SIP_PEER_PATH + "/" + this.id + "/" + "products" + "/" + "messaging" + "/" + "applicationSettings");
   this.client.makeRequest("get", url, function (err, results) {
     if (err) {
@@ -94,22 +94,19 @@ SipPeer.prototype.listApplications = function(callback) {
   })
 }
 
-SipPeer.prototype.editApplications = function(appData, callback) {
+SipPeer.prototype.editApplication = function(appData, callback) {
   var url = this.client.concatAccountPath(SITE_PATH + "/" + this.siteId + "/" + SIP_PEER_PATH + "/" + this.id + "/" + "products" + "/" + "messaging" + "/" + "applicationSettings");
   const data = {applicationsSettings: appData}
   this.client.makeRequest("put", url, data, function (err, results) {
     if (err) {callback(error);}
     else {
       var apps = results.applicationSettings;
-      if (!Array.isArray(apps.httpMessagingV2AppId)) {
-        apps.httpMessagingV2AppId = [apps.httpMessagingV2AppId]
-      }
       callback(null, apps)
     }
   });
 }
 
-SipPeer.prototype.removeApplications = function(callback) {
+SipPeer.prototype.removeApplication = function(callback) {
   var url = this.client.concatAccountPath(SITE_PATH + "/" + this.siteId + "/" + SIP_PEER_PATH + "/" + this.id + "/" + "products" + "/" + "messaging" + "/" + "applicationSettings");
   const data = {applicationsSettings: 'REMOVE'}
   this.client.makeRequest("put", url, data, callback);

test/sipPeer.js

@@ -193,14 +193,14 @@ describe("SipPeer", function(){
       peer.moveTns(data, done);
     });
   });
-  describe("#listApplications", function() {
-    it("should list applications", function(done) {
+  describe("#listApplication", function() {
+    it("should list application", function(done) {
       var span = helper.nock().get("/accounts/FakeAccountId/sites/1/sippeers/10/products/messaging/applicationSettings").reply(200, helper.xml.peerApplications, {"Content-Type": "application/xml"});
       var peer = new SipPeer();
       peer.id = 10;
       peer.siteId = 1;
       peer.client = helper.createClient();
-      peer.listApplications(function(err, results) {
+      peer.listApplication(function(err, results) {
         if (err) {
           done(err);
         } else {
@@ -210,34 +210,34 @@ describe("SipPeer", function(){
       });
     });
   });
-  describe("#editApplications", function() {
-    it("should edit applications", function(done) {
+  describe("#editApplication", function() {
+    it("should edit the application", function(done) {
       var appData = {httpMessagingV2AppId: 100}
       var span = helper.nock().put("/accounts/FakeAccountId/sites/1/sippeers/10/products/messaging/applicationSettings", helper.buildXml({applicationsSettings: appData})).reply(200, helper.xml.peerApplications, {"Content-Type": "application/xml"});
       var peer = new SipPeer();
       peer.id = 10;
       peer.siteId = 1;
       peer.client = helper.createClient();
-      var appData = [{httpMessagingV2AppId: 100}]
-      peer.editApplications(appData, function(err, results) {
+      var appData = {httpMessagingV2AppId: 100}
+      peer.editApplication(appData, function(err, results) {
         if (err) {
           done(err);
         } else {
-          results.httpMessagingV2AppId[0].should.equal(100)
+          results.httpMessagingV2AppId.should.equal(100)
           done();
         }
       });
     });
   });
-  describe("#removeApplications", function() {
-    it("should remove applications", function(done) {
+  describe("#removeApplication", function() {
+    it("should remove application", function(done) {
       var appData = 'REMOVE';
       var span = helper.nock().put("/accounts/FakeAccountId/sites/1/sippeers/10/products/messaging/applicationSettings", helper.buildXml({applicationsSettings: appData})).reply(200, helper.xml.peerApplications, {"Content-Type": "application/xml"});
       var peer = new SipPeer();
       peer.id = 10;
       peer.siteId = 1;
       peer.client = helper.createClient();
-      peer.removeApplications(done);
+      peer.removeApplication(done);
     });
   });