DX-2428 Closes #46 401 with CoveredRateCenter (#47)

* Closes #46

* update coveredratecenter model and add test

* spacing

* remove console.logs and update test

* config

* base url

* add in query params

* send it to pipedream

* try to disable nock

* try to use lib

* require nock

* try to reset url

* log request

* try to override username and password

* is it getting environment vars??

* remove test env

* change test script

* change env

* actually load in secrets

* set the right this time

* apsword

* enable net connect

* change test cmd

* remove unneccesary line

Author: ckoegel

.github/workflows/validate.yml

@@ -20,3 +20,7 @@ jobs:
       run: npm run build --if-present
     - name: NPM Test
       run: npm run test --if-present
+      env: 
+        BW_ACCOUNT_ID: ${{ secrets.BW_ACCOUNT_ID }}
+        BW_USERNAME: ${{ secrets.BW_USERNAME }}
+        BW_PASSWORD: ${{ secrets.BW_PASSWORD }}

lib/coveredRateCenter.js

@@ -3,11 +3,39 @@ var COVERED_RATE_CENTER_PATH = "coveredRateCenters";
 
 module.exports = {
   list: function(client, query, callback){
-    if(arguments.length === 2){
-      callback = query;
-      query = client;
-      client = new Client();
+    if (arguments.length == 2) {
+      let args = Array.from(arguments);
+      args.forEach(arg => {
+        if (arg instanceof Client) {
+          client = arg;
+        } else if (typeof arg == 'object') {
+          if (!(client instanceof Client)) {
+            client = null;
+          }
+          query = arg;
+        } else if (typeof arg == 'function') {
+          if (!(client instanceof Client)) {
+            client = null;
+          }
+          callback = arg;
+        }
+      });
+      if (client == null) {
+        client = new Client();
+      }
+      if (query ==  null) {
+        query = {
+          "page": 1,
+          "size": 500
+        }
+      }
+      if (callback == null) {
+        console.log("Please provide a callback function.")
+        process.exit(1);
+      }
     }
+    query.page = query.page || 1;
+    query.size = query.size || 500;
     client.makeRequest("get", COVERED_RATE_CENTER_PATH, query, function(err, res){
       if(err){
         return callback(err);

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@bandwidth/numbers",
-  "version": "1.7.1",
+  "version": "1.7.2",
   "description": "NodeJs Client library for Bandwidth Numbers API",
   "main": "index.js",
   "scripts": {

package.json

@@ -0,0 +1,29 @@
+var lib = require("../");
+var nock = require("nock");
+
+describe("coveredRateCenter", function(){
+    before(function(){
+        lib.Client.globalOptions.accountId = process.env.BW_ACCOUNT_ID;
+        lib.Client.globalOptions.userName = process.env.BW_USERNAME;
+        lib.Client.globalOptions.password = process.env.BW_PASSWORD;
+    });
+    after(function(){
+        lib.Client.globalOptions.apiEndPoint = "https://dashboard.bandwidth.com/api";
+        nock.cleanAll();
+        nock.enableNetConnect();
+    });
+    describe("#list", function(){
+      it("should return list of coveredRateCenters", function(done){
+        lib.CoveredRateCenter.list({zip: 27606, page: 1, size: 500}, function(err, list){
+          if(err){
+            return done(err);
+          }
+          list.length.should.equal(1);
+          list[0].name.should.equal("RALEIGH");
+          list[0].abbreviation.should.equal("RALEIGH");
+          done();
+        });
+      });
+    });
+});
+