Merge pull request #40 from Hustle/fix-tn-option-create

Make `TnOption.create()` invoke its callback

Author: ajrice6713

lib/tnOption.js

@@ -66,6 +66,7 @@ TnOption.create = function(client, order, callback){
    if(err){
      return callback(err);
    }
+   item = item.tnOptionOrder;
    if (item.tnOptionGroups && item.tnOptionGroups.tnOptionGroup) {
      item.tnOptionGroups = item.tnOptionGroups.tnOptionGroup;
      if (!Array.isArray(item.tnOptionGroups)) {

test/tnOption.js

@@ -117,7 +117,7 @@ describe("TnOption", function(){
           ]
         }
       }
-      helper.nock().post("/accounts/FakeAccountId/tnoptions", helper.buildXml({tnOptionOrder: receivedData})).reply(201, helper.xml.tnOption, {"Location": "/accounts/FakeAccountId/tnoptions/1"});
+      helper.nock().post("/accounts/FakeAccountId/tnoptions", helper.buildXml({tnOptionOrder: receivedData})).reply(201, helper.xml.tnOptionOrderResponse, {"Location": "/accounts/FakeAccountId/tnoptions/1"});
       TnOption.create(helper.createClient(), userInput,  function(err, item){
         if(err){
           return done(err);
@@ -152,7 +152,7 @@ describe("TnOption", function(){
           ]
         }
       }
-      helper.nock().post("/accounts/FakeAccountId/tnoptions", helper.buildXml({tnOptionOrder: receivedData})).reply(201, helper.xml.tnOption, {"Location": "/accounts/FakeAccountId/tnoptions/1"});
+      helper.nock().post("/accounts/FakeAccountId/tnoptions", helper.buildXml({tnOptionOrder: receivedData})).reply(201, helper.xml.tnOptionOrderResponse, {"Location": "/accounts/FakeAccountId/tnoptions/1"});
       TnOption.create(helper.createClient(), userInput,  function(err, item){
         if(err){
           return done(err);
@@ -189,7 +189,7 @@ describe("TnOption", function(){
           ]
         }
       }
-      helper.nock().post("/accounts/FakeAccountId/tnoptions", helper.buildXml({tnOptionOrder: receivedData})).reply(201, helper.xml.tnOption, {"Location": "/accounts/FakeAccountId/tnoptions/1"});
+      helper.nock().post("/accounts/FakeAccountId/tnoptions", helper.buildXml({tnOptionOrder: receivedData})).reply(201, helper.xml.tnOptionOrderResponse, {"Location": "/accounts/FakeAccountId/tnoptions/1"});
       TnOption.create(helper.createClient(), userInput,  function(err, item){
         if(err){
           return done(err);

test/xml.json

@@ -3,6 +3,7 @@
   "peerSmsSettings": "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\"?><SipPeerSmsFeatureResponse><SipPeerSmsFeature><SipPeerSmsFeatureSettings><TollFree>true</TollFree><ShortCode>true</ShortCode><A2pLongCode>DefaultOff</A2pLongCode><A2pMessageClass>SomeMessageClass</A2pMessageClass><A2pCampaignId>SomeCampaignId</A2pCampaignId><Protocol>SMPP</Protocol><Zone1>true</Zone1><Zone2>true</Zone2><Zone3>true</Zone3><Zone4>true</Zone4><Zone5>true</Zone5></SipPeerSmsFeatureSettings><SmppHosts><SmppHost><HostName>54.10.88.146</HostName><HostId>18</HostId><Priority>0</Priority><ConnectionType>RECEIVER_ONLY</ConnectionType></SmppHost></SmppHosts></SipPeerSmsFeature></SipPeerSmsFeatureResponse>",
   "tnOptions": "<TnOptionOrders><TotalCount>2</TotalCount><TnOptionOrderSummary><accountId>accountId</accountId><CountOfTNs>1</CountOfTNs><userId>userId</userId><lastModifiedDate>lastModifiedDate</lastModifiedDate><OrderDate>orderDate</OrderDate><OrderType>orderType</OrderType><OrderStatus>FAILED</OrderStatus><OrderId>orderId</OrderId></TnOptionOrderSummary><TnOptionOrderSummary><accountId>14</accountId><CountOfTNs>3</CountOfTNs><userId>userId</userId><lastModifiedDate>lastModifiedDate</lastModifiedDate><OrderDate>orderDate</OrderDate><OrderType>tn_option</OrderType><OrderStatus>COMPLETE</OrderStatus><OrderId>orderId2</OrderId></TnOptionOrderSummary></TnOptionOrders>",
   "tnOption": "<TnOptionOrder><OrderCreateDate>createdDate</OrderCreateDate><AccountId>14</AccountId><CreatedByUser>user</CreatedByUser><OrderId>orderId</OrderId><LastModifiedDate>dateHere</LastModifiedDate><ProcessingStatus>FAILED</ProcessingStatus><TnOptionGroups><TnOptionGroup><NumberFormat>10digit</NumberFormat><RPIDFormat>10digit</RPIDFormat><RewriteUser>testUser1</RewriteUser><CallForward>6042661720</CallForward><CallingNameDisplay>on</CallingNameDisplay><Protected>true</Protected><Sms>on</Sms><FinalDestinationURI>sip:[email protected]:5060</FinalDestinationURI><TelephoneNumbers><TelephoneNumber>2018551020</TelephoneNumber></TelephoneNumbers></TnOptionGroup><TnOptionGroup><CallingNameDisplay>off</CallingNameDisplay><Protected>false</Protected><Sms>off</Sms><TelephoneNumbers><TelephoneNumber>2018551025</TelephoneNumber></TelephoneNumbers></TnOptionGroup></TnOptionGroups></TnOptionOrder>",
+  "tnOptionOrderResponse": "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\"?><TnOptionOrderResponse><TnOptionOrder><OrderCreateDate>createdDate</OrderCreateDate><AccountId>14</AccountId><CreatedByUser>user</CreatedByUser><OrderId>orderId</OrderId><LastModifiedDate>dateHere</LastModifiedDate><ProcessingStatus>FAILED</ProcessingStatus><TnOptionGroups><TnOptionGroup><NumberFormat>10digit</NumberFormat><RPIDFormat>10digit</RPIDFormat><RewriteUser>testUser1</RewriteUser><CallForward>6042661720</CallForward><CallingNameDisplay>on</CallingNameDisplay><Protected>true</Protected><Sms>on</Sms><FinalDestinationURI>sip:[email protected]:5060</FinalDestinationURI><TelephoneNumbers><TelephoneNumber>2018551020</TelephoneNumber></TelephoneNumbers></TnOptionGroup><TnOptionGroup><CallingNameDisplay>off</CallingNameDisplay><Protected>false</Protected><Sms>off</Sms><TelephoneNumbers><TelephoneNumber>2018551025</TelephoneNumber></TelephoneNumbers></TnOptionGroup></TnOptionGroups></TnOptionOrder></TnOptionOrderResponse>",
   "geocode": "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\"?><GeocodeRequestResponse><GeocodedAddress><AddressLine1>1 Street Name</AddressLine1><HouseNumber>1</HouseNumber><StreetName>Street</StreetName><StreetSuffix>Name</StreetSuffix><City>City</City><StateCode>State</StateCode><Zip>ZipCode</Zip><PlusFour>1234</PlusFour><Country>US</Country></GeocodedAddress></GeocodeRequestResponse>",
   "peerApplications": "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\"?><ApplicationSettingsResponse><ApplicationSettings><HttpMessagingV2AppId>100</HttpMessagingV2AppId></ApplicationSettings></ApplicationSettingsResponse>",
   "application": "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\"?><ApplicationProvisioningResponse><Application><ApplicationId>1</ApplicationId><ServiceType>Messaging-V2</ServiceType><AppName>Test Application</AppName><MsgCallbackUrl>http://a.com</MsgCallbackUrl></Application></ApplicationProvisioningResponse>",