Fixed Subscription List functionality

Author: Dan Tolbert

README.md

@@ -15,10 +15,11 @@ This SDK stable for node versions 7 and above
 | > 7     |               | Supported |
 
 ## Release Notes
-| Version | Notes                                                                |
-|:--------|:---------------------------------------------------------------------|
-| 1.1.0   | Added import tn functionality, added promise based `Async` functions |
-| 1.2.0   | Added CSR lookup functionality                                       |
+| Version | Notes                                                                                                                                     |    |
+|:--------|:------------------------------------------------------------------------------------------------------------------------------------------|:---|
+| 1.1.0   | Added import tn functionality, added promise based `Async` functions                                                                      |    |
+| 1.2.0   | Added CSR lookup functionality                                                                                                            | .  |
+| 1.2.1   | Fixed Subscription List functionality. Example code at: [examples/subscription_list_and_delete](examples/subscription_list_and_delete.js) |    |
 
 
 ## Install

examples/subscription_list_and_delete.js

@@ -0,0 +1,45 @@
+const numbers = require("@bandwidth/numbers");
+
+//Using client directly
+const client = new numbers.Client(process.env.BANDWIDTH_ACCOUNT_ID,
+                                  process.env.BANDWIDTH_API_USER,
+                                  process.env.BANDWIDTH_API_PASSWORD);
+
+
+const findAndDeleteSubscriptionById = async (id) => {
+  try {
+    const subscriptions = await numbers.Subscription.listAsync(client, {});
+    for (const s of subscriptions) {
+      console.log(s.id);
+      // 6be53e36-...-668ee3603d71
+      // b57094d3-...-25085d224b48
+      if (s.id === id) {
+        const deletedS = await s.deleteAsync();
+        console.log(deletedS);
+        // {}
+      }
+    }
+    const moreSubscriptions = await numbers.Subscription.listAsync(client, {});
+    console.log(moreSubscriptions)
+    // [
+    //   Subscription {
+    //     subscriptionId: '6be53e36-...-668ee3603d71',
+    //     orderType: 'portins',
+    //     emailSubscription: { email: '...@bandwidth.com', digestRequested: 'NONE' },
+    //     client: Client {
+    //       prepareRequest: [Function],
+    //       concatAccountPath: [Function],
+    //       prepareUrl: [Function],
+    //       xml2jsParserOptions: [Object]
+    //     },
+    //     id: '6be53e36-...-668ee3603d71'
+    //   }
+    // ]
+  }
+  catch (e) {
+    console.log('Error');
+    console.log(e);
+  }
+}
+
+findAndDeleteSubscriptionById('b57094d3-...-25085d224b48');

lib/subscription.js

@@ -36,12 +36,12 @@ Subscription.list = function(client, query, callback){
     if(err){
       return callback(err);
     }
-    var items = res.subscriptions || [];
+    var items = res.subscriptions.subscription || [];
     if(!Array.isArray(items)){
       items = [items];
     }
     var result = items.map(function(item){
-      var i = item.subscription;
+      var i = item;
       i.client = client;
       i.__proto__ = Subscription.prototype;
       i.id = i.subscriptionId;

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bandwidth/numbers",
-  "version": "1.2.0",
+  "version": "1.2.1",
   "description": "NodeJs Client library for Bandwidth Numbers API",
   "main": "index.js",
   "scripts": {