Skip to content

Commit 4e095f3

Browse files
authored
SWI-7432 Add mode to StartStream Verb (#65)
1 parent e619f60 commit 4e095f3

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

models/bxml/verbs/StartStream.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import { StreamParam } from './StreamParam';
33

44
export interface StartStreamAttributes {
55
name?: string;
6+
mode?: string;
67
tracks?: string;
78
destination?: string;
89
streamEventUrl?: string;

tests/unit/models/bxml/verbs/StartStream.test.ts

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import { StreamParam } from '../../../../../models/bxml/verbs/StreamParam';
55
describe('StartStream', () => {
66
const attributes: StartStreamAttributes = {
77
name: 'initialName',
8+
mode: 'unidirectional',
89
tracks: 'inbound',
910
destination: 'https://initial.com',
1011
streamEventUrl: 'https://initial.com',
@@ -18,7 +19,7 @@ describe('StartStream', () => {
1819

1920
test('should create a StartStream Verb', () => {
2021
const startStream = new StartStream(attributes);
21-
const expected = '<StartStream name="initialName" tracks="inbound" destination="https://initial.com" streamEventUrl="https://initial.com" streamEventMethod="POST" username="initialUsername" password="initialPassword"/>';
22+
const expected = '<StartStream name="initialName" mode="unidirectional" tracks="inbound" destination="https://initial.com" streamEventUrl="https://initial.com" streamEventMethod="POST" username="initialUsername" password="initialPassword"/>';
2223

2324
expect(startStream).toBeInstanceOf(StartStream);
2425
expect(startStream).toBeInstanceOf(Verb);
@@ -27,9 +28,9 @@ describe('StartStream', () => {
2728

2829
test('should create a StartStream Verb with nested StreamParams', () => {
2930
let startStream = new StartStream(attributes, streamParam1);
30-
const expected = '<StartStream name="initialName" tracks="inbound" destination="https://initial.com" streamEventUrl="https://initial.com" streamEventMethod="POST" username="initialUsername" password="initialPassword"><StreamParam name="streamParamName1" value="streamParamValue1"/></StartStream>';
31-
const expectedSingle = '<StartStream name="initialName" tracks="inbound" destination="https://initial.com" streamEventUrl="https://initial.com" streamEventMethod="POST" username="initialUsername" password="initialPassword"><StreamParam name="streamParamName1" value="streamParamValue1"/><StreamParam name="streamParamName2" value="streamParamValue2"/></StartStream>';
32-
const expectedMultiple = '<StartStream name="initialName" tracks="inbound" destination="https://initial.com" streamEventUrl="https://initial.com" streamEventMethod="POST" username="initialUsername" password="initialPassword"><StreamParam name="streamParamName1" value="streamParamValue1"/><StreamParam name="streamParamName2" value="streamParamValue2"/><StreamParam name="streamParamName1" value="streamParamValue1"/><StreamParam name="streamParamName2" value="streamParamValue2"/></StartStream>';
31+
const expected = '<StartStream name="initialName" mode="unidirectional" tracks="inbound" destination="https://initial.com" streamEventUrl="https://initial.com" streamEventMethod="POST" username="initialUsername" password="initialPassword"><StreamParam name="streamParamName1" value="streamParamValue1"/></StartStream>';
32+
const expectedSingle = '<StartStream name="initialName" mode="unidirectional" tracks="inbound" destination="https://initial.com" streamEventUrl="https://initial.com" streamEventMethod="POST" username="initialUsername" password="initialPassword"><StreamParam name="streamParamName1" value="streamParamValue1"/><StreamParam name="streamParamName2" value="streamParamValue2"/></StartStream>';
33+
const expectedMultiple = '<StartStream name="initialName" mode="unidirectional" tracks="inbound" destination="https://initial.com" streamEventUrl="https://initial.com" streamEventMethod="POST" username="initialUsername" password="initialPassword"><StreamParam name="streamParamName1" value="streamParamValue1"/><StreamParam name="streamParamName2" value="streamParamValue2"/><StreamParam name="streamParamName1" value="streamParamValue1"/><StreamParam name="streamParamName2" value="streamParamValue2"/></StartStream>';
3334

3435
expect(startStream).toBeInstanceOf(StartStream);
3536
expect(startStream).toBeInstanceOf(Verb);
@@ -44,7 +45,7 @@ describe('StartStream', () => {
4445

4546
test('should test the addStreamParams method when no verbs are initially nested', () => {
4647
const startStream = new StartStream(attributes);
47-
const expected = '<StartStream name="initialName" tracks="inbound" destination="https://initial.com" streamEventUrl="https://initial.com" streamEventMethod="POST" username="initialUsername" password="initialPassword"><StreamParam name="streamParamName1" value="streamParamValue1"/></StartStream>';
48+
const expected = '<StartStream name="initialName" mode="unidirectional" tracks="inbound" destination="https://initial.com" streamEventUrl="https://initial.com" streamEventMethod="POST" username="initialUsername" password="initialPassword"><StreamParam name="streamParamName1" value="streamParamValue1"/></StartStream>';
4849

4950
startStream.addStreamParams(streamParam1);
5051
expect(startStream.toBxml()).toBe(expected);

0 commit comments

Comments
 (0)