Skip to content

Commit 02db8cb

Browse files
Apply suggestions from code review
Co-authored-by: AJ Rice <[email protected]>
1 parent e8dd819 commit 02db8cb

File tree

6 files changed

+12
-8
lines changed

6 files changed

+12
-8
lines changed

bandwidth/model/bxml/verbs/forward.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
class Forward(TerminalVerb):
1212

1313
def __init__(
14-
self, to: str=None, from_: str=None,
14+
self, to: str=None, _from: str=None,
1515
call_timeout: str=None, diversion_treatment: str=None,
1616
diversion_reason: str=None, uui: str=None
1717
):
@@ -53,12 +53,14 @@ def __init__(
5353
self.diversion_reason = diversion_reason
5454
self.uui = uui
5555

56-
super().__init__(tag="Forward", content=None)
56+
super().__init__(tag="Forward")
57+
"""
58+
Don't need to define this since default for the parent class is `None`
5759
@property
5860
def _attributes(self):
5961
return {
6062
"to": self.to,
61-
"from_": self.from_,
63+
"_from": self._from,
6264
"callTimeout": self.call_timeout,
6365
"diversionTreatment": self.diversion_treatment,
6466
"diversionReason": self.diversion_reason,

bandwidth/model/bxml/verbs/gather.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@ def __init__(
6565
self.audio_verbs = audio_verbs
6666
super().__init__(
6767
tag="Gather",
68-
content=None,
6968
nested_verbs=self.audio_verbs)
7069

7170
@property

bandwidth/model/bxml/verbs/hangup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,4 @@ def __init__(self):
1616
Args:
1717
None
1818
"""
19-
super().__init__(tag="Hangup", content=None)
19+
super().__init__(tag="Hangup")

bandwidth/model/bxml/verbs/pause.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
"""
22
pause.py
3+
34
Bandwidth's Pause BXML verb
5+
46
@copyright Bandwidth INC
57
"""
68
from ..terminal_verb import TerminalVerb
@@ -12,7 +14,8 @@ def __init__(self, duration:str=None):
1214
"""
1315
self.duration = duration
1416

15-
super().__init__(tag="Pause", content=None)
17+
super().__init__(tag="Pause")
18+
1619
@property
1720
def _attributes(self):
1821
return {

bandwidth/model/bxml/verbs/start_recording.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ def __init__(
4343
self.tag = tag
4444
self.file_format = file_format
4545
self.multi_channel = multi_channel
46-
super().__init__(tag="StartRecording", content=None)
46+
super().__init__(tag="StartRecording")
4747

4848
@property
4949
def _attributes(self):

bandwidth/model/bxml/verbs/stop_recording.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,4 @@ def __init__(self):
1616
Args: There are no args or text content for StopRecording
1717
"""
1818

19-
super().__init__(tag="StopRecording", content=None)
19+
super().__init__(tag="StopRecording")

0 commit comments

Comments
 (0)