DX-2232 Add Matrix Testing (#33)

* DX-2232 Add Matrix Testing

* Update validate.yaml

* Only support python 3.6 and above

* Update OS tests

* Update requirements.txt

* install from test-requirements

* Update validate.yaml

* Force urllib version

* Update requirements.txt

* Add print to check verify "To" TN

* Add Manual Trigger

* use random seed for MFA verify test

* Add back in windows OS

* Remove ubuntu-18.04

* add back ubuntu to check bxml

* force python3

* force pip3

* Set up python

* Update validate.yaml

* Update validate.yaml

* Update validate.yaml

* Adjust test for python 3.6

* Update test_api.py

* Remove Validate Action

* Rename Validate to Test

* Update name

* nvm

* Update .github/workflows/test.yaml

Co-authored-by: Mike Hamer <[email protected]>

Co-authored-by: Mike Hamer <[email protected]>

Author: ajrice6713

.github/actions/validate/Dockerfile

@@ -1,19 +1,32 @@
-name: Validate SDK
+name: Test SDK
 
 on:
   schedule:
     - cron: "0 4 * * *"
   pull_request:
+  workflow_dispatch:
 
 jobs:
   deploy:
-    name: Validate
-    runs-on: ubuntu-latest
+    name: Test
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        os: [windows-2016, windows-2019, ubuntu-18.04, ubuntu-20.04]
+        python-version: [3.6, 3.7, 3.8, 3.9]
     steps:
     - name: Checkout
       uses: actions/checkout@v2
-    - name: Validate
-      uses: ./.github/actions/validate
+
+    - name: Set up Python
+      uses: actions/setup-python@v2
+      with:
+        python-version: ${{ matrix.python-version }}
+
+    - name: Install Packages
+      run: pip install -r requirements.txt
+
+    - name: Test
       env:
         BW_ACCOUNT_ID: ${{ secrets.BW_ACCOUNT_ID }}
         BW_USERNAME: ${{ secrets.BW_USERNAME }}
@@ -23,7 +36,10 @@ jobs:
         BW_NUMBER: ${{ secrets.BW_NUMBER }}
         USER_NUMBER: ${{ secrets.USER_NUMBER }}
         BASE_CALLBACK_URL: ${{ secrets.BASE_CALLBACK_URL }}
-    - uses: Bandwidth/[email protected]
+      run: python -m pytest --pyargs bandwidth
+
+    - name: Notify Slack of Failures
+      uses: Bandwidth/[email protected]
       if: failure() && !github.event.pull_request.draft
       with:
         job-status: ${{ job.status }}

.github/actions/validate/action.yml

@@ -8,7 +8,7 @@
 import os
 import time
 import pytest
-from datetime import datetime
+import dateutil.parser
 from random import seed
 from random import randint
 from bandwidth.bandwidth_client import BandwidthClient
@@ -30,7 +30,7 @@
 log_cli = True
 
 # seed the random number generator
-seed(1)
+seed(randint(10, 500))
 
 try:
     BW_USERNAME = os.environ["BW_USERNAME"]
@@ -124,7 +124,7 @@ def test_successful_create_message(self, messaging_client):
         assert create_response_body.application_id == BW_MESSAGING_APPLICATION_ID
 
         # asserts the date string is valid ISO
-        assert datetime.fromisoformat(create_response_body.time.replace('Z', '+00:00'))
+        assert dateutil.parser.isoparse(str(create_response_body.time))
         assert type(create_response_body.segment_count) is int
         assert create_response_body.to == [USER_NUMBER]
         assert create_response_body.media == message_body.media
@@ -235,7 +235,7 @@ def test_successful_create_and_get_call(self, voice_client):
         assert create_response_body.mfrom == BW_NUMBER
         assert create_response_body.call_url == "https://voice.bandwidth.com/api/v2/accounts/" + \
                BW_ACCOUNT_ID + "/calls/" + create_response_body.call_id
-        assert datetime.fromisoformat(str(create_response_body.start_time))    # assert that str(start_time) is datetime
+        assert dateutil.parser.isoparse(str(create_response_body.start_time))    # assert that str(start_time) is datetime
         assert type(create_response_body.call_timeout) is float
         assert type(create_response_body.callback_timeout) is float
         assert create_response_body.answer_method == "POST"
@@ -244,12 +244,12 @@ def test_successful_create_and_get_call(self, voice_client):
         assert get_response_body.call_id == create_response_body.call_id
         assert get_response_body.application_id == BW_VOICE_APPLICATION_ID
         assert get_response_body.account_id == BW_ACCOUNT_ID
-        assert datetime.fromisoformat(str(get_response_body.start_time))
-        assert datetime.fromisoformat(str(get_response_body.last_update))
+        assert dateutil.parser.isoparse(str(get_response_body.start_time))
+        assert dateutil.parser.isoparse(str(get_response_body.last_update))
         if get_response_body.answer_time:    # may be null dependent on timing
-            assert datetime.fromisoformat(str(get_response_body.answer_time))
+            assert dateutil.parser.isoparse(str(get_response_body.answer_time))
         if get_response_body.end_time:    # may be null dependent on timing
-            assert datetime.fromisoformat(str(get_response_body.end_time))
+            assert dateutil.parser.isoparse(str(get_response_body.end_time))
         if get_response_body.disconnect_cause == "error":
             assert type(get_response_body.error_message) is str
             assert len(get_response_body.error_id) == 36
@@ -425,6 +425,9 @@ def test_failed_mfa_verify(self, mfa_client):
             code="123456",
             expiration_time_in_minutes=3
         )
+
+        print(body.to)
+
         verify_response = mfa_client.create_verify_two_factor(BW_ACCOUNT_ID, body)
         verify_response_body = verify_response.body
 

.github/actions/validate/entrypoint.sh

@@ -274,6 +274,10 @@ def test_transfer(self):
         )
         response.add_verb(transfer)
         expected_bxml = f'<?xml version="1.0" encoding="UTF-8"?><Response><Transfer transferCallerId="+15555555555" callTimeout="50" tag="tag" transferCompleteUrl="https://transcribe.url.server/complete" transferCompleteMethod="POST" username="user" password="pass" diversionTreatment="propagate" diversionReason="away" transferCompleteFallbackUrl="https://test.com" transferCompleteFallbackMethod="GET" fallbackUsername="fusern" fallbackPassword="fpassw">{phone1_bxml}{phone2_bxml}</Transfer></Response>'
+
+        print(response.to_bxml())
+        print(expected_bxml)
+
         assert response.to_bxml() == expected_bxml
 
     def test_conference(self):

.github/workflows/validate.yaml .github/workflows/test.yaml.github/workflows/validate.yaml renamed to .github/workflows/test.yaml

@@ -1,7 +1,8 @@
-requests~=2.24
+requests>=2.25
 jsonpickle~=1.4, >= 1.4.1
 cachecontrol~=0.12.6
 python-dateutil~=2.8.1
 enum34~=1.1, >=1.1.10
-lxml==4.6.3
-pytest==6.2.5
+lxml>==4.6.3
+pytest>==6.2.5
+urllib3>=1.26

bandwidth/tests/test_api.py

@@ -0,0 +1,20 @@
+attrs==21.2.0
+CacheControl==0.12.6
+certifi==2021.5.30
+charset-normalizer==2.0.6
+enum34==1.1.10
+idna==3.2
+iniconfig==1.1.1
+jsonpickle==0.9.6
+lxml==4.6.3
+msgpack==1.0.2
+packaging==21.0
+pluggy==1.0.0
+py==1.10.0
+pyparsing==2.4.7
+pytest==6.2.5
+python-dateutil==2.8.2
+requests==2.26.0
+six==1.16.0
+toml==0.10.2
+urllib3==1.26.6