str instead of enum to remain conssitent

Author: ajrice6713

bandwidth/models/bxml/verbs/start_stream.py

@@ -9,14 +9,13 @@
 
 from ..nestable_verb import NestableVerb
 from ..verbs.stream_param import StreamParam
-from ...streaming_mode_enum import StreamingModeEnum
 
 
 class StartStream(NestableVerb):
 
     def __init__(
         self, destination: str, stream_params: List[StreamParam] = [],
-        name: str=None, mode: StreamingModeEnum=None, tracks: str=None,
+        name: str=None, mode: str=None, tracks: str=None,
         stream_event_url: str=None,
         stream_event_method: str=None,
         username: str=None, password: str=None,
@@ -56,7 +55,7 @@ def _attributes(self):
         return {
             "destination": self.destination,
             "name": self.name,
-            "mode": self.mode.value if self.mode else None,
+            "mode": self.mode,
             "tracks": self.tracks,
             "streamEventUrl": self.stream_event_url,
             "streamEventMethod": self.stream_event_method,

bandwidth/models/streaming_mode_enum.py

@@ -7,7 +7,6 @@
 """
 import unittest
 
-from bandwidth.models.streaming_mode_enum import StreamingModeEnum
 from bandwidth.models.bxml import StartStream, StreamParam, Verb, NestableVerb
 
 
@@ -27,6 +26,7 @@ def setUp(self):
         self.start_stream = StartStream(
             stream_params=[self.stream_param1],
             name = "stream1",
+            mode = "bidirectional",
             tracks = "inbound",
             destination = "testurl.com",
             stream_event_url="eventurl.com",
@@ -41,15 +41,10 @@ def test_instance(self):
         assert isinstance(self.start_stream, Verb)
 
     def test_to_bxml(self):
-        expected = '<StartStream destination="testurl.com" name="stream1" tracks="inbound" streamEventUrl="eventurl.com" streamEventMethod="POST" username="user" password="pass"><StreamParam name="name1" value="value1" /></StartStream>'
+        expected = '<StartStream destination="testurl.com" name="stream1" mode="bidirectional" tracks="inbound" streamEventUrl="eventurl.com" streamEventMethod="POST" username="user" password="pass"><StreamParam name="name1" value="value1" /></StartStream>'
         assert expected == self.start_stream.to_bxml()
 
     def test_add_verb(self):
-        expected = '<StartStream destination="testurl.com" name="stream1" tracks="inbound" streamEventUrl="eventurl.com" streamEventMethod="POST" username="user" password="pass"><StreamParam name="name1" value="value1" /><StreamParam name="name2" value="value2" /></StartStream>'
+        expected = '<StartStream destination="testurl.com" name="stream1" mode="bidirectional" tracks="inbound" streamEventUrl="eventurl.com" streamEventMethod="POST" username="user" password="pass"><StreamParam name="name1" value="value1" /><StreamParam name="name2" value="value2" /></StartStream>'
         self.start_stream.add_verb(self.stream_param2)
         assert expected == self.start_stream.to_bxml()
-
-    def test_bidirectional(self):
-        self.start_stream.mode = StreamingModeEnum.BIDIRECTIONAL
-        expected = '<StartStream destination="testurl.com" name="stream1" mode="bidirectional" tracks="inbound" streamEventUrl="eventurl.com" streamEventMethod="POST" username="user" password="pass"><StreamParam name="name1" value="value1" /></StartStream>'
-        assert expected == self.start_stream.to_bxml()