Skip to content

Commit 053f99a

Browse files
authored
Merge pull request #31 from IzzySoft/revfix
fix PHP warnings on not-set values in reviews
2 parents d711296 + 6cead5b commit 053f99a

File tree

1 file changed

+14
-12
lines changed

1 file changed

+14
-12
lines changed

google-play.php

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,7 @@ public function parseApplication($packageName, $lang='en_US', $loc='US') {
244244

245245
$limit = 5; $proto = '';
246246
while ( empty($proto) && $limit > 0 ) { // sometimes protobuf is missing, but present again on subsequent call
247-
$proto = json_decode($this->getRegVal("/key: 'ds:4'. hash: '7'. data:(?<content>\[\[\[.+?). sideChannel: .*?\);<\/script/ims")); // DataSource:4 = featureGraphic, video, summary
247+
$proto = json_decode($this->getRegVal("/key: 'ds:4'. hash: '\d+'. data:(?<content>\[\[\[.+?). sideChannel: .*?\);<\/script/ims")); // DataSource:4 = featureGraphic, video, summary
248248
if ( empty($proto) || empty($proto[1]) ) {
249249
$this->getApplicationPage($packageName, $lang, $loc);
250250
--$limit;
@@ -264,17 +264,19 @@ public function parseApplication($packageName, $lang='en_US', $loc='US') {
264264
if ( $proto = json_decode($this->getRegVal("/key: 'ds:7'. hash: '\d+'. data:(?<content>\[\[\[.+?). sideChannel: .*?\);<\/script/ims")) ) { // DataSource:7 = reviews
265265
foreach($proto[0] as $rev) {
266266
$r["review_id"] = $rev[0];
267-
$r["reviewed_version"] = $rev[10];
268-
$r["review_date"] = $rev[5][0];
269-
$r["review_text"] = $rev[4];
270-
$r["stars"] = $rev[2];
271-
$r["like_count"] = $rev[6];
272-
$r["reviewer"] = [
273-
"reviewer_id"=>$rev[9][0],
274-
"name"=>$rev[9][1],
275-
"avatar"=>$rev[9][3][0][3][2],
276-
"bg_image"=>$rev[9][4][3][2]
277-
];
267+
$r["reviewed_version"] = (isset($rev[10])) ? $rev[10] : '';
268+
$r["review_date"] = isset($rev[5][0]) ? $rev[5][0] : '';
269+
$r["review_text"] = isset($rev[4]) ? $rev[4] : '';
270+
$r["stars"] = isset($rev[2]) ? $rev[2] : '';
271+
$r["like_count"] = isset ($rev[6]) ? $rev[6] : '';
272+
if ( isset($rev[9]) && !empty($rev[9]) ) {
273+
$r["reviewer"] = [
274+
"reviewer_id"=>$rev[9][0],
275+
"name"=>$rev[9][1],
276+
"avatar"=>$rev[9][3][0][3][2],
277+
"bg_image"=>$rev[9][4][3][2]
278+
];
279+
} else $r["reviewer"] = [];
278280
if ( empty($rev[7]) ) {
279281
$r["reply"] = [];
280282
} else {

0 commit comments

Comments
 (0)