Remove duplicated code for testing request queue time

Author: alexisbernard

test/plugin/middleware_test.rb

@@ -4,25 +4,14 @@ class RorVsWild::Plugin::MiddlewareTest < Minitest::Test
   include RorVsWild::AgentHelper
 
   def test_callback
-    agent # Load agent
-    request = {"ORIGINAL_FULLPATH" => "/foo/bar"}
-    app = mock(call: nil)
-    middleware = RorVsWild::Plugin::Middleware.new(app, nil)
-    middleware.stubs(rails_engine_location: ["/rails/lib/engine.rb", 12])
-    middleware.call(request)
+    middleware.call("ORIGINAL_FULLPATH" => "/foo/bar")
     assert_equal("/foo/bar", agent.current_execution.path)
-    assert_equal(1, agent.current_execution.sections.size)
-    assert_equal("Rails::Engine#call", agent.current_execution.sections[0].command)
+    assert_equal(1, (sections = current_sections_without_gc).size)
+    assert_equal("Rails::Engine#call", sections[0].command)
   end
 
   def test_queue_time_section
-    agent # Load agent
-    request = {"HTTP_X_REQUEST_START" => unix_timestamp_seconds.to_s}
-    app = mock(call: nil)
-    middleware = RorVsWild::Plugin::Middleware.new(app, nil)
-    middleware.stubs(rails_engine_location: ["/rails/lib/engine.rb", 12])
-
-    middleware.call(request)
+    middleware.call("HTTP_X_REQUEST_START" => unix_timestamp_seconds.to_s)
 
     sections = current_sections_without_gc
     assert_equal(2, sections.size)
@@ -34,47 +23,26 @@ def test_queue_time_section
   end
 
   def test_queue_time_secs
-    agent # Load agent
-    request_start = unix_timestamp_seconds - 0.123
-    request = {"HTTP_X_REQUEST_START" => request_start.to_s}
-    app = mock(call: nil)
-    middleware = RorVsWild::Plugin::Middleware.new(app, nil)
-    middleware.stubs(rails_engine_location: ["/rails/lib/engine.rb", 12])
-
-    middleware.call(request)
+    middleware.call("HTTP_X_REQUEST_START" => (unix_timestamp_seconds - 0.123).to_s)
 
     sections = current_sections_without_gc
     assert_equal(2, sections.size)
     assert_operator(123, :<=, sections[0].total_ms)
   end
 
   def test_queue_time_millis
-    agent # Load agent
-    request_start = unix_timestamp_seconds * 1000 - 234
-    request = { "HTTP_X_QUEUE_START" => request_start.to_s }
-    app = mock(call: nil)
-    middleware = RorVsWild::Plugin::Middleware.new(app, nil)
-    middleware.stubs(rails_engine_location: ["/rails/lib/engine.rb", 12])
-
-    middleware.call(request)
+    middleware.call("HTTP_X_QUEUE_START" => (unix_timestamp_seconds * 1000 - 234).to_s)
 
     sections = current_sections_without_gc
     assert_equal(2, sections.size)
     assert_operator(234, :<=, sections[0].total_ms)
   end
 
   def test_queue_time_micros
-    agent # Load agent
-    request_start = unix_timestamp_seconds * 1_000_000 - 345_000
-    request = { "HTTP_X_MIDDLEWARE_START" => request_start.to_s }
-    app = mock(call: nil)
-    middleware = RorVsWild::Plugin::Middleware.new(app, nil)
-    middleware.stubs(rails_engine_location: ["/rails/lib/engine.rb", 12])
-    middleware.call(request)
+    middleware.call("HTTP_X_MIDDLEWARE_START" => (unix_timestamp_seconds * 1_000_000 - 345_000).to_s)
 
     sections = current_sections_without_gc
     assert_equal(2, sections.size)
-    queue_time_section = sections[0]
     assert_operator(345, :<=, sections[0].total_ms)
   end
 
@@ -83,4 +51,12 @@ def test_queue_time_micros
   def unix_timestamp_seconds
     Time.now.to_f
   end
+
+  def middleware
+    agent # Load agent
+    app = mock(call: nil)
+    middleware = RorVsWild::Plugin::Middleware.new(app, nil)
+    middleware.stubs(rails_engine_location: ["/rails/lib/engine.rb", 12])
+    middleware
+  end
 end