Make Ask Omi shortcut toggle AI conversation open/close (#5403)

## Summary
- Remove Cmd+\ global shortcut (no longer hides/shows floating bar)
- Ask Omi shortcut now toggles: press once to open AI input, press again
to collapse back to pill
- Works globally without requiring window focus (unlike Esc)

## Test plan
- [ ] Press Ask Omi shortcut → AI input opens
- [ ] Press Ask Omi shortcut again → collapses to pill
- [ ] Press Ask Omi shortcut when bar is hidden → shows bar and opens AI
input
- [ ] Verify Cmd+\ no longer does anything

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Author: kodjima33

desktop/Desktop/Sources/FloatingControlBar/FloatingControlBarWindow.swift

@@ -848,20 +848,27 @@ class FloatingControlBarManager {
     }
 
     /// Toggle visibility.
-    /// When visible with an AI conversation open, collapse to the pill instead of hiding.
     func toggle() {
         guard let window = window else { return }
         if window.isVisible {
-            if window.state.showingAIConversation {
-                window.closeAIConversation()
-            }
-            // Already collapsed pill — do nothing (don't hide)
+            AnalyticsManager.shared.floatingBarToggled(visible: false, source: "shortcut")
+            hide()
         } else {
             AnalyticsManager.shared.floatingBarToggled(visible: true, source: "shortcut")
             show()
         }
     }
 
+    /// Toggle AI input: if conversation is open, collapse it; otherwise open it.
+    func toggleAIInput() {
+        guard let window = window else { return }
+        if window.isVisible && window.state.showingAIConversation {
+            window.closeAIConversation()
+        } else {
+            openAIInput()
+        }
+    }
+
     /// Open the AI input panel.
     func openAIInput() {
         guard let window = window else { return }

desktop/Desktop/Sources/FloatingControlBar/GlobalShortcutManager.swift

@@ -7,13 +7,11 @@ import Cocoa
 class GlobalShortcutManager {
     static let shared = GlobalShortcutManager()
 
-    static let toggleFloatingBarNotification = Notification.Name("com.omi.desktop.toggleFloatingBar")
     static let askAINotification = Notification.Name("com.omi.desktop.askAI")
 
     private var hotKeyRefs: [HotKeyID: EventHotKeyRef] = [:]
 
     private enum HotKeyID: UInt32 {
-        case toggleBar = 1
         case askOmi = 2
     }
 
@@ -44,8 +42,6 @@ class GlobalShortcutManager {
 
     func registerShortcuts() {
         unregisterShortcuts()
-        // Register Cmd+\ for toggle bar (keycode 42 = backslash)
-        registerHotKey(keyCode: 42, modifiers: Int(cmdKey), id: .toggleBar)
         // Register Ask Omi shortcut from user settings
         registerAskOmi()
     }
@@ -93,13 +89,10 @@ class GlobalShortcutManager {
         }
 
         switch id {
-        case .toggleBar:
-            NSLog("GlobalShortcutManager: Cmd+\\ detected, toggling floating bar")
-            NotificationCenter.default.post(name: GlobalShortcutManager.toggleFloatingBarNotification, object: nil)
         case .askOmi:
             NSLog("GlobalShortcutManager: Ask Omi shortcut detected")
             DispatchQueue.main.async {
-                FloatingControlBarManager.shared.openAIInput()
+                FloatingControlBarManager.shared.toggleAIInput()
             }
         }
 

desktop/Desktop/Sources/OmiApp.swift

@@ -139,7 +139,6 @@ class AppDelegate: NSObject, NSApplicationDelegate, NSMenuDelegate {
     private var localHotkeyMonitor: Any?
     private var windowObservers: [NSObjectProtocol] = []
     private var statusBarItem: NSStatusItem?
-    private var toggleBarObserver: NSObjectProtocol?
     private var screenCaptureSwitch: NSSwitch?
     private var audioRecordingSwitch: NSSwitch?
 
@@ -334,17 +333,8 @@ class AppDelegate: NSObject, NSApplicationDelegate, NSMenuDelegate {
         // Register global hotkey for Rewind (Cmd+Shift+Space)
         setupGlobalHotkeys()
 
-        // Register Carbon-based global shortcuts for floating control bar (Cmd+\)
+        // Register Carbon-based global shortcuts for floating control bar (Ask Omi)
         GlobalShortcutManager.shared.registerShortcuts()
-        toggleBarObserver = NotificationCenter.default.addObserver(
-            forName: GlobalShortcutManager.toggleFloatingBarNotification,
-            object: nil,
-            queue: .main
-        ) { _ in
-            Task { @MainActor in
-                FloatingControlBarManager.shared.toggle()
-            }
-        }
 
         // Ensure app always shows in dock as a regular app
         NSApp.setActivationPolicy(.regular)
@@ -549,7 +539,7 @@ class AppDelegate: NSObject, NSApplicationDelegate, NSMenuDelegate {
         }
 
         log("AppDelegate: Hotkey monitors registered - global=\(globalHotkeyMonitor != nil), local=\(localHotkeyMonitor != nil)")
-        log("AppDelegate: Hotkey is Ctrl+Option+R (⌃⌥R), Ask Omi + Cmd+\\ via Carbon hotkeys")
+        log("AppDelegate: Hotkey is Ctrl+Option+R (⌃⌥R), Ask Omi via Carbon hotkeys")
     }
 
     // Dock icon is always visible — LSUIElement=false and activation policy stays .regular
@@ -921,11 +911,7 @@ class AppDelegate: NSObject, NSApplicationDelegate, NSMenuDelegate {
             NSEvent.removeMonitor(monitor)
             localHotkeyMonitor = nil
         }
-        // Remove floating bar observers and shortcuts
-        if let observer = toggleBarObserver {
-            NotificationCenter.default.removeObserver(observer)
-            toggleBarObserver = nil
-        }
+        // Remove floating bar shortcuts
         GlobalShortcutManager.shared.unregisterShortcuts()
 
         // Stop push-to-talk