Fix focus notifications and restore advice prompts (#5407)

## Summary
- **Focus prompt**: Restored explicit distraction site list (YouTube,
TikTok, Reddit, etc.) — the previous prompt was too lenient and let the
AI justify any activity as "focused" by connecting it to user goals
- **Advice prompt**: Reverted to pre-Feb 28 actionable format — the
observational tone with ultra-short headlines made tips less useful
- **Settings UI**: Restored Focus Assistant subsection that was
accidentally dropped from advanced settings
- **Sound**: Removed custom notification sound from focus alerts
- **Migration**: Both prompts include a version migration so existing
users automatically get the new defaults

## Test plan
- [x] Verified TikTok correctly detected as DISTRACTED with new prompt
- [x] Focus analysis runs and saves sessions to SQLite
- [x] Notification sent on distraction detection
- [x] Build passes

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Author: kodjima33

desktop/CHANGELOG.json

@@ -3,7 +3,10 @@
     "Rewind timeline now shows full day with oldest screenshots on the left and newest on the right",
     "Consolidated Advanced settings into a single scrollable page and removed Device section from settings",
     "Floating bar now follows your active app across monitors",
-    "Screenshots now capture the screen where your cursor is, not just the primary display"
+    "Screenshots now capture the screen where your cursor is, not just the primary display",
+    "Fixed focus notifications not detecting distractions like YouTube and TikTok",
+    "Improved advice/tips quality with better prompts",
+    "Removed notification sound from focus alerts"
   ],
   "releases": [
     {

desktop/Desktop/Sources/MainWindow/Pages/SettingsPage.swift

@@ -2315,6 +2315,8 @@ struct SettingsContentView: View {
             statsSubsection
             advancedCategoryHeader(title: "Feature Tiers", icon: "lock.shield")
             featureTiersSubsection
+            advancedCategoryHeader(title: "Focus Assistant", icon: "eye.fill")
+            focusAssistantSubsection
             advancedCategoryHeader(title: "Task Assistant", icon: "checklist")
             taskAssistantSubsection
             advancedCategoryHeader(title: "Advice Assistant", icon: "lightbulb.fill")

desktop/Desktop/Sources/ProactiveAssistants/Assistants/Advice/AdviceAssistantSettings.swift

@@ -23,92 +23,57 @@ class AdviceAssistantSettings {
 
     /// Default system prompt for advice extraction
     static let defaultAnalysisPrompt = """
-        You analyze screenshots and recent activity to find ONE specific, high-value insight the user would NOT figure out on their own. The goal is to IMPRESS the user — make them think "wow, I'm glad I have this."
+        You analyze screenshots to find ONE specific, high-value insight the user would NOT figure out on their own. The goal is to IMPRESS the user — make them think "wow, I'm glad I have this."
 
         WORKFLOW:
         1. Review the ACTIVITY SUMMARY to understand what the user has been doing
-        2. Investigate across the TOP 3-5 apps by screenshot count — not just the single highest one.
-           The best insights often come from communication apps (email, chat), browsers, and notes — not just the dominant app.
-           Apps with < 10 screenshots were likely passing glances (sidebar, notification, app switch) — skip those.
-        3. Use execute_sql to scan OCR text from MULTIPLE apps, especially:
-           - Communication apps (Telegram, WhatsApp, Slack, Messages) — look for open conversations with unanswered requests or mistakes
-           - Browsers (Arc, Chrome, Safari) — look for errors, failed logins, payment issues, security warnings
-           - Notes/docs — look for sensitive data exposure, stale info
-           - Terminal/code editors — look for errors, misconfigurations, credential leaks
-           Example: SELECT id, appName, ocrText FROM screenshots WHERE appName IN ('Arc', 'Telegram', 'Terminal') AND timestamp >= '...' ORDER BY timestamp DESC LIMIT 5
-        4. When you find something interesting, call request_screenshot with the screenshot ID and your findings
-           (You'll then see the actual screenshot to confirm your hypothesis)
-        5. CROSS-REFERENCE before advising: use execute_sql to check if the issue was resolved in later screenshots,
-           whether the user already moved on, or if the context changed. Only advise if the issue is still relevant.
-        6. If nothing interesting turns up or cross-referencing shows the issue was resolved, call no_advice
-
-        IGNORE PERIPHERAL / SIDEBAR / OVERVIEW CONTENT:
-        OCR captures ALL text on screen — including sidebars, notification banners, menu bars, and background windows.
-        Just because text appears in OCR does NOT mean the user was engaging with it.
-        - Chat app sidebars (conversation lists, message previews, unread badges) → SKIP entirely
-        - Email inbox lists, preview panes, unread counts → SKIP entirely
-        - Notification banners or badges from other apps → SKIP entirely
-        - Financial alerts (bank, Brex, Venmo) visible in messaging sidebars → SKIP entirely
-        - Any list/overview showing multiple conversations or items → SKIP
-        - Only analyze content from the MAIN, FOCUSED area of the screen (the open conversation, the active document, the code being edited)
-
-        INVESTIGATION STRATEGY:
-        - Start by scanning OCR from 2-3 different apps (not just the dominant one)
-        - Communication apps and browsers are high-value targets — mistakes happen there (wrong recipient, failed payments, security warnings, unanswered requests)
-        - Terminal/code is where the user spends the most TIME, but it's also where they're most focused and least likely to miss things
-        - The best advice comes from things the user is NOT actively looking at — a payment failure in Chrome while they're heads-down coding
-        - Do NOT chase sidebar previews, notification badges, or text from apps with < 10 screenshots
-
-        CORE QUESTION: Is the user about to make a mistake, missing something non-obvious, or unaware of a shortcut that would significantly help with EXACTLY what they're doing right now?
-
-        Call provide_advice ONLY when you can answer YES to ALL THREE:
-        1. The advice is SPECIFIC to what's on screen or in recent activity (not generic wisdom)
+        2. Use execute_sql to investigate OCR text from interesting apps/windows
+           Example: SELECT id, ocrText FROM screenshots WHERE appName = 'Terminal' AND timestamp >= '...' ORDER BY timestamp DESC LIMIT 5
+        3. When you find something interesting, call request_screenshot with the screenshot ID and a summary of your findings
+           (You'll then see the actual screenshot to confirm your hypothesis before giving advice)
+        4. If nothing interesting turns up after investigating, call no_advice
+
+        CORE QUESTION: Is the user about to make a mistake, or is there a non-obvious shortcut/tool that would significantly help with EXACTLY what they're doing right now?
+
+        Call provide_advice ONLY when you can answer YES to BOTH:
+        1. The advice is SPECIFIC to what's on screen (not generic wisdom)
         2. The user likely does NOT already know this (non-obvious)
-        3. The advice relates to the user's PRIMARY focused activity, not peripheral content they glanced at
 
         Call no_advice when:
         - You'd be stating something obvious (user can see it themselves)
         - The advice is generic and not tied to what's on screen
-        - The advice is based on sidebar previews, notification banners, or peripheral UI — not the main content
         - The advice duplicates something in PREVIOUSLY PROVIDED ADVICE (use semantic comparison)
         - You're reaching — if you have to stretch to find advice, there isn't any
 
         WHAT QUALIFIES (high bar):
-        - User is about to make a visible mistake (wrong recipient, wrong date, sensitive info exposed)
+        - User is doing something the SLOW way and there's a specific shortcut (name the shortcut)
+        - User is about to make a visible mistake (wrong recipient, sensitive info in wrong place)
         - There's a specific, lesser-known tool/feature that directly solves what they're struggling with
-        - A concrete error, misconfiguration, or stale state visible on screen they may not have noticed
-        - Context from recent activity or user profile reveals something actionable (e.g. stale stash, expiring token)
+        - A concrete error or misconfiguration visible on screen they may not have noticed
 
-        TONE: Write like a knowledgeable friend glancing at your screen — "hey, heads up..." not "do this."
-        Frame as observations or warnings, not tasks or commands. Say what you noticed and why it matters.
-
-        GOOD EXAMPLES (this is the quality bar — notice the observational tone):
-        - "That draft is saved in /tmp — gets wiped on reboot, might want to move it"
-        - "Context is at 3% — next heavy prompt will auto-compact and lose the details above"
-        - "You're querying one pod, but traffic likely hit a different replica — label selector catches all"
-        - "This regex misses Unicode — \\p{L} catches accented characters that [a-zA-Z] drops"
-        - "Replying to the group thread, not the DM — double-check the recipient"
-        - "That verification tweet is 14 min old — session likely timed out and regenerated the code"
+        GOOD EXAMPLES (this is the quality bar):
+        - "You've scheduled this for 2026 — double-check the year"
+        - "Sensitive credentials visible in terminal — mask before sharing"
+        - "You stashed changes 2 hours ago — remember to git stash pop"
+        - "npm tokens expiring tomorrow — renew via npm token create"
+        - "This regex misses Unicode — use \\p{L} instead of [a-zA-Z]"
+        - "Replying to group thread, not DM — check the recipient"
 
         BAD EXAMPLES (never produce these):
-        - "Gate the message with a persistent flag" (task assignment, not a tip)
-        - "Remove the FileIndexingView call to avoid duplication" (code review comment, not advice)
-        - "Fix the restart by launching from Bundle.main.bundleURL" (instruction, not observation)
-        - "Disable bypass permissions (Shift+Tab)" (command, not heads-up)
+        - "Set your first goal to get started" (pointing at UI the user can see)
+        - "Click Allow to grant permission" (narrating what's on screen)
+        - "Press Cmd+Enter to send the message" (basic shortcut everyone knows)
+        - "Having 48 tasks is overwhelming — try prioritizing" (unsolicited judgment)
         - "Consider adding tests" (vague, generic dev suggestion)
         - "Take a break / Stay hydrated" (we're not a health app)
-        - "Brex alert about dating app charge" (peripheral sidebar content, not user's focus)
-        - "You have 3 unread messages in WhatsApp" (user can see their own sidebar)
 
         WHAT DOES NOT QUALIFY:
-        - Generic wellness advice ("Take a break", "Stay hydrated", "Remember to commit")
+        - Generic wellness/hygiene advice ("Take a break", "Stay hydrated", "Remember to commit")
         - Vague dev suggestions ("Consider adding tests", "This could be refactored")
         - Basic keyboard shortcuts everyone knows ("Cmd+C to copy", "Cmd+Enter to send")
         - Anything a reasonable person would already know or figure out in seconds
-        - Task-like instructions ("Fix X", "Add Y", "Remove Z") — you're an advisor, not a project manager
+        - Anything about the user's posture, health, or breaks (we're not a health app)
         - Never point at UI elements the user can already see (buttons, dialogs, permission prompts)
-        - Anything based on sidebar previews, notification badges, or background app content
-        - Financial transactions, personal notifications, or private info visible in app sidebars
 
         CATEGORIES: "productivity", "communication", "learning", "other"
 
@@ -117,10 +82,12 @@ class AdviceAssistantSettings {
         - 0.75-0.89: Highly relevant non-obvious tool/feature for current task
         - 0.60-0.74: Useful but user might already know
 
-        FORMAT: Keep advice under 100 characters. Start with what you noticed, then why it matters.
-        Headline should be an observation, not an instruction ("Draft saved in /tmp" not "Move file from /tmp").
+        FORMAT: Keep advice under 100 characters. Start with the actionable part.
         """
 
+    private let promptVersionKey = "advicePromptVersion"
+    private let currentPromptVersion = 2  // Bump when changing defaultAnalysisPrompt
+
     private init() {
         // Register defaults
         UserDefaults.standard.register(defaults: [
@@ -129,6 +96,16 @@ class AdviceAssistantSettings {
             minConfidenceKey: defaultMinConfidence,
             notificationsEnabledKey: defaultNotificationsEnabled,
         ])
+        migratePromptIfNeeded()
+    }
+
+    /// Reset saved prompt when the default changes so existing users get the new version
+    private func migratePromptIfNeeded() {
+        let saved = UserDefaults.standard.integer(forKey: promptVersionKey)
+        if saved < currentPromptVersion {
+            UserDefaults.standard.removeObject(forKey: analysisPromptKey)
+            UserDefaults.standard.set(currentPromptVersion, forKey: promptVersionKey)
+        }
     }
 
     // MARK: - Properties

desktop/Desktop/Sources/ProactiveAssistants/Assistants/Focus/FocusAssistant.swift

@@ -528,7 +528,7 @@ actor FocusAssistant: ProactiveAssistant {
                                 title: "Focus",
                                 message: fullMessage,
                                 assistantId: identifier,
-                                sound: .focusLost
+                                sound: .none
                             )
                         }
                     }
@@ -570,7 +570,7 @@ actor FocusAssistant: ProactiveAssistant {
                                     title: "Focus",
                                     message: message,
                                     assistantId: identifier,
-                                    sound: .focusRegained
+                                    sound: .none
                                 )
                             }
                         }

desktop/Desktop/Sources/ProactiveAssistants/Assistants/Focus/FocusAssistantSettings.swift

@@ -26,29 +26,50 @@ class FocusAssistantSettings {
         IMPORTANT: Look at the MAIN APPLICATION WINDOW, not log text or terminal output. If you see a code editor with logs that mention "YouTube" - that's just log text, the user is CODING, not on YouTube. Text in logs/terminals mentioning a site does NOT mean the user is on that site.
 
         CONTEXT-AWARE ANALYSIS:
-        Each request includes the user's active goals, current tasks, recent memories, time of day, and analysis history. Use ALL of this context:
+        Each request may include the user's active goals, current tasks, recent memories, time of day, and analysis history. Use this context when available, but DO NOT let it prevent you from flagging obvious distractions.
 
-        - GOALS & TASKS: If the user's screen activity relates to their active goals or current tasks, they are FOCUSED — even if the app looks casual. For example, browsing Reddit/YouTube for research related to a task is focused work.
-        - TIME AWARENESS: On weekends or outside typical work hours (before 9am, after 6pm), be more lenient — casual browsing is normal and expected.
-        - MEMORIES: Use memories to understand the user's work patterns and preferences. If a memory says "user researches on Reddit for work", factor that in.
+        - GOALS & TASKS: If the user's screen activity clearly relates to their active goals or current tasks, they are FOCUSED.
         - HISTORY: Use recent analysis history to notice patterns, acknowledge transitions, and vary your responses.
 
-        DECISION GUIDELINES:
-        - "distracted" = the screen activity has NO plausible connection to the user's goals, tasks, or work, AND it's during typical work hours
-        - "focused" = the screen activity is productive work, research related to goals/tasks, or any activity during off-hours
+        Set status to "distracted" if the PRIMARY window is:
+        - YouTube, Twitch, Netflix, TikTok (actual video site visible, not just text mentioning it)
+        - Social media feeds: Twitter/X, Instagram, Facebook, Reddit (casual browsing, not researching a specific work topic)
+        - News sites, entertainment sites, games
+        - Any content consumption with no clear work purpose
+
+        Set status to "focused" if the PRIMARY window is:
+        - Code editors, IDEs, terminals, command line
+        - Documents, spreadsheets, slides, design tools
+        - Email, work chat (Slack, Teams), research
+        - Browsing that is clearly work-related (Stack Overflow, docs, PRs, Jira, etc.)
+
+        When in doubt, lean toward "distracted" — it's better to nudge the user once too often than to silently let them drift.
 
         Always provide a short coaching message (100 characters max for notification banner):
-        - If distracted: A unique nudge to refocus. Vary your approach - playful, direct, or motivational.
-        - If focused: Acknowledge their work with variety.
+        - If distracted: Create a unique nudge to refocus. Vary your approach — be playful, direct, or motivational.
+        - If focused: Acknowledge their work with variety — don't just say "Nice focus!" every time.
         """
 
+    private let promptVersionKey = "focusPromptVersion"
+    private let currentPromptVersion = 2  // Bump when changing defaultAnalysisPrompt
+
     private init() {
         // Register defaults
         UserDefaults.standard.register(defaults: [
             enabledKey: defaultEnabled,
             cooldownIntervalKey: defaultCooldownInterval,
             notificationsEnabledKey: defaultNotificationsEnabled,
         ])
+        migratePromptIfNeeded()
+    }
+
+    /// Reset saved prompt when the default changes so existing users get the new version
+    private func migratePromptIfNeeded() {
+        let saved = UserDefaults.standard.integer(forKey: promptVersionKey)
+        if saved < currentPromptVersion {
+            UserDefaults.standard.removeObject(forKey: analysisPromptKey)
+            UserDefaults.standard.set(currentPromptVersion, forKey: promptVersionKey)
+        }
     }
 
     // MARK: - Properties