Fix onboarding text splitting, button timing, and transition crash (#5366)

## Summary
- Fix AI chat text being split into multiple bubbles (e.g.
"encrypted!Should") by using `message.text` directly instead of
reassembling from content blocks
- Only show Continue button after `complete_onboarding` AND no pending
questions/permissions remain
- Defer `hasCompletedOnboarding` state change to prevent SwiftUI crash
during view transition
- Pre-load hero logo as static property to avoid NSImage crash during
body evaluation

## Test plan
- [ ] Onboarding chat shows AI text as single continuous bubble, no
broken words
- [ ] Continue button only appears after all questions and permissions
are handled
- [ ] Clicking "Take me to my tasks" transitions without crash
- [ ] App loads main view without hero logo crash

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Author: kodjima33

desktop/Desktop/Sources/MainWindow/DesktopHomeView.swift

@@ -29,6 +29,13 @@ struct DesktopHomeView: View {
     @State private var previousIndexBeforeSettings: Int = 0
     @State private var logoPulse = false
 
+    // Pre-loaded hero logo to avoid NSImage init crashes during SwiftUI body evaluation
+    private static let heroLogoImage: NSImage? = {
+        guard let url = Bundle.resourceBundle.url(forResource: "herologo", withExtension: "png"),
+              let data = try? Data(contentsOf: url) else { return nil }
+        return NSImage(data: data)
+    }()
+
 
     /// Whether we're currently viewing the settings page
     private var isInSettings: Bool {
@@ -40,8 +47,7 @@ struct DesktopHomeView: View {
             if authState.isRestoringAuth {
                 // State 0: Restoring auth session - show loading
                 VStack(spacing: 16) {
-                    if let iconURL = Bundle.resourceBundle.url(forResource: "herologo", withExtension: "png"),
-                       let nsImage = NSImage(contentsOf: iconURL) {
+                    if let nsImage = Self.heroLogoImage {
                         Image(nsImage: nsImage)
                             .resizable()
                             .scaledToFit()
@@ -226,8 +232,7 @@ struct DesktopHomeView: View {
 
                     if !viewModelContainer.isInitialLoadComplete {
                         VStack(spacing: 24) {
-                            if let iconURL = Bundle.resourceBundle.url(forResource: "herologo", withExtension: "png"),
-                               let nsImage = NSImage(contentsOf: iconURL) {
+                            if let nsImage = Self.heroLogoImage {
                                 Image(nsImage: nsImage)
                                     .resizable()
                                     .scaledToFit()

desktop/Desktop/Sources/OnboardingChatView.swift

@@ -244,10 +244,9 @@ struct OnboardingChatView: View {
                             }
                         }
 
-                        // "Continue" button — shown after AI calls complete_onboarding,
-                        // or while exploration is running so user can proceed.
-                        // Hidden when quick reply buttons are showing to avoid confusing the user.
-                        if (onboardingCompleted || explorationRunning) && !chatProvider.isSending && quickReplyOptions.isEmpty {
+                        // "Continue" button — shown only after AI calls complete_onboarding
+                        // and no pending questions or permissions remain.
+                        if onboardingCompleted && !chatProvider.isSending && quickReplyOptions.isEmpty && pendingPermissionType == nil {
                             Button(action: {
                                 handleOnboardingComplete()
                             }) {
@@ -914,14 +913,9 @@ struct OnboardingChatBubble: View {
                                     .cornerRadius(18)
                             }
                         } else {
-                            // Combine all text blocks into one bubble, render tool indicators separately
-                            let allText = message.contentBlocks.compactMap { block -> String? in
-                                if case .text(_, let text) = block {
-                                    let trimmed = text.trimmingCharacters(in: .whitespacesAndNewlines)
-                                    return trimmed.isEmpty ? nil : trimmed
-                                }
-                                return nil
-                            }.joined(separator: "\n\n")
+                            // Use the full message text (which streams continuously) for a single bubble.
+                            // contentBlocks splits text around tool calls, but message.text is uninterrupted.
+                            let allText = message.text.trimmingCharacters(in: .whitespacesAndNewlines)
 
                             if !allText.isEmpty {
                                 Markdown(allText)

desktop/Desktop/Sources/OnboardingView.swift

@@ -219,8 +219,6 @@ struct OnboardingView: View {
 
         // Navigate to Tasks page after transition
         UserDefaults.standard.set(true, forKey: "onboardingJustCompleted")
-
-        appState.hasCompletedOnboarding = true
         UserDefaults.standard.set(true, forKey: "hasCompletedFileIndexing")
 
         // Start essential services
@@ -253,6 +251,13 @@ struct OnboardingView: View {
         if let onComplete = onComplete {
             onComplete()
         }
+
+        // Defer the view hierarchy change so SwiftUI finishes rendering the
+        // current button before the OnboardingView is removed from the tree.
+        // Setting this synchronously crashes in Button.body.getter.
+        DispatchQueue.main.async {
+            appState.hasCompletedOnboarding = true
+        }
     }
 }