Address UB in gen_random_buffer

ZeroMemes · ZeroMemes · commit b86121dd5466 · 2025-12-22T15:52:06.000-06:00
diff --git a/test/benchmark/Compare.cpp b/test/benchmark/Compare.cpp
@@ -15,7 +15,8 @@ static auto gen_random_buffer(const size_t size) {
     std::default_random_engine generator(123);
     std::uniform_int_distribution<uint64_t> distribution(0, 0xFFFFFFFFFFFFFFFF);
     for (size_t i = 0; i < buffer.size(); i += 8) {
-        *reinterpret_cast<uint64_t*>(&buffer[i]) = distribution(generator);
+        uint64_t value = distribution(generator);
+        std::memcpy(&buffer[i], &value, sizeof(value));
     }
     return buffer;
 }

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,8 @@ static auto gen_random_buffer(const size_t size) {`
`15`	`15`	`std::default_random_engine generator(123);`
`16`	`16`	`std::uniform_int_distribution<uint64_t> distribution(0, 0xFFFFFFFFFFFFFFFF);`
`17`	`17`	`for (size_t i = 0; i < buffer.size(); i += 8) {`
`18`		`- reinterpret_cast<uint64_t>(&buffer[i]) = distribution(generator);`
	`18`	`+ uint64_t value = distribution(generator);`
	`19`	`+ std::memcpy(&buffer[i], &value, sizeof(value));`
`19`	`20`	`}`
`20`	`21`	`return buffer;`
`21`	`22`	`}`