aliases/general: cleanup

- use `-A` instead of `-a` for `ls`,
- quote variable expansions,
- don’t *assign* default expansions,
- don’t alias `piano` without `pianobar`,

Author: gaelicWizard

aliases/available/general.aliases.bash

@@ -9,16 +9,16 @@ fi
 # List directory contents
 alias sl=ls
 alias la='ls -AF' # Compact view, show hidden
-alias ll='ls -al'
-alias l='ls -a'
+alias ll='ls -Al'
+alias l='ls -A'
 alias l1='ls -1'
 alias lf='ls -F'
 
 alias _='sudo'
 
 # Shortcuts to edit startup files
-alias vbrc='${VISUAL:-vim} ~/.bashrc'
-alias vbpf='${VISUAL:-vim} ~/.bash_profile'
+alias vbrc='"${VISUAL:-vim}" ~/.bashrc'
+alias vbpf='"${VISUAL:-vim}" ~/.bash_profile'
 
 # colored grep
 # Need to check an existing file for a pattern that will be found to ensure
@@ -35,20 +35,21 @@ alias c='clear'
 alias cls='clear'
 
 alias edit='${EDITOR:-${ALTERNATE_EDITOR?}}'
-alias pager='${PAGER:=less}'
+alias pager='${PAGER:-less}'
 
 alias q='exit'
 
-alias irc='${IRC_CLIENT:=irc}'
+alias irc='${IRC_CLIENT:-irc}'
 
 # Language aliases
 alias rb='ruby'
 alias py='python'
 alias ipy='ipython'
 
 # Pianobar can be found here: http://github.com/PromyLOPh/pianobar/
-
+if _command_exists pianobar; then
 alias piano='pianobar'
+fi
 
 alias ..='cd ..'         # Go up one directory
 alias cd..='cd ..'       # Common misspelling for going up one directory
@@ -72,8 +73,8 @@ alias rd='rmdir'
 alias xt='extract'
 
 # sudo editors
-alias svim='sudo ${VISUAL:-vim}'
-alias snano='sudo nano'
+alias svim='sudo "${VISUAL:-vim}"'
+alias snano='sudo "${ALTERNATE_EDITOR:-nano}"'
 
 # Display whatever file is regular file or folder
 function catt() {