Discussion: My work refactoring bash-It and possible integration paths

[ahmadassaf]

I am a huge fan of bash-it, but the more I used it, the more I ran into some issues. Thats when I started to dig into the codebase, open PRs and contribute to the codebase. It is however, after digging deeper into some areas that I found myself moving lots of parts and restructuring big chunks the code. Moreover, I found various inconsistencies when it came to code style and adherence to bash best practices.

gaudi-bash is my fork with lots of opinionated changes in the code to suit my OCD-like nature. I am by no means a bash expert but I tried my best to conform to the best practices in here.

I also found lots of unused and redundant code, a huge part of that was to ensure backward compatibility with the older versions of bash-it. Sometimes, it is better to start fresh and put the past behind us!

The main changes in this repo are:

• Split the core engine from the components (plugins, aliases, completions and themes to be done soon)
• Split the code into smaller set of files e.g., components, helpers, utils, etc.
• Ensure consistent way of writing bash code (function definitions, comments, etc.)
• Following as much as possible bash best practices
• Make sure to comply with shellcheck as much as possible
• Ensure high coverage unit tests for all core functions and split test functions as well into small units
• Merged some of the work from bash-it issues and open PRs that made sense to me
• Adding more functions like bash-it backup and bash-it restore

Again, I am by no means a bash expert but tried my best to work something that made sense to me, so I hope some of these decisions make sense to you as well :)

[NoahGorny]

As I said in #1664 (comment), I think the way forward for merging this into the mainline is by creating small PRs and make this as many incremental changes as we can

[ahmadassaf]

@NoahGornyI agree with the approach but I am wondering what changes/things you would like to see moving over?

[nwinkler]

Well, I guess we need to start at the lowest level... Can you walk us through the first item on your list (split core engine from components)? What does that entail?

[NoahGorny]

gentle ping @ahmadassaf

[gaelicWizard]

@ahmadassaf, since you uploaded a new repository rather than forking on GitHub, it's kind of hard to compare your changes without specifically spending time to configure a local git repo for this purpose. That makes it harder for anyone who isn't already invested specifically in your fork to work with it. I can post instructions for re-creating your GitHub repo as a fork of this one and then I'll be happy to help bring incremental improvements upstream. Are you still interested in contributing upstream?

[NoahGorny]

I am reopening this as this is an important issue!

[gaelicWizard]

I think the no-response bot needs some tweaking. For the moment, maybe remove the "needs response" label?