Fix: Async scroll...() methods are non-async in fact

Author: Bashamega

baselines/dom.generated.d.ts

@@ -13237,28 +13237,28 @@ interface Element extends Node, ARIAMixin, Animatable, ChildNode, NonDocumentTyp
      *
      * [MDN Reference](https://developer.mozilla.org/docs/Web/API/Element/scroll)
      */
-    scroll(options?: ScrollToOptions): Promise<void>;
-    scroll(x: number, y: number): Promise<void>;
+    scroll(options?: ScrollToOptions): void;
+    scroll(x: number, y: number): void;
     /**
      * The **`scrollBy()`** method of the Element interface scrolls an element by the given amount.
      *
      * [MDN Reference](https://developer.mozilla.org/docs/Web/API/Element/scrollBy)
      */
-    scrollBy(options?: ScrollToOptions): Promise<void>;
-    scrollBy(x: number, y: number): Promise<void>;
+    scrollBy(options?: ScrollToOptions): void;
+    scrollBy(x: number, y: number): void;
     /**
      * The Element interface's **`scrollIntoView()`** method scrolls the element's ancestor containers such that the element on which scrollIntoView() is called is visible to the user.
      *
      * [MDN Reference](https://developer.mozilla.org/docs/Web/API/Element/scrollIntoView)
      */
-    scrollIntoView(arg?: boolean | ScrollIntoViewOptions): Promise<void>;
+    scrollIntoView(arg?: boolean | ScrollIntoViewOptions): void;
     /**
      * The **`scrollTo()`** method of the Element interface scrolls to a particular set of coordinates inside a given element.
      *
      * [MDN Reference](https://developer.mozilla.org/docs/Web/API/Element/scrollTo)
      */
-    scrollTo(options?: ScrollToOptions): Promise<void>;
-    scrollTo(x: number, y: number): Promise<void>;
+    scrollTo(options?: ScrollToOptions): void;
+    scrollTo(x: number, y: number): void;
     /**
      * The **`setAttribute()`** method of the Element interface sets the value of an attribute on the specified element. If the attribute already exists, the value is updated; otherwise a new attribute is added with the specified name and value.
      *

baselines/ts5.5/dom.generated.d.ts

@@ -13224,28 +13224,28 @@ interface Element extends Node, ARIAMixin, Animatable, ChildNode, NonDocumentTyp
      *
      * [MDN Reference](https://developer.mozilla.org/docs/Web/API/Element/scroll)
      */
-    scroll(options?: ScrollToOptions): Promise<void>;
-    scroll(x: number, y: number): Promise<void>;
+    scroll(options?: ScrollToOptions): void;
+    scroll(x: number, y: number): void;
     /**
      * The **`scrollBy()`** method of the Element interface scrolls an element by the given amount.
      *
      * [MDN Reference](https://developer.mozilla.org/docs/Web/API/Element/scrollBy)
      */
-    scrollBy(options?: ScrollToOptions): Promise<void>;
-    scrollBy(x: number, y: number): Promise<void>;
+    scrollBy(options?: ScrollToOptions): void;
+    scrollBy(x: number, y: number): void;
     /**
      * The Element interface's **`scrollIntoView()`** method scrolls the element's ancestor containers such that the element on which scrollIntoView() is called is visible to the user.
      *
      * [MDN Reference](https://developer.mozilla.org/docs/Web/API/Element/scrollIntoView)
      */
-    scrollIntoView(arg?: boolean | ScrollIntoViewOptions): Promise<void>;
+    scrollIntoView(arg?: boolean | ScrollIntoViewOptions): void;
     /**
      * The **`scrollTo()`** method of the Element interface scrolls to a particular set of coordinates inside a given element.
      *
      * [MDN Reference](https://developer.mozilla.org/docs/Web/API/Element/scrollTo)
      */
-    scrollTo(options?: ScrollToOptions): Promise<void>;
-    scrollTo(x: number, y: number): Promise<void>;
+    scrollTo(options?: ScrollToOptions): void;
+    scrollTo(x: number, y: number): void;
     /**
      * The **`setAttribute()`** method of the Element interface sets the value of an attribute on the specified element. If the attribute already exists, the value is updated; otherwise a new attribute is added with the specified name and value.
      *

baselines/ts5.6/dom.generated.d.ts

@@ -13234,28 +13234,28 @@ interface Element extends Node, ARIAMixin, Animatable, ChildNode, NonDocumentTyp
      *
      * [MDN Reference](https://developer.mozilla.org/docs/Web/API/Element/scroll)
      */
-    scroll(options?: ScrollToOptions): Promise<void>;
-    scroll(x: number, y: number): Promise<void>;
+    scroll(options?: ScrollToOptions): void;
+    scroll(x: number, y: number): void;
     /**
      * The **`scrollBy()`** method of the Element interface scrolls an element by the given amount.
      *
      * [MDN Reference](https://developer.mozilla.org/docs/Web/API/Element/scrollBy)
      */
-    scrollBy(options?: ScrollToOptions): Promise<void>;
-    scrollBy(x: number, y: number): Promise<void>;
+    scrollBy(options?: ScrollToOptions): void;
+    scrollBy(x: number, y: number): void;
     /**
      * The Element interface's **`scrollIntoView()`** method scrolls the element's ancestor containers such that the element on which scrollIntoView() is called is visible to the user.
      *
      * [MDN Reference](https://developer.mozilla.org/docs/Web/API/Element/scrollIntoView)
      */
-    scrollIntoView(arg?: boolean | ScrollIntoViewOptions): Promise<void>;
+    scrollIntoView(arg?: boolean | ScrollIntoViewOptions): void;
     /**
      * The **`scrollTo()`** method of the Element interface scrolls to a particular set of coordinates inside a given element.
      *
      * [MDN Reference](https://developer.mozilla.org/docs/Web/API/Element/scrollTo)
      */
-    scrollTo(options?: ScrollToOptions): Promise<void>;
-    scrollTo(x: number, y: number): Promise<void>;
+    scrollTo(options?: ScrollToOptions): void;
+    scrollTo(x: number, y: number): void;
     /**
      * The **`setAttribute()`** method of the Element interface sets the value of an attribute on the specified element. If the attribute already exists, the value is updated; otherwise a new attribute is added with the specified name and value.
      *

baselines/ts5.9/dom.generated.d.ts

@@ -13234,28 +13234,28 @@ interface Element extends Node, ARIAMixin, Animatable, ChildNode, NonDocumentTyp
      *
      * [MDN Reference](https://developer.mozilla.org/docs/Web/API/Element/scroll)
      */
-    scroll(options?: ScrollToOptions): Promise<void>;
-    scroll(x: number, y: number): Promise<void>;
+    scroll(options?: ScrollToOptions): void;
+    scroll(x: number, y: number): void;
     /**
      * The **`scrollBy()`** method of the Element interface scrolls an element by the given amount.
      *
      * [MDN Reference](https://developer.mozilla.org/docs/Web/API/Element/scrollBy)
      */
-    scrollBy(options?: ScrollToOptions): Promise<void>;
-    scrollBy(x: number, y: number): Promise<void>;
+    scrollBy(options?: ScrollToOptions): void;
+    scrollBy(x: number, y: number): void;
     /**
      * The Element interface's **`scrollIntoView()`** method scrolls the element's ancestor containers such that the element on which scrollIntoView() is called is visible to the user.
      *
      * [MDN Reference](https://developer.mozilla.org/docs/Web/API/Element/scrollIntoView)
      */
-    scrollIntoView(arg?: boolean | ScrollIntoViewOptions): Promise<void>;
+    scrollIntoView(arg?: boolean | ScrollIntoViewOptions): void;
     /**
      * The **`scrollTo()`** method of the Element interface scrolls to a particular set of coordinates inside a given element.
      *
      * [MDN Reference](https://developer.mozilla.org/docs/Web/API/Element/scrollTo)
      */
-    scrollTo(options?: ScrollToOptions): Promise<void>;
-    scrollTo(x: number, y: number): Promise<void>;
+    scrollTo(options?: ScrollToOptions): void;
+    scrollTo(x: number, y: number): void;
     /**
      * The **`setAttribute()`** method of the Element interface sets the value of an attribute on the specified element. If the attribute already exists, the value is updated; otherwise a new attribute is added with the specified name and value.
      *

inputfiles/patches/scroll.kdl

@@ -0,0 +1,9 @@
+interface Element {
+    method scroll overrideType=void
+    method scroll overrideType=void
+    method scrollBy overrideType=void
+    method scrollBy overrideType=void
+    method scrollTo overrideType=void
+    method scrollTo overrideType=void
+    method scrollIntoView overrideType=void
+}

src/build/patches.ts

@@ -9,6 +9,7 @@ import type {
   Typed,
   Dictionary,
   Member,
+  Signature,
 } from "./types.js";
 import { readdir, readFile } from "fs/promises";
 import { merge } from "./helpers.js";
@@ -168,7 +169,34 @@ function handleMixinandInterfaces(
       }
       case "method": {
         const methodName = string(child.values[0]);
-        method[methodName] = handleMethod(child);
+        const m = handleMethod(child);
+        if (method[methodName]) {
+          // ts: The goal here is to merge multiple method signatures together for methods with the same name.
+          const existingSig = method[methodName].signature;
+          const newSigEntry = Array.isArray(m.signature) ? m.signature[0] : m.signature && (m.signature as any)[0];
+          if (Array.isArray(existingSig)) {
+            // Both are arrays, push new entry (if newSigEntry is available)
+            if (newSigEntry !== undefined) {
+              existingSig.push(newSigEntry);
+            }
+          } else if (
+            existingSig &&
+            typeof existingSig === "object" &&
+            !Array.isArray(existingSig)
+          ) {
+            // Existing is an object, add next numeric key
+            let nextKey = 0;
+            // Only own, string keys that are numbers
+            while (Object.prototype.hasOwnProperty.call(existingSig, String(nextKey))) {
+              nextKey++;
+            }
+            if (newSigEntry !== undefined) {
+              (existingSig as Record<string, any>)[String(nextKey)] = newSigEntry;
+            }
+          }
+          break;
+        }
+        method[methodName] = m;
         break;
       }
       default:
@@ -265,15 +293,15 @@ function handleMethod(child: Node): Partial<Method> {
     }
   }
 
-  const signature: Method["signature"] = [
+  const signature: DeepPartial<Signature>[] | Record<string, DeepPartial<Signature>> = child.properties?.overrideType ? {"0": {overrideType: string(child.properties?.overrideType), param: params}} : [
     {
       param: params,
       ...(typeNode
         ? handleTyped(typeNode)
         : { type: string(child.properties?.returns) }),
     },
   ];
-  return { name, signature };
+  return { name, signature } as Partial<Method>;
 }
 
 /**