changed how we build the receiver array

Author: dooly123

Basis/Packages/com.basis.framework/Networking/BasisNetworkLifeCycle.cs

@@ -40,8 +40,6 @@ public static void Initalize(BasisNetworkManagement Management)
 
         Management.transform.SetPositionAndRotation(Vector3.zero, Quaternion.identity);
         BasisNetworkManagement.OnEnableInstanceCreate?.Invoke();
-
-        BasisNetworkPlayers.PublishReceiversSnapshot();
         BasisNetworkManagement.NetworkRunning = true;
     }
     public static bool GoingThroughReboot = false;

Basis/Packages/com.basis.framework/Networking/BasisNetworkManagement.cs

@@ -151,8 +151,6 @@ public static bool IsMainThread()
         public static float Beta = 2;
      //   [Header("DerivativeCutoff This controls how noisy the speed estimate itself is.Before the filter adapts, it estimates velocity:")]
         public static float DerivativeCutoff = 2;
-        public static BasisNetworkReceiver[] snapshot;
-        public static int Length;
         /// <summary>
         /// Simulates network computation step (state updates, bone drivers, profiler update).
         /// </summary>
@@ -164,12 +162,12 @@ public static void SimulateNetworkCompute(float UnscaledDeltaTime)
                 return;
             }
 
-            snapshot = BasisNetworkPlayers.ReceiversSnapshot;
+            BasisNetworkPlayers.PublishReceiversSnapshot();
+
             BoneJobSystem = RemoteBoneJobSystem.Schedule(); // will always be a frame behind
-            Length = snapshot.Length;
-            for (int Index = 0; Index < Length; Index++)
+            for (int Index = 0; Index < BasisNetworkPlayers.ReceiverCount; Index++)
             {
-                snapshot[Index].Compute(UnscaledDeltaTime);
+                BasisNetworkPlayers.ReceiversSnapshot[Index].Compute(UnscaledDeltaTime);
             }
             BasisRemoteNetworkDriver.Compute();
             BasisNetworkProfiler.Update();
@@ -197,9 +195,9 @@ public static void SimulateNetworkApply()
             }
 
             BasisRemoteNetworkDriver.Apply();
-            for (int Index = 0; Index < Length; Index++)
+            for (int Index = 0; Index < BasisNetworkPlayers.ReceiverCount; Index++)
             {
-                snapshot[Index].Apply();
+                BasisNetworkPlayers.ReceiversSnapshot[Index].Apply();
             }
         }
 

Basis/Packages/com.basis.framework/Networking/BasisNetworkPlayers.cs

@@ -21,9 +21,8 @@ public static class BasisNetworkPlayers
         public static readonly ConcurrentDictionary<string, ushort> OwnershipPairing = new();
 
         // Receiver snapshot for multi-threaded compute/apply phases.
-        private static volatile BasisNetworkReceiver[] _receiversSnapshot = Array.Empty<BasisNetworkReceiver>();
-        public static BasisNetworkReceiver[] ReceiversSnapshot => _receiversSnapshot;
-        public static int ReceiverCount => _receiversSnapshot.Length;
+        public static BasisNetworkReceiver[] ReceiversSnapshot = Array.Empty<BasisNetworkReceiver>();
+        public static int ReceiverCount;
 
         // --- Lifecycle helpers ---------------------------------------------
         public static void ClearAllRegistries()
@@ -36,11 +35,11 @@ public static void ClearAllRegistries()
             RemotePlayers.Clear();
             JoiningPlayers.Clear();
             OwnershipPairing.Clear();
-            PublishReceiversSnapshot();
         }
         public static void PublishReceiversSnapshot()
         {
-            _receiversSnapshot = RemotePlayers.Count == 0 ? Array.Empty<BasisNetworkReceiver>() : RemotePlayers.Values.ToArray();
+            ReceiversSnapshot = RemotePlayers.Count == 0 ? Array.Empty<BasisNetworkReceiver>() : RemotePlayers.Values.ToArray();
+            ReceiverCount = ReceiversSnapshot.Length;
         }
 
         // --- Registry APIs --------------------------------------------------
@@ -84,8 +83,6 @@ public static bool AddPlayer(BasisNetworkPlayer netPlayer)
                     BasisDebug.LogError($"Failed to add remote player {netPlayer.playerId} to RemotePlayers. Rolled back from Players.");
                     return false;
                 }
-
-                PublishReceiversSnapshot();
             }
 
             return true;
@@ -102,7 +99,6 @@ public static bool RemovePlayer(ushort netId, out BasisNetworkPlayer player)
 
             Players.TryRemove(netId, out player);
             RemotePlayers.TryRemove(netId, out _);
-            PublishReceiversSnapshot();
             return true;
         }