fixing up the bugs from last test

Author: dooly123

Basis/Packages/com.basis.eventdriver/BasisEventDriver.cs

@@ -131,6 +131,7 @@ public void Update()
             catch (Exception ex) { Debug.LogError($"MainThread action failed: {ex}"); }
         }
 
+        BasisNetworkManagement.UpdatePlayerArray();
         BasisNetworkManagement.SimulateNetworkCompute(unscaledDeltaTime);
         BasisObjectSyncDriver.ScheduleRemoteLerp(DeltaTime);
 #if UNITY_SERVER
@@ -159,6 +160,8 @@ public void FixedUpdate()
     /// <summary>
     /// LateUpdate step for device management loop, eye simulation, local player late sim,
     /// microphone updates (client), network apply, and JigglePhysics scheduling/pose/render.
+    /// any jobs that require jobified transforms cannot be mulithreaded while another task is interacting with transforms
+    /// welcome to unity!
     /// </summary>
     public void LateUpdate()
     {
@@ -177,8 +180,8 @@ public void LateUpdate()
         JigglePhysics.SchedulePose(TimeAsDouble);//requires free access to all transform of a player.
 
         // Device management tick
-        BasisDeviceManagement.OnDeviceManagementLoop?.Invoke(); //can do
-        BasisRemoteAudioDriver.Simulate(DeltaTime); //can do
+        BasisDeviceManagement.OnDeviceManagementLoop?.Invoke();
+        BasisRemoteAudioDriver.Simulate(DeltaTime);
 #if UNITY_SERVER
 #else
         BasisLocalMicrophoneDriver.MicrophoneUpdate();
@@ -204,7 +207,7 @@ public void LateUpdate()
         if (BasisLocalPlayer.PlayerReady)
         {
             // Eye driver (local)
-            BasisLocalPlayer.Instance.LocalEyeDriver.Simulate(DeltaTime); // cant do
+            BasisLocalPlayer.Instance.LocalEyeDriver.Simulate(DeltaTime);
         }
 
         if (SMModuleDebugOptions.UseGizmos)

Basis/Packages/com.basis.framework/Drivers/Remote/BasisRemoteBoneDriver.cs

@@ -1,6 +1,5 @@
 using Basis.Scripts.Common;
 using Basis.Scripts.Drivers;
-using System;
 using System.Collections.Generic;
 using Unity.Burst;
 using Unity.Collections;
@@ -250,15 +249,13 @@ struct GatherHipsJob : IJobParallelForTransform
     [WriteOnly] public NativeArray<float3> hipsPos;
     /// <summary>Output hips rotations.</summary>
     [WriteOnly] public NativeArray<quaternion> hipsRot;
-
     /// <summary>Executes per-hip sampling.</summary>
     public void Execute(int index, TransformAccess tx)
     {
         hipsPos[index] = tx.position;
         hipsRot[index] = tx.rotation;
     }
 }
-
 /// <summary>
 /// Applies the mouth transform directly from the computed <see cref="RemoteFrameOutput"/>.
 /// </summary>
@@ -268,14 +265,12 @@ struct ApplyMouthJob : IJobParallelForTransform
     /// <summary>Read-only pose data to apply.</summary>
     [ReadOnly]
     public NativeArray<RemoteFrameOutput> MouthRotation;
-
     /// <summary>Applies position and rotation to the bound mouth transform.</summary>
     public void Execute(int index, TransformAccess tx)
     {
         tx.SetPositionAndRotation(MouthRotation[index].pos_Mouth, MouthRotation[index].rot_Mouth);
     }
 }
-
 /// <summary>
 /// Positions the floating nameplate relative to the avatar and rotates it to face the camera (yaw only).
 /// Uses derived TPose vertical delta to place the plate above the head.
@@ -285,10 +280,8 @@ public struct MappedNameplateApplyJob : IJobParallelForTransform
 {
     /// <summary>Camera world position used to bill-board the plate (yaw-only).</summary>
     public float3 CameraPosition;
-
     /// <summary>Input pose data (per-avatar) for nameplate placement.</summary>
     [ReadOnly] public NativeArray<RemoteFrameOutput> NamePlateIn;
-
     /// <summary>Computes position above hips and rotates toward camera.</summary>
     public void Execute(int jobIndex, TransformAccess tx)
     {
@@ -331,11 +324,9 @@ struct AgrigateTranslationalData : IJobParallelFor
     [ReadOnly] public NativeArray<quaternion> tposeHeadRot;
     /// <summary>TPose hips quaternions.</summary>
     [ReadOnly] public NativeArray<quaternion> tposeHipsRot;
-
     /// <summary>Combined output to be consumed by <see cref="BasisRemoteBoneJob"/>.</summary>
     [WriteOnly]
     public NativeArray<GeneratedTranslationalData> InOut;
-
     /// <summary>Aggregates inputs into a single SoA element.</summary>
     public void Execute(int i)
     {
@@ -359,7 +350,6 @@ public void Execute(int i)
 /// </summary>
 public static class RemoteBoneJobSystem
 {
-    // Persistent SoA
     /// <summary>Authoring TPose/offsets per avatar.</summary>
     static NativeList<TposeAndOffsetDataJob> sAuthoring;
     /// <summary>Per-frame inputs per avatar.</summary>
@@ -368,37 +358,28 @@ public static class RemoteBoneJobSystem
     static NativeList<RemoteScaleCache> sScale;
     /// <summary>Per-frame pose outputs per avatar.</summary>
     static NativeList<RemoteFrameOutput> sOut;
-
-    // Cached TPose quats (job friendly)
     /// <summary>TPose head quaternions per avatar.</summary>
     static NativeList<quaternion> sTPoseHeadRot;
     /// <summary>TPose hips quaternions per avatar.</summary>
     static NativeList<quaternion> sTPoseHipsRot;
-
-    // Transform access arrays (roots / heads / hips)
     /// <summary>Root transforms per avatar.</summary>
     static TransformAccessArray sRoots;
     /// <summary>Head transforms per avatar.</summary>
     static TransformAccessArray sHeads;
     /// <summary>Hips transforms per avatar.</summary>
     static TransformAccessArray sHips;
-
     /// <summary>Nameplate transforms per avatar.</summary>
     static TransformAccessArray sNamePlate;
     /// <summary>Avatar scale proxy transforms per avatar.</summary>
     static TransformAccessArray sAvatarScale;
     /// <summary>Mouth transforms per avatar.</summary>
     static TransformAccessArray sMouth;
-
-    // Temp per-frame buffers (reused)
     /// <summary>Temp root positions.</summary>
     static NativeArray<float3> sTmpRootPos, sTmpHeadPos, sTmpHipsPos;
     /// <summary>Temp root scales.</summary>
     static NativeArray<float3> sTmpRootScale;
     /// <summary>Temp head rotations.</summary>
     static NativeArray<quaternion> sTmpHeadRot, sTmpHipsRot;
-
-    // Bookkeeping
     /// <summary>Map from external key → internal SoA index.</summary>
     static readonly Dictionary<int, int> sKeyToIndex = new Dictionary<int, int>();
     /// <summary>Pending job handle chain.</summary>
@@ -413,7 +394,10 @@ public static class RemoteBoneJobSystem
     /// <param name="initialCapacity">Optional starting capacity hint.</param>
     public static void Initialize(int initialCapacity = 0)
     {
-        if (sInitialized) return;
+        if (sInitialized)
+        {
+            return;
+        }
 
         sAuthoring = new NativeList<TposeAndOffsetDataJob>(initialCapacity, Allocator.Persistent);
         sIn = new NativeList<GeneratedTranslationalData>(initialCapacity, Allocator.Persistent);
@@ -492,7 +476,11 @@ public static int AddRemotePlayer(int key, Transform remotePlayerRoot, Transform
         BasisCalibratedCoords tposeHead, BasisCalibratedCoords tposeHips, float3 authoredCenterEyeWorld,
         float3 authoredMouthWorld, Transform NamePlate, Transform AvatarScale, Transform MouthTransform)
     {
-        if (!sInitialized) Initialize();
+        if (!sInitialized)
+        {
+            Initialize();
+        }
+
         CompletePending();
 
         float3 rootWorld = remotePlayerRoot.position;
@@ -562,10 +550,17 @@ public static int AddRemotePlayer(int key, Transform remotePlayerRoot, Transform
     /// <returns><c>true</c> if found and removed; otherwise <c>false</c>.</returns>
     public static bool RemoveRemotePlayer(int key)
     {
-        if (!sInitialized) return false;
+        if (!sInitialized)
+        {
+            return false;
+        }
+
         CompletePending();
 
-        if (!sKeyToIndex.TryGetValue(key, out int idx)) return false;
+        if (!sKeyToIndex.TryGetValue(key, out int idx))
+        {
+            return false;
+        }
 
         int last = sAuthoring.Length - 1;
         if (idx != last)
@@ -766,7 +761,10 @@ public static JobHandle Schedule(int batchSize = 64)
     public static void Complete(JobHandle handle)
     {
         handle.Complete();
-        if (!sInitialized) return;
+        if (!sInitialized)
+        {
+            return;
+        }
 
         CompletePending();
     }

Basis/Packages/com.basis.framework/Networking/BasisNetworkLifeCycle.cs

@@ -40,8 +40,6 @@ public static void Initalize(BasisNetworkManagement Management)
 
         Management.transform.SetPositionAndRotation(Vector3.zero, Quaternion.identity);
         BasisNetworkManagement.OnEnableInstanceCreate?.Invoke();
-
-        BasisNetworkPlayers.PublishReceiversSnapshot();
         BasisNetworkManagement.NetworkRunning = true;
     }
     public static bool GoingThroughReboot = false;

Basis/Packages/com.basis.framework/Networking/BasisNetworkManagement.cs

@@ -5,6 +5,7 @@
 using Basis.Scripts.Profiler;
 using System;
 using System.Collections.Concurrent;
+using System.Linq;
 using System.Threading;
 using Unity.Jobs;
 using UnityEngine;
@@ -151,8 +152,8 @@ public static bool IsMainThread()
         public static float Beta = 2;
      //   [Header("DerivativeCutoff This controls how noisy the speed estimate itself is.Before the filter adapts, it estimates velocity:")]
         public static float DerivativeCutoff = 2;
-        public static BasisNetworkReceiver[] snapshot;
-        public static int Length;
+        public static BasisNetworkReceiver[] ReceiverArray;
+        public static int ReceiverArrayLength;
         /// <summary>
         /// Simulates network computation step (state updates, bone drivers, profiler update).
         /// </summary>
@@ -163,13 +164,16 @@ public static void SimulateNetworkCompute(float UnscaledDeltaTime)
             {
                 return;
             }
-
-            snapshot = BasisNetworkPlayers.ReceiversSnapshot;
+            if (ReceiverArrayLength > BasisRemoteNetworkDriver.FixedCapacity)
+            {
+                BasisDebug.LogError("To Many Players out of array Data!");
+                return;
+            }
             BoneJobSystem = RemoteBoneJobSystem.Schedule(); // will always be a frame behind
-            Length = snapshot.Length;
-            for (int Index = 0; Index < Length; Index++)
+            float step = Mathf.Max(UnscaledDeltaTime, 0f);
+            for (int Index = 0; Index < ReceiverArrayLength; Index++)
             {
-                snapshot[Index].Compute(UnscaledDeltaTime);
+                ReceiverArray[Index].Compute(step);
             }
             BasisRemoteNetworkDriver.Compute();
             BasisNetworkProfiler.Update();
@@ -186,6 +190,11 @@ public static void SimulateNetworkCompute(float UnscaledDeltaTime)
                 }
             }
         }
+        public static void UpdatePlayerArray()
+        {
+            ReceiverArray = BasisNetworkPlayers.RemotePlayers.Count == 0 ? Array.Empty<BasisNetworkReceiver>() : BasisNetworkPlayers.RemotePlayers.Values.ToArray();
+            ReceiverArrayLength = ReceiverArray.Length;
+        }
         /// <summary>
         /// Applies networked state changes to receivers.
         /// </summary>
@@ -195,11 +204,14 @@ public static void SimulateNetworkApply()
             {
                 return;
             }
-
+            if (ReceiverArrayLength > BasisRemoteNetworkDriver.FixedCapacity)
+            {
+                return;
+            }
             BasisRemoteNetworkDriver.Apply();
-            for (int Index = 0; Index < Length; Index++)
+            for (int Index = 0; Index < ReceiverArrayLength; Index++)
             {
-                snapshot[Index].Apply();
+                ReceiverArray[Index].Apply();
             }
         }
 

Basis/Packages/com.basis.framework/Networking/BasisNetworkPlayers.cs

@@ -20,11 +20,6 @@ public static class BasisNetworkPlayers
         public static readonly List<ushort> JoiningPlayers = new(); // used as a set
         public static readonly ConcurrentDictionary<string, ushort> OwnershipPairing = new();
 
-        // Receiver snapshot for multi-threaded compute/apply phases.
-        private static volatile BasisNetworkReceiver[] _receiversSnapshot = Array.Empty<BasisNetworkReceiver>();
-        public static BasisNetworkReceiver[] ReceiversSnapshot => _receiversSnapshot;
-        public static int ReceiverCount => _receiversSnapshot.Length;
-
         // --- Lifecycle helpers ---------------------------------------------
         public static void ClearAllRegistries()
         {
@@ -36,11 +31,6 @@ public static void ClearAllRegistries()
             RemotePlayers.Clear();
             JoiningPlayers.Clear();
             OwnershipPairing.Clear();
-            PublishReceiversSnapshot();
-        }
-        public static void PublishReceiversSnapshot()
-        {
-            _receiversSnapshot = RemotePlayers.Count == 0 ? Array.Empty<BasisNetworkReceiver>() : RemotePlayers.Values.ToArray();
         }
 
         // --- Registry APIs --------------------------------------------------
@@ -84,8 +74,6 @@ public static bool AddPlayer(BasisNetworkPlayer netPlayer)
                     BasisDebug.LogError($"Failed to add remote player {netPlayer.playerId} to RemotePlayers. Rolled back from Players.");
                     return false;
                 }
-
-                PublishReceiversSnapshot();
             }
 
             return true;
@@ -102,7 +90,6 @@ public static bool RemovePlayer(ushort netId, out BasisNetworkPlayer player)
 
             Players.TryRemove(netId, out player);
             RemotePlayers.TryRemove(netId, out _);
-            PublishReceiversSnapshot();
             return true;
         }
 

Basis/Packages/com.basis.framework/Networking/BasisRemoteFaceManagement.cs

@@ -49,18 +49,14 @@ public static class BasisRemoteFaceManagement
     public const float LookSpeed = 15;
 
     public static JobHandle handle;
-    public static BasisNetworkReceiver[] snapshot;
-    public static  int count;
     public static void Simulate(double t,float dt)
     {
-        snapshot = BasisNetworkPlayers.ReceiversSnapshot;
-        count = BasisNetworkPlayers.ReceiverCount;
-        if (count <= 0)
+        if (BasisNetworkManagement.ReceiverArrayLength <= 0)
         {
             return;
         }
 
-        EnsureArrays(count, t, snapshot);
+        EnsureArrays(BasisNetworkManagement.ReceiverArrayLength, t, BasisNetworkManagement.ReceiverArray);
 
         // No per-frame main-thread copy into a NativeArray.
         // The job will update eyeOut in-place (as state), and Apply() will write eyeOut back to receivers.
@@ -90,18 +86,18 @@ public static void Simulate(double t,float dt)
             blinkOut = blinkOut,
         };
 
-        handle = job.Schedule(count, BatchSize);
+        handle = job.Schedule(BasisNetworkManagement.ReceiverArrayLength, BatchSize);
     }
 
     public static void Apply()
     {
-        if (count <= 0) return;
+        if (BasisNetworkManagement.ReceiverArrayLength <= 0) return;
 
         handle.Complete();
 
-        for (int Index = 0; Index < count; Index++)
+        for (int Index = 0; Index < BasisNetworkManagement.ReceiverArrayLength; Index++)
         {
-            var receiver = snapshot[Index];
+            var receiver = BasisNetworkManagement.ReceiverArray[Index];
             var remote = receiver.RemotePlayer;
             var Face = remote.RemoteFaceDriver;