Skip to content

Commit df44733

Browse files
committed
timing fixes
1 parent 310a5eb commit df44733

File tree

6 files changed

+30
-1452
lines changed

6 files changed

+30
-1452
lines changed

Basis/Assets/Basis/Settings/Quality Settiings/Modified - Desktop.asset

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ MonoBehaviour:
2626
m_SupportsHDR: 1
2727
m_HDRColorBufferPrecision: 1
2828
m_MSAA: 2
29-
m_RenderScale: 1.000077
29+
m_RenderScale: 0.7622722
3030
m_UpscalingFilter: 0
3131
m_FsrOverrideSharpness: 0
3232
m_FsrSharpness: 0.92
@@ -43,11 +43,11 @@ MonoBehaviour:
4343
m_ProbeVolumeSHBands: 1
4444
m_MainLightRenderingMode: 1
4545
m_MainLightShadowsSupported: 1
46-
m_MainLightShadowmapResolution: 4096
46+
m_MainLightShadowmapResolution: 8192
4747
m_AdditionalLightsRenderingMode: 1
4848
m_AdditionalLightsPerObjectLimit: 8
4949
m_AdditionalLightShadowsSupported: 1
50-
m_AdditionalLightsShadowmapResolution: 4096
50+
m_AdditionalLightsShadowmapResolution: 8192
5151
m_AdditionalLightsShadowResolutionTierLow: 128
5252
m_AdditionalLightsShadowResolutionTierMedium: 256
5353
m_AdditionalLightsShadowResolutionTierHigh: 512

Basis/Packages/com.basis.framework/Networking/BasisNetworkManagement.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ public static void SimulateNetworkCompute(double UnscaledDeltaTime)
168168
BoneJobSystem = RemoteBoneJobSystem.Schedule(); // will always be a frame behind
169169

170170
UnscaledDeltaTime = Math.Max(UnscaledDeltaTime, 0f);
171-
if (math.isnan(UnscaledDeltaTime) || math.isfinite(UnscaledDeltaTime))
171+
if (!math.isfinite(UnscaledDeltaTime))
172172
{
173173
UnscaledDeltaTime = 0;
174174
}

Basis/Packages/com.basis.framework/Networking/NetworkedAvatar/BasisNetworkAvatarDecompressor.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
using Basis.Scripts.Networking.Receivers;
44
using System;
55
using Unity.Mathematics;
6+
using UnityEngine.UIElements;
67
using static SerializableBasis;
78
namespace Basis.Scripts.Networking.NetworkedAvatar
89
{
@@ -71,25 +72,24 @@ private static bool CreateAvatarBuffer(byte[] data, ref int offset, double secon
7172
BasisOrderedDataSet.DecompressAvatarMuscles_BitPacked(data, ref BasisAvatarBuffer.Muscles, ref offset);
7273
BasisAvatarBuffer.Scale = MuscleDecompress(BasisUnityBitPackerExtensionsUnsafe.ReadUShort(ref data, ref offset), MinimumValueSupported, MaximumValueSupported);
7374
// Reject NaN, Infinity, zero, negative, or insane values
74-
if (!double.IsFinite(secondsInterval) || secondsInterval <= 0.0 || secondsInterval > 1.0)
75+
if (!math.isfinite(secondsInterval) || secondsInterval <= 0.0 || secondsInterval > 1.0)
7576
{
76-
BasisDebug.LogError($"SecondsInterval was {secondsInterval}, correcting to 0.0166667", BasisDebug.LogTag.Remote);
77+
BasisDebug.LogError($"SecondsInterval was {secondsInterval}, rejecting", BasisDebug.LogTag.Remote);
7778
BasisAvatarBufferPool.Release(BasisAvatarBuffer);
7879
return false;
7980
}
8081
BasisAvatarBuffer.SecondsInterval = secondsInterval;
8182

82-
// 2) Sanitize transforms to avoid NaNs propagating into the driver.
8383
if (!math.all(math.isfinite(BasisAvatarBuffer.Position)))
8484
{
85-
BasisDebug.LogError($"Infinite Position Detected setting to default", BasisDebug.LogTag.Remote);
85+
BasisDebug.LogError("Non-finite Position detected, rejecting", BasisDebug.LogTag.Remote);
8686
BasisAvatarBufferPool.Release(BasisAvatarBuffer);
8787
return false;
8888
}
8989

9090
if (!math.all(math.isfinite(BasisAvatarBuffer.Scale)))
9191
{
92-
BasisDebug.LogError($"Infinite Scale Detected setting to default", BasisDebug.LogTag.Remote);
92+
BasisDebug.LogError("Non-finite Scale detected, rejecting", BasisDebug.LogTag.Remote);
9393
BasisAvatarBufferPool.Release(BasisAvatarBuffer);
9494
return false;
9595
}

Basis/Packages/com.basis.framework/Networking/Recievers/BasisNetworkReceiver.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -175,14 +175,14 @@ public void Compute(double unscaledDeltaTime)
175175
first.SecondsInterval > 0 ? first.SecondsInterval :
176176
(1.0 / 60.0);
177177

178-
if (!double.IsFinite(windowDuration) || windowDuration <= 1e-6)
178+
if (!math.isfinite(windowDuration) || windowDuration <= 1e-6)
179179
{
180180
windowDuration = 1e-3;
181181
}
182182
float rate = 1f + CatchupGain * (StagedCount - TargetJitterDepth);
183183
rate = Mathf.Clamp(rate, MinPlaybackRate, MaxPlaybackRate);
184184
interpolationTime += ((double)unscaledDeltaTime / windowDuration * (double)rate);
185-
if (math.isnan(interpolationTime) || math.isfinite(interpolationTime))
185+
if (!math.isfinite(interpolationTime))
186186
{
187187
interpolationTime = 1;
188188
}

0 commit comments

Comments
 (0)