Merge pull request #258 from regnare/master

feat: Make backup mode configurable (support for HA clusters)

Author: BassT23

update.conf

@@ -98,6 +98,13 @@ BACKUP="false"
 # On some setups, snapshot is not possible if mount points are used
 # If you want to make a backup instead of a snapshot, set this to true
 BACKUP_LXC_MP="true"
+# Backup Mode
+# Choose the mode for the backup: "stop", "suspend", or "snapshot".
+# "stop" = Stops the VM/CT (Highest consistency, causes downtime). NOT compatible with HA.
+# "suspend" = Suspends the VM/CT (Good consistency, minimal downtime). Compatible with HA.
+# "snapshot" = Live backup (Lowest consistency, no downtime). Requires supported storage (e.g., LVM-Thin, ZFS, Ceph).
+# Default: stop
+BACKUP_MODE="stop"
 
 ┌──────────────────────────────────────────────┐
 │                Extra Updates                 │
@@ -141,4 +148,4 @@ CHECK_RUNNING_VM="true"
 └──────────────────────────────────────────────┘
 
 ONLY_UPDATE_CHECK="check-only"             # `check-only` is an example Tag
-EXCLUDE_UPDATE_CHECK="check-exclude"       # `check-exclude` is an example Tag
+EXCLUDE_UPDATE_CHECK="check-exclude"       # `check-exclude` is an example Tag

update.sh

@@ -417,6 +417,7 @@ READ_CONFIG () {
   KEEP_SNAPSHOT=$(awk -F'"' '/^KEEP_SNAPSHOT/ {print $2}' "$CONFIG_FILE")
   BACKUP=$(awk -F'"' '/^BACKUP=/ {print $2}' "$CONFIG_FILE")
   BACKUP_LXC_MP=$(awk -F'"' '/^BACKUP_LXC_MP=/ {print $2}' "$CONFIG_FILE")
+  BACKUP_MODE=$(awk -F'"' '/^BACKUP_MODE=/ {print $2}' "$CONFIG_FILE")
   LXC_START_DELAY=$(awk -F'"' '/^LXC_START_DELAY=/ {print $2}' "$CONFIG_FILE")
   VM_START_DELAY=$(awk -F'"' '/^VM_START_DELAY=/ {print $2}' "$CONFIG_FILE")
   EXTRA_GLOBAL=$(awk -F'"' '/^EXTRA_GLOBAL=/ {print $2}' "$CONFIG_FILE")
@@ -453,8 +454,10 @@ CONTAINER_BACKUP () {
       fi
     fi
     if [[ "$BACKUP" == true ]]; then
+      # Use BACKUP_MODE from config, default to 'stop' if not set
+      MODE=${BACKUP_MODE:-stop}
       echo -e "💾${OR:-} Create a backup for LXC (this will take some time - please wait)${CL:-}"
-      vzdump "$CONTAINER" --mode stop --notes-template "{{guestname}} - Ultimate-Updater" --storage "$(pvesm status -content backup | grep -m 1 -v ^Name | cut -d ' ' -f1)" --compress zstd
+      vzdump "$CONTAINER" --mode "$MODE" --notes-template "{{guestname}} - Ultimate-Updater" --storage "$(pvesm status -content backup | grep -m 1 -v ^Name | cut -d ' ' -f1)" --compress zstd
       echo -e "✅${GN:-} Backup created${CL:-}\n"
       if [[ $BACKUP_RESET == true ]]; then
         BACKUP=$(awk -F'"' '/^BACKUP=/ {print $2}' "$CONFIG_FILE")
@@ -481,8 +484,10 @@ VM_BACKUP () {
       fi
     fi
     if [[ "$BACKUP" == true ]]; then
+      # Use BACKUP_MODE from config, default to 'stop' if not set
+      MODE=${BACKUP_MODE:-stop}
       echo -e "💾${OR:-} Create a backup for the VM (this will take some time - please wait)${CL:-}"
-      vzdump "$VM" --mode stop --storage "$(pvesm status -content backup | grep -m 1 -v ^Name | cut -d ' ' -f1)" --compress zstd
+      vzdump "$VM" --mode "$MODE" --storage "$(pvesm status -content backup | grep -m 1 -v ^Name | cut -d ' ' -f1)" --compress zstd
       echo -e "✅${GN:-} Backup created${CL:-}"
     fi
   else
@@ -1343,4 +1348,4 @@ if [[ "$COMMAND" != true ]]; then
   fi
 fi
 
-exit 0
+exit 0