Merge pull request #178 from BassT23/beta

v4.3 release

Author: BassT23

.github/ISSUE_TEMPLATE/bug_report.md

@@ -0,0 +1,34 @@
+---
+name: Bug report
+about: Create a report to help us improve
+title: ''
+labels: bug
+assignees: ''
+
+---
+
+**Describe the bug**
+A clear and concise description of what the bug is.
+
+**To Reproduce**
+Steps to reproduce the behavior:
+1. Go to '...'
+2. Click on '....'
+3. Scroll down to '....'
+4. See error
+
+**Expected behavior**
+A clear and concise description of what you expected to happen.
+
+**Screenshots**
+If applicable, add screenshots to help explain your problem.
+
+**VM/LXC (please complete the following information):**
+ - OS: [e.g. iOS]
+ - Version [e.g. 22]
+
+**Used Version
+output of ```update status```
+
+**Additional context**
+Add any other context about the problem here.

.github/ISSUE_TEMPLATE/feature_request.md

@@ -0,0 +1,20 @@
+---
+name: Feature request
+about: Suggest an idea for this project
+title: ''
+labels: feature-request
+assignees: ''
+
+---
+
+**Is your feature request related to a problem? Please describe.**
+A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
+
+**Describe the solution you'd like**
+A clear and concise description of what you want to happen.
+
+**Describe alternatives you've considered**
+A clear and concise description of any alternative solutions or features you've considered.
+
+**Additional context**
+Add any other context or screenshots about the feature request here.

CODE_OF_CONDUCT.md

@@ -0,0 +1,128 @@
+# Contributor Covenant Code of Conduct
+
+## Our Pledge
+
+We as members, contributors, and leaders pledge to make participation in our
+community a harassment-free experience for everyone, regardless of age, body
+size, visible or invisible disability, ethnicity, sex characteristics, gender
+identity and expression, level of experience, education, socio-economic status,
+nationality, personal appearance, race, religion, or sexual identity
+and orientation.
+
+We pledge to act and interact in ways that contribute to an open, welcoming,
+diverse, inclusive, and healthy community.
+
+## Our Standards
+
+Examples of behavior that contributes to a positive environment for our
+community include:
+
+* Demonstrating empathy and kindness toward other people
+* Being respectful of differing opinions, viewpoints, and experiences
+* Giving and gracefully accepting constructive feedback
+* Accepting responsibility and apologizing to those affected by our mistakes,
+  and learning from the experience
+* Focusing on what is best not just for us as individuals, but for the
+  overall community
+
+Examples of unacceptable behavior include:
+
+* The use of sexualized language or imagery, and sexual attention or
+  advances of any kind
+* Trolling, insulting or derogatory comments, and personal or political attacks
+* Public or private harassment
+* Publishing others' private information, such as a physical or email
+  address, without their explicit permission
+* Other conduct which could reasonably be considered inappropriate in a
+  professional setting
+
+## Enforcement Responsibilities
+
+Community leaders are responsible for clarifying and enforcing our standards of
+acceptable behavior and will take appropriate and fair corrective action in
+response to any behavior that they deem inappropriate, threatening, offensive,
+or harmful.
+
+Community leaders have the right and responsibility to remove, edit, or reject
+comments, commits, code, wiki edits, issues, and other contributions that are
+not aligned to this Code of Conduct, and will communicate reasons for moderation
+decisions when appropriate.
+
+## Scope
+
+This Code of Conduct applies within all community spaces, and also applies when
+an individual is officially representing the community in public spaces.
+Examples of representing our community include using an official e-mail address,
+posting via an official social media account, or acting as an appointed
+representative at an online or offline event.
+
+## Enforcement
+
+Instances of abusive, harassing, or otherwise unacceptable behavior may be
+reported to the community leaders responsible for enforcement at
+Discord.
+All complaints will be reviewed and investigated promptly and fairly.
+
+All community leaders are obligated to respect the privacy and security of the
+reporter of any incident.
+
+## Enforcement Guidelines
+
+Community leaders will follow these Community Impact Guidelines in determining
+the consequences for any action they deem in violation of this Code of Conduct:
+
+### 1. Correction
+
+**Community Impact**: Use of inappropriate language or other behavior deemed
+unprofessional or unwelcome in the community.
+
+**Consequence**: A private, written warning from community leaders, providing
+clarity around the nature of the violation and an explanation of why the
+behavior was inappropriate. A public apology may be requested.
+
+### 2. Warning
+
+**Community Impact**: A violation through a single incident or series
+of actions.
+
+**Consequence**: A warning with consequences for continued behavior. No
+interaction with the people involved, including unsolicited interaction with
+those enforcing the Code of Conduct, for a specified period of time. This
+includes avoiding interactions in community spaces as well as external channels
+like social media. Violating these terms may lead to a temporary or
+permanent ban.
+
+### 3. Temporary Ban
+
+**Community Impact**: A serious violation of community standards, including
+sustained inappropriate behavior.
+
+**Consequence**: A temporary ban from any sort of interaction or public
+communication with the community for a specified period of time. No public or
+private interaction with the people involved, including unsolicited interaction
+with those enforcing the Code of Conduct, is allowed during this period.
+Violating these terms may lead to a permanent ban.
+
+### 4. Permanent Ban
+
+**Community Impact**: Demonstrating a pattern of violation of community
+standards, including sustained inappropriate behavior,  harassment of an
+individual, or aggression toward or disparagement of classes of individuals.
+
+**Consequence**: A permanent ban from any sort of public interaction within
+the community.
+
+## Attribution
+
+This Code of Conduct is adapted from the [Contributor Covenant][homepage],
+version 2.0, available at
+https://www.contributor-covenant.org/version/2/0/code_of_conduct.html.
+
+Community Impact Guidelines were inspired by [Mozilla's code of conduct
+enforcement ladder](https://github.com/mozilla/diversity).
+
+[homepage]: https://www.contributor-covenant.org
+
+For answers to common questions about this code of conduct, see the FAQ at
+https://www.contributor-covenant.org/faq. Translations are available at
+https://www.contributor-covenant.org/translations.

README.md

@@ -28,30 +28,37 @@ I am no member of the Proxmox Server Solutions GmbH. This is not an official pro
 
 </div>
 
+### What does the script do:
+- The script makes system updates with apt/dnf/pacman/apk or yum on all nodes/LXCs and VMs (if VMs prepared for that)
+- Make a snapshot before update (if your storage support it - [look here](https://pve.proxmox.com/wiki/Storage)). If not supported, you can choose to make a real backup, but this must be enabled in `update.conf` by user (take long time!)
+- After all, the updater makes a little cleaning (like `apt autoremove`) 
+- If the script detects "extra" installations, it could update this also. Look in config file, for that.
+
 ### Features:
 - Update Proxmox VE (the host / all cluster nodes / all included LXCs and VMs)
 - Snapshot / Backup support (for Snapshot, your system must prepared for it)
 - Normal run is "Interactive" / Headless Mode can be run with `update -s`
 - Logging - location can be change in config file
 - Exit tracking, so you can send additional commands for finish or failure (edit files in `/etc/ultimate-updater/exit`)
 - [Config file](https://github.com/BassT23/Proxmox/tree/master#config-file)
+- Trim filesystem on ext4 nodes - 
 
 Info can be found with `update -h`
 
 Changelog: [here](https://github.com/BassT23/Proxmox/blob/master/change.log)
 
-### What does the script do:
-- The script makes system updates with apt/dnf/pacman/apk or yum on all nodes/LXCs and VMs (if VMs prepared for that)
-- Make a snapshot before update (if your storage support it - [look here](https://pve.proxmox.com/wiki/Storage)). If not supported, you can choose to make a real backup, but this must be enabled in `update.conf` by user (take long time!)
-- After all, the updater makes a little cleaning (like `apt autoremove`) 
-- If the script detects "extra" installations, it could update this also. Look in config file, for that.
-
 ## 
 # Installation:
 In Proxmox GUI Host Shell or as root on proxmox host terminal:
 ```
 bash <(curl -s https://raw.githubusercontent.com/BassT23/Proxmox/master/install.sh)
 ```
+
+# Usage:
+ - If you want to run the updater globally for all nodes/lxc/vm only run `update`
+ - If you want to update only one specific lxc/vm run `update <ID>`
+
+##
 ## Cluster-Mode preparation:
 **! For Cluster Installation, you only need to install on one Host !**
 

SECURITY.md

@@ -0,0 +1,13 @@
+# Security Policy
+
+## Supported Versions
+
+
+| Version | Supported          |
+| ------- | ------------------ |
+| 4.x     | :white_check_mark: |
+| < 4.0   | :x:                |
+
+## Reporting a Vulnerability
+
+Issues can be reported [here](https://github.com/BassT23/Proxmox/issues) or per Discord

VMs/example

@@ -1 +1,11 @@
+############################################################
+# - This file must be in the node who start the script.    #
+# - If user is not root please look here:                  #
+#   https://github.com/BassT23/Proxmox/blob/develop/ssh.md #
+############################################################
+
 IP="111.111.111.111"
+USER="root"
+SSH_VM_PORT="22"
+# Time in secounds
+SSH_START_DELAY_TIME="45"

change.log

@@ -1,6 +1,28 @@
 Changelog:
 ==========
 
+**v4.3** (23.02.2025)
+- add freebsd VM (QEMU and SSH Connection)
+- add non root user update in VMs
+- add autoclean for debian based systems
+- add filesystem trim for ext4 systems
+- add curl for internet check
+- add env settings for arch in config file
+- add kernel kleaning (disabled by default in config file)
+- fix run for only one LXC/VM with `update <ID>`
+- fix ioBroker Upgrade
+- fix arch upgrade
+- fix START/STOP/WAITING for stopped VMs
+- fix compatibility with "old" ssh connection
+- fix IP output by nodes
+- fix fedora autoremove
+- fix missing kernel infos
+- fix template detection
+- fix internet check
+- modify config file - checker settings now on the buttom
+- modify version check - check now all branches
+- code cleaning
+
 **v4.2** (01.12.2024)
 - fix VM Template error
 - fix Unifi-Controller Container

check-updates.sh

@@ -4,7 +4,9 @@
 # Check Updates #
 #################
 
+# shellcheck disable=SC1017
 # shellcheck disable=SC2034
+
 VERSION="1.5"
 
 #Variable / Function
@@ -247,9 +249,14 @@ CHECK_VM () {
     if ! (ssh "$IP" exit) >/dev/null 2>&1; then
       CHECK_VM_QEMU
     else
-      OS_BASE=$(qm config "$VM" | grep ostype)
+      OS_BASE=$(qm config "$VM" | grep ostype || true)
       if [[ "$OS_BASE" =~ l2 ]]; then
-        OS=$(ssh "$IP" hostnamectl | grep System)
+        KERNEL=$(qm guest cmd "$VM" get-osinfo | grep kernel-version || true)
+        OS=$(ssh "$IP" hostnamectl | grep System || true)
+#        if [[ "$KERNEL" =~ FreeBSD ]]; then
+#          ssh -t -q -p "$SSH_VM_PORT" -tt "$USER"@"$IP" pkg update
+#          return
+#        fi
         if [[ "$OS" =~ Ubuntu ]] || [[ "$OS" =~ Debian ]] || [[ "$OS" =~ Devuan ]]; then
           ssh "$IP" "apt-get update" >/dev/null 2>&1
           SECURITY_APT_UPDATES=$(ssh "$IP" "apt-get -s upgrade | grep -ci ^inst.*security")
@@ -297,7 +304,12 @@ CHECK_VM () {
 
 CHECK_VM_QEMU () {
   if qm guest exec "$VM" test >/dev/null 2>&1; then
-    OS=$(qm guest cmd "$VM" get-osinfo | grep name)
+    KERNEL=$(qm guest cmd "$VM" get-osinfo | grep kernel-version || true)
+    OS=$(qm guest cmd "$VM" get-osinfo | grep name || true)
+#    if [[ "$KERNEL" =~ FreeBSD ]]; then
+#      qm guest exec "$VM" -- tcsh -c "pkg update"
+#      return
+#    fi
     if [[ "$OS" =~ Ubuntu ]] || [[ "$OS" =~ Debian ]] || [[ "$OS" =~ Devuan ]]; then
       qm guest exec "$VM" -- bash -c "apt-get update" >/dev/null 2>&1
       SECURITY_APT_UPDATES=$(qm guest exec "$VM" -- bash -c "apt-get -s upgrade | grep -ci ^inst.*security | tr -d '\n'" | tail -n +4 | head -n -1 | cut -c 18- | rev | cut -c 2- | rev)

install.sh

@@ -4,8 +4,10 @@
 # Install #
 ###########
 
+# shellcheck disable=SC1017
 # shellcheck disable=SC2034
-VERSION="1.8"
+
+VERSION="1.8.3"
 
 # Branch
 BRANCH="master"
@@ -245,6 +247,7 @@ UPDATE () {
     # Copy files
     mv "$TEMP_FILES"/update.sh $LOCAL_FILES/update.sh
     chmod 750 $LOCAL_FILES/update.sh
+    mv "$TEMP_FILES"/VMs/example $LOCAL_FILES/VMs/example
     if [[ -f /etc/update-motd.d/01-welcome-screen ]]; then
       mv "$TEMP_FILES"/welcome-screen.sh /etc/update-motd.d/01-welcome-screen
       chmod +x /etc/update-motd.d/01-welcome-screen
@@ -262,6 +265,8 @@ UPDATE () {
     rm -rf "$TEMP_FILES"/change.log || true
     rm -rf "$TEMP_FILES"/install.sh || true
     rm -rf "$TEMP_FILES"/ssh.md || true
+    rm -rf "$TEMP_FILES"/CODE_OF_CONDUCT.md || true
+    rm -rf "$TEMP_FILES"/SECURITY.md || true
     chmod -R +x "$TEMP_FILES"/exit/*.sh
     cd "$TEMP_FILES"
     FILES="*.* **/*.*"

ssh.md

@@ -29,15 +29,36 @@ PermitRootLogin yes
 `sudo service sshd restart`
 
 
-### IN HOST:
-- create one file per VM in `/etc/ultimate-updater/VMs/<ID>` with content:
+### IN HOST who hosted the VM:
+- Copy ssh key to VM:
+`ssh-copy-id -i /root/.ssh/id_rsa.pub root@<VM-IP>`
+
+- or, if used user is not root:
+`ssh-copy-id -i /root/.ssh/id_rsa.pub <user>@<VM-IP>`
 
-`IP="111.111.111.111"`   # use the IP from the VM!
 
+### IN HOST where ultimate-updater start:
+- create one file per VM in `/etc/ultimate-updater/VMs/<ID>` with content:
+
+```
+IP="111.111.111.111"   # use the IP from the VM!
+USER="root"
+SSH_VM_PORT="22"
+SSH_START_DELAY_TIME="45"
+```
 (IP can be found in VM with command: `hostname -I`)
 
-- Copy ssh key to VM:
 
-You need to make this step on the Host, who hosted the VM. If pve2 host VMxyz, you need to make the copy from pve2, not from the pve, on which you run the script ;)
+## If user is NOT root, you need to prepare the user, to run admin commands - like `apt` - but user MUST be part of group `sudo`
 
-`ssh-copy-id -i /root/.ssh/id_rsa.pub root@<VM-IP>`
+Example for Ubuntu/Debian - with sudo (change in VM):
+
+- `sudo visudo`
+- add this to file:
+
+`%sudo ALL=(root) NOPASSWD: /usr/bin/apt-get update, /usr/bin/apt-get upgrade -y, /usr/bin/apt-get --purge autoremove -y, /usr/bin/apt-get autoclean -y`
+- save and exit file
+
+Sources:
+- easy, but unsafe -> look [here](https://askubuntu.com/questions/74054/run-apt-get-without-sudo)
+- for more safety -> look [here](https://stackoverflow.com/questions/73397309/how-do-i-enable-passwordless-sudo-for-all-options-for-a-command):