switch default option for general_ad to true

Author: xavierr

src/setup/matlab_model_setup.jl

@@ -294,15 +294,15 @@ end
 function setup_submodels(inputparams::MatlabInputParams; 
                          use_groups::Bool = false,
                          use_p2d::Bool    = true,
-                         general_ad::Bool = false,
+                         general_ad::Bool = true,
                          kwarg...)
 
     include_cc = include_current_collectors(inputparams)
 
     function setup_component(obj::Dict, 
-                             sys, 
-                             bcfaces = nothing,
-                             general_ad::Bool = false)
+                             sys,
+                             general_ad::Bool,
+                             bcfaces = nothing)
 
         domain = exported_model_to_domain(obj, bcfaces = bcfaces, general_ad=general_ad)
         G = MRSTWrapMesh(obj["G"])
@@ -362,9 +362,9 @@ function setup_submodels(inputparams::MatlabInputParams;
 
         if  !include_cc && name == :NeAm
             bcfaces  = convert_to_int_vector(inputparams_co["externalCouplingTerm"]["couplingfaces"])
-            model_am = setup_component(inputparams_co, sys_am, bcfaces, general_ad)
+            model_am = setup_component(inputparams_co, sys_am, general_ad, bcfaces)
         else
-            model_am = setup_component(inputparams_co, sys_am, nothing, general_ad)
+            model_am = setup_component(inputparams_co, sys_am, general_ad, nothing)
         end
 
         return model_am
@@ -386,7 +386,7 @@ function setup_submodels(inputparams::MatlabInputParams;
 
         bcfaces = convert_to_int_vector(inputparams_necc["externalCouplingTerm"]["couplingfaces"])
 
-        model_necc =  setup_component(inputparams_necc, sys_necc, bcfaces, general_ad)
+        model_necc =  setup_component(inputparams_necc, sys_necc, general_ad, bcfaces)
 
 
     end
@@ -422,7 +422,7 @@ function setup_submodels(inputparams::MatlabInputParams;
 
     elyte = Electrolyte(params)
     model_elyte = setup_component(inputparams["Electrolyte"],
-                                  elyte, nothing, general_ad)
+                                  elyte, general_ad, nothing)
 
     ##############
     # Setup PeAm #
@@ -444,7 +444,7 @@ function setup_submodels(inputparams::MatlabInputParams;
         sys_pecc = CurrentCollector(pecc_params)
 
 
-        model_pecc =  setup_component(inputparams_pecc, sys_pecc, nothing, general_ad)
+        model_pecc =  setup_component(inputparams_pecc, sys_pecc, general_ad, nothing)
 
     end
 
@@ -723,7 +723,7 @@ function setup_initial_state(inputparams::MatlabInputParams,
 end
 
 function exported_model_to_domain(exported; bcfaces = nothing, 
-                                  general_ad = false)
+                                  general_ad = true)
 
     """ Returns domain"""
 

src/setup/model_setup.jl

@@ -72,7 +72,7 @@ function setup_simulation(inputparams::AbstractInputParams;
                           extra_timing::Bool                = false,
                           max_step::Union{Integer, Nothing} = nothing,
                           linear_solver::Symbol             = :direct,
-                          general_ad::Bool                  = false,
+                          general_ad::Bool                  = true,
                           use_groups::Bool                  = false,
                           model_kwargs::NamedTuple          = NamedTuple(),
                           config_kwargs::NamedTuple         = NamedTuple())
@@ -119,7 +119,7 @@ end
 function setup_model(inputparams::AbstractInputParams;
                      use_p2d::Bool    = true,
                      use_groups::Bool = false,
-                     general_ad = false,
+                     general_ad       = true,
                      kwargs...)
 
     # setup the submodels and also return a coupling structure which is used to setup later the cross-terms
@@ -145,7 +145,7 @@ end
 
 function setup_submodels(inputparams::InputParams; 
                          use_groups::Bool = false, 
-                         general_ad::Bool = false,
+                         general_ad::Bool = true,
                          use_p2d = true,
                          kwargs...)
 
@@ -273,7 +273,8 @@ function setup_submodels(inputparams::InputParams;
         model_am = setup_component(grid,
                                    sys_am;
                                    general_ad = general_ad,
-                                   dirichletBoundary = boundary,kwargs...)
+                                   dirichletBoundary = boundary,
+                                   kwargs...)
 
         return model_am
 
@@ -498,7 +499,7 @@ end
 
 function setup_component(grid::Jutul.FiniteVolumeMesh,
                          sys;
-                         general_ad::Bool=false,
+                         general_ad::Bool=true,
                          dirichletBoundary = nothing,
                          kwargs...)