Fix bug in warmup scheduling bgmCompare

MaartenMarsman · MaartenMarsman · commit f0a9288ed12f · 2025-10-03T09:43:41.000+02:00
Updated description and news
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -2,7 +2,7 @@ Package: bgms
 Type: Package
 Title: Bayesian Analysis of Networks of Binary and/or Ordinal Variables
 Version: 0.1.6.1
-Date: 2025-09-26
+Date: 2025-10-03
 Authors@R: c(
     person("Maarten", "Marsman", , "m.marsman@uva.nl", role = c("aut", "cre"),
            comment = c(ORCID = "0000-0001-5309-7502")),
diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,16 @@
+# bgms 0.1.6.1
+
+## Other changes
+
+* added extractor function for joint SBM output
+* cleaned up documentation, and c++ files
+* changed length of warmup phase I in warmup scheduler HMC / NUTS (15% → 7.5%)
+
+## Bug fixes
+
+* Fixed a problem with warmup scheduling for adaptive-metropolis in bgmCompare()
+* Fixed stability problems with parallel sampling for bgm()
+
 # bgms 0.1.6.0
 
 ## New features
diff --git a/src/bgmCompare_sampler.cpp b/src/bgmCompare_sampler.cpp
@@ -1652,7 +1652,7 @@ SamplerOutput run_gibbs_sampler_bgmCompare(
   }
 
   // --- Warmup scheduling + adaptation controller
-  WarmupSchedule warmup_schedule(warmup, difference_selection, true);
+  WarmupSchedule warmup_schedule(warmup, difference_selection, (update_method != adaptive_metropolis));
 
   HMCAdaptationController hmc_adapt(
       (num_main + num_pair) * num_groups, initial_step_size, target_accept,

Original file line number	Diff line number	Diff line change
`@@ -1652,7 +1652,7 @@ SamplerOutput run_gibbs_sampler_bgmCompare(`
`1652`	`1652`	`}`
`1653`	`1653`
`1654`	`1654`	`// --- Warmup scheduling + adaptation controller`
`1655`		`- WarmupSchedule warmup_schedule(warmup, difference_selection, true);`
	`1655`	`+ WarmupSchedule warmup_schedule(warmup, difference_selection, (update_method != adaptive_metropolis));`
`1656`	`1656`
`1657`	`1657`	`HMCAdaptationController hmc_adapt(`
`1658`	`1658`	`(num_main + num_pair) * num_groups, initial_step_size, target_accept,`