SBM prior - correction Armadillo routines #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looking good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request I made two main changes as to the SBM prior routines (older pull request is #42) that both @sekulovskin and I decided today after a thorough comparison among R (original paper routines), Rcpp (old bgms routines), and RcppArmadillo (new Armadillo routines).
(1) The correction of two functions inside
gibbs_functions_edge_prior.cppcompute_Vn_mfm_sbmlog_marginal_mfm_sbm(2) update of the
summarySBMfunction and its use within the functionprepare_output_bgmI added Nikola as Reviewer to let him check the solution that I proposed for
summarySBM.This pull request also closes the issue #28.
Cheers,
Giuseppe