Skip to content

Conversation

@vandenman
Copy link
Collaborator

@vandenman vandenman commented Sep 23, 2025

also does some cleanup. Come to think of it, we can also remove RcppProgress from the DESCRIPTION file since we now does this in a custom way anyway.

@sekulovskin can you test the installation using:

remotes::install_github("vandenman/bgms@fix_windows")
# or devtools::install_github("vandenman/bgms@fix_windows")
# or renv::install("vandenman/bgms@fix_windows")

Copy link
Collaborator

@MaartenMarsman MaartenMarsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. However, lets leave print_mutex.h intact. It allows us to print output to console while testing.

@sekulovskin
Copy link
Contributor

This works for me! And it requires fewer changes than the implementation that I have. Should we merge it?

@MaartenMarsman MaartenMarsman merged commit 90178a5 into Bayesian-Graphical-Modelling-Lab:main Sep 23, 2025
0 of 6 checks passed
@vandenman vandenman deleted the fix_windows branch September 23, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants