Skip to content

Commit 948c5d6

Browse files
committed
replace placeholder with empty string if the first or last name is null
1 parent 6f78ff0 commit 948c5d6

File tree

1 file changed

+6
-21
lines changed

1 file changed

+6
-21
lines changed

classes/models/class-member.php

Lines changed: 6 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -321,13 +321,8 @@ public function register_notification( $plaintext_pass = '' ) {
321321
$message = str_replace( '%%display_name%%', $display_name, $message );
322322
$message = str_replace( '%%user_name%%', $username, $message );
323323
$message = str_replace( '%%user_email%%', $email, $message );
324-
325-
if( !empty( $this->first_name ) ) {
326-
$message = str_replace( '%%first_name%%', stripslashes( $this->first_name ), $message );
327-
}
328-
if( !empty( $this->last_name ) ) {
329-
$message = str_replace( '%%last_name%%', stripslashes( $this->last_name ), $message );
330-
}
324+
$message = str_replace( '%%first_name%%', ( !empty( $this->first_name ) ) ? stripslashes( $this->first_name ) : "", $message );
325+
$message = str_replace( '%%last_name%%', ( !empty( $this->last_name ) ) ? stripslashes( $this->last_name ) : "", $message );
331326

332327
foreach( $recipients as $mail ) {
333328
// Send mail to admin
@@ -352,13 +347,8 @@ public function register_notification( $plaintext_pass = '' ) {
352347
$message = str_replace( '%%user_email%%', $email, $message );
353348
$message = str_replace( '%%user_password%%', $plaintext_pass, $message );
354349
$message = str_replace( '%%login_url%%', mpt_get_login_permalink( ), $message );
355-
356-
if( !empty( $this->first_name ) ) {
357-
$message = str_replace( '%%first_name%%', stripslashes( $this->first_name ), $message );
358-
}
359-
if( !empty( $this->last_name ) ) {
360-
$message = str_replace( '%%last_name%%', stripslashes( $this->last_name ), $message );
361-
}
350+
$message = str_replace( '%%first_name%%', ( !empty( $this->first_name ) ) ? stripslashes( $this->first_name ) : "", $message );
351+
$message = str_replace( '%%last_name%%', ( !empty( $this->last_name ) ) ? stripslashes( $this->last_name ) : "", $message );
362352

363353
// Allow plugins hooks
364354
$subject = apply_filters( 'mpt_register_notification_subject', $subject, $this );
@@ -404,13 +394,8 @@ public function register_validation_notification( $key ) {
404394
$message = str_replace( '%%user_name%%', $username, $message );
405395
$message = str_replace( '%%site_url%%', network_site_url( ), $message );
406396
$message = str_replace( '%%confirm_register_link%%', ''.add_query_arg( array( 'mpt-action' => 'validation-member-registration', 'ID' => $this->id, 'key' => $key ), mpt_get_registration_permalink() ). '' , $message );
407-
408-
if( !empty( $this->first_name ) ) {
409-
$message = str_replace( '%%first_name%%', stripslashes( $this->first_name ), $message );
410-
}
411-
if( !empty( $this->last_name ) ) {
412-
$message = str_replace( '%%last_name%%', stripslashes( $this->last_name ), $message );
413-
}
397+
$message = str_replace( '%%first_name%%', ( !empty( $this->first_name ) ) ? stripslashes( $this->first_name ) : "", $message );
398+
$message = str_replace( '%%last_name%%', ( !empty( $this->last_name ) ) ? stripslashes( $this->last_name ) : "", $message );
414399

415400
// Allow plugins hooks
416401
$subject = apply_filters( 'mpt_register_validation_notification_subject', $subject, $this );

0 commit comments

Comments
 (0)