Fix linting issues

Author: petitphp

src/blocks/shared-block/edit.js

@@ -25,7 +25,7 @@ import SharedBlocksSelector from './sharedBlocksSelector';
 import './editor.scss';
 
 export default function Edit( { attributes, setAttributes } ) {
-	const { siteId, postId, blockId, blockTitle, display } = attributes;
+	const { blockId, blockTitle, display } = attributes;
 
 	const [ isEditing, setIsEditing ] = useState( false );
 

src/blocks/shared-block/sharedBlocksSelector.js

@@ -22,10 +22,13 @@ import { __, sprintf } from '@wordpress/i18n';
 const SEARCH_ENDPOINT = '/multisite-shared-blocks/v1/search';
 
 /**
+ * Do search request.
+ *
+ * Build and send request to the shared blocks search endpoint.
  *
  * @param {Object} params
  * @param {AbortController} controller
- * @returns {Promise<*[]>}
+ * @return {Promise<*[]>} Search request promise.
  */
 function makeRequest( params, controller ) {
 	const path = addQueryArgs( SEARCH_ENDPOINT, {
@@ -102,7 +105,7 @@ export default function SharedBlocksSelector( { onItemSelect } ) {
 	/**
 	 * Update the site id param in the query.
 	 *
-	 * @param {int} site
+	 * @param {number} site
 	 */
 	const setSite = ( site ) => {
 		setQuery( { ...query, site } );
@@ -136,15 +139,15 @@ export default function SharedBlocksSelector( { onItemSelect } ) {
 	/**
 	 * Fetch results for the query.
 	 *
-	 * @param {object} params
+	 * @param {Object} params
 	 * @param {?AbortController} controller
 	 */
 	const searchBlock = ( params, controller ) => {
-		let query = {
+		const searchQuery = {
 			...params,
 			page: currentPage,
 		};
-		makeRequest( query, controller )
+		makeRequest( searchQuery, controller )
 			.then( ( blocks ) => {
 				// Handle case where we don't have results and the request returned no results.
 				// In that case we want to display the "No Results" state.
@@ -205,7 +208,7 @@ export default function SharedBlocksSelector( { onItemSelect } ) {
 							...availableSitesOptions,
 						] }
 						onChange={ ( value ) => {
-							let site = '0' !== value ? +value : 0;
+							const site = '0' !== value ? +value : 0;
 							setSite( site );
 						} }
 					/>
@@ -225,7 +228,7 @@ export default function SharedBlocksSelector( { onItemSelect } ) {
 							...availablePostTypesOptions,
 						] }
 						onChange={ ( value ) => {
-							let postType = '0' !== value ? value : '';
+							const postType = '0' !== value ? value : '';
 							setPostType( postType );
 						} }
 					/>
@@ -252,10 +255,14 @@ export default function SharedBlocksSelector( { onItemSelect } ) {
 					>
 						{ results.map( ( result ) => {
 							return (
-								<div className={ 'results__item' }>
+								<div
+									key={ result.id }
+									className={ 'results__item' }
+								>
 									<Button
 										variant={ 'link' }
 										label={ sprintf(
+											//translators: %s shared block title
 											__(
 												'Select block "%s"',
 												'multisite-shared-blocks'

src/hooks/helper.js

@@ -4,7 +4,7 @@
  * Check if current block is excluded from sharing.
  *
  * @param {string} blockName
- * @returns {boolean}
+ * @return {boolean} True if the block type support sharing, false otherwise.
  */
 export function blockSupportSharing( blockName ) {
 	const excludedBlocks = multisiteSharedBlocksHooksData.excluded_blocks ?? [];
@@ -15,7 +15,7 @@ export function blockSupportSharing( blockName ) {
 /**
  * Get custom attributes for the sharing functionality.
  *
- * @returns {object}
+ * @return {Object} Custom attributes for the sharing functionality.
  */
 export function getBlockSharingAttributs() {
 	return multisiteSharedBlocksHooksData.attributes || {};

src/hooks/registerSharedBlockAttributes.js

@@ -14,9 +14,9 @@ import { blockSupportSharing, getBlockSharingAttributs } from './helper';
  * Since we need to keep our custom attributes in sync between PHP and JS, we inject them in the page in a custom
  * variable `multisiteSharedBlocksGutenbergData`.
  *
- * @param settings
- * @param name
- * @returns {any}
+ * @param {Object} settings
+ * @param {string} name
+ * @return {any} New settings with the custom attributes for sharing.
  */
 const registerSharedBlockAttributes = ( settings, name ) => {
 	const sharedBlockAttributes = getBlockSharingAttributs();

src/hooks/sharedBlockIdComponent.js

@@ -19,18 +19,14 @@ import { blockSupportSharing } from './helper';
  */
 const sharedBlockIdComponent = createHigherOrderComponent( ( BlockEdit ) => {
 	return class extends Component {
-		constructor() {
-			super( ...arguments );
-		}
-
 		componentDidMount() {
 			const {
 				name,
 				setAttributes,
 				attributes: { sharedBlockId } = false,
 			} = this.props;
-			if ( blockSupportSharing( name ) ) {
-				sharedBlockId || setAttributes( { sharedBlockId: uuidv4() } );
+			if ( blockSupportSharing( name ) && ! sharedBlockId ) {
+				setAttributes( { sharedBlockId: uuidv4() } );
 			}
 		}
 

tests/QueryTest.php

@@ -83,7 +83,7 @@ public function test_site__in_param(): void {
 
 		$query = new Query(
 			[
-				'site__in' => [1, 2],
+				'site__in' => [ 1, 2 ],
 			]
 		);
 		$sql   = $wpdb->remove_placeholder_escape( $query->get_request() );

webpack.config.js

@@ -1,15 +1,11 @@
-const defaultConfig = require( '@wordpress/scripts/config/webpack.config' )
-const {getWebpackEntryPoints} = require( '@wordpress/scripts/utils' )
+const defaultConfig = require( '@wordpress/scripts/config/webpack.config' );
+const { getWebpackEntryPoints } = require( '@wordpress/scripts/utils' );
 const { resolve } = require( 'path' );
 
 module.exports = {
-    ...defaultConfig,
-    entry: {
-        ...getWebpackEntryPoints(),
-        'hooks/index': resolve(
-            process.cwd(),
-            'src/hooks',
-            'index.js'
-        )
-    }
-}
+	...defaultConfig,
+	entry: {
+		...getWebpackEntryPoints(),
+		'hooks/index': resolve( process.cwd(), 'src/hooks', 'index.js' ),
+	},
+};