fix remaining JS issue after removing lodash

Author: petitphp

src/blocks/shared-block/edit.js

@@ -21,7 +21,7 @@ import './editor.scss';
 
 export default function Edit( { attributes, setAttributes } ) {
 	const { blockId, blockTitle, display } = attributes;
-	const hasBlockId = ( blockId && blockId.length ) > 0 ? true : false;
+	const hasBlockId = blockId && blockId.length > 0 ? true : false;
 
 	const [ isEditing, setIsEditing ] = useState( false );
 
@@ -96,7 +96,7 @@ export default function Edit( { attributes, setAttributes } ) {
 			</InspectorControls>
 			{ ! hasBlockId || isEditing ? (
 				<div className={ 'shared-block-selector-wrapper' }>
-					{ ! hasBlockId && (
+					{ hasBlockId && (
 						<div
 							className={
 								'shared-block-selector-wrapper__cancel'

src/blocks/shared-block/sharedBlocksSelector.js

@@ -1,4 +1,5 @@
 /* global multisiteSharedBlocksEditorData */
+/* eslint-disable jsdoc/check-line-alignment */
 
 /**
  * External dependencies

src/hooks/sharedBlockIdControls.js

@@ -23,7 +23,9 @@ const sharedBlockIdControls = createHigherOrderComponent( ( BlockEdit ) => {
 		const { sharedBlockId, sharedBlockIsShared, sharedBlockShareTitle } =
 			attributes;
 		const hasShareTitle =
-			sharedBlockShareTitle && sharedBlockShareTitle > 0 ? true : false;
+			sharedBlockShareTitle && sharedBlockShareTitle.length > 0
+				? true
+				: false;
 
 		const getEmptySharedBlockTitle = () => {
 			return sprintf(
@@ -42,15 +44,11 @@ const sharedBlockIdControls = createHigherOrderComponent( ( BlockEdit ) => {
 		};
 
 		const getTitleCharCount = ( title ) => {
-			if ( ! hasShareTitle ) {
-				return '0';
+			if ( title && title.length > 0 ) {
+				return count( title, 'characters_including_spaces', {} );
 			}
 
-			return count(
-				sharedBlockShareTitle,
-				'characters_including_spaces',
-				{}
-			);
+			return 0;
 		};
 
 		if ( ! blockSupportSharing( name ) ) {
@@ -91,9 +89,11 @@ const sharedBlockIdControls = createHigherOrderComponent( ( BlockEdit ) => {
 											'Public title for the shared block (%d/200)',
 											'multisite-shared-blocks'
 										),
-										getTitleCharCount(
-											sharedBlockShareTitle
-										)
+										hasShareTitle
+											? getTitleCharCount(
+													sharedBlockShareTitle
+											  )
+											: 0
 									) }
 									value={ sharedBlockShareTitle }
 									onChange={ ( value ) => setTitle( value ) }