don't automatically disable order synchronisation for new installation and small fixes

Author: petitphp

src/Admin/Options.php

@@ -1520,9 +1520,9 @@ function () {
 					<input
 						type="checkbox"
 						id="disable_order_import"
-								name="<?php echo esc_attr( sprintf( '%s[disable_order_import]', self::SF_ORDERS_OPTIONS ) ); ?>"
-						value="yes"
-								<?php checked( 1, isset( $this->sf_orders_options['disable_order_import'] ) ? $this->sf_orders_options['disable_order_import'] : 0 ); ?>
+						name="<?php echo esc_attr( sprintf( '%s[disable_order_import]', self::SF_ORDERS_OPTIONS ) ); ?>"
+						value="1"
+						<?php checked( '1', isset( $this->sf_orders_options['disable_order_import'] ) ? $this->sf_orders_options['disable_order_import'] : '' ); ?>
 					>
 							<?php esc_html_e( 'Disable orders synchronisation', 'shopping-feed' ); ?>
 				</label>

src/Orders/Orders.php

@@ -62,6 +62,12 @@ public function get_orders( $sf_account, $since = '' ) {
 
 		// Check if order import is enable
 		if ( ShoppingFeedHelper::is_order_import_disable() ) {
+			ShoppingFeedHelper::log(
+				\WC_Log_Levels::INFO,
+				'Order import is disabled',
+				'shopping-feed-orders'
+			);
+
 			return false;
 		}
 

src/ShoppingFeed.php

@@ -222,7 +222,6 @@ public function plugin_action_links( $links = array() ) {
 	public static function activate() {
 		if ( defined( 'WC_VERSION' ) ) {
 			self::add_sf_directory();
-			ShoppingFeedHelper::set_default_orders_option();
 			Actions::register_feed_generation();
 			Actions::register_get_orders();
 		}

src/ShoppingFeedHelper.php

@@ -427,7 +427,7 @@ public static function get_zones_with_shipping_methods() {
 			);
 		}
 
-		$all_shipping_methods = apply_filters('sf_all_shipping_methods', $all_shipping_methods);
+		$all_shipping_methods = apply_filters( 'sf_all_shipping_methods', $all_shipping_methods );
 
 		return $all_shipping_methods;
 	}
@@ -980,24 +980,8 @@ public static function is_order_import_disable() {
 			return false;
 		}
 
-		return (bool) ( $orders_options['disable_order_import'] ?? 0 ); // True if the value does not exist. For existing customers
-	}
-
-	/**
-	 * Set default orders options
-	 * @return void
-	 */
-	public static function set_default_orders_option() {
-		// Skip if option has already set
-		if ( false !== get_option( options::SF_ORDERS_OPTIONS ) ) {
-			return;
-		}
+		$disable_order_import = (int) ( $orders_options['disable_order_import'] ?? 0 );
 
-		update_option(
-			options::SF_ORDERS_OPTIONS,
-			[
-				'disable_order_import' => 1,
-			]
-		);
+		return 1 === $disable_order_import;
 	}
 }