don't create WC_Order_Item_Tax for order without any taxes

Author: petitphp

src/Orders/Order.php

@@ -154,11 +154,11 @@ public function add() {
 				$item = new \WC_Order_Item_Shipping();
 				$item->set_method_title( $this->shipping->get_method() );
 				$item->set_total( $this->shipping->get_total() );
-				if ( $this->include_vat ) {
+				if ( $this->include_vat && $this->shipping->get_total_tax() > 0 ) {
 					$item->set_taxes(
 						[
 							'total' => [
-								self::RATE_ID => (float) $this->sf_order->toArray()['additionalFields']['shipping_tax'],
+								self::RATE_ID => $this->shipping->get_total_tax(),
 							],
 						]
 					);
@@ -233,18 +233,20 @@ public function add() {
 				$total_shipping_tax = (float) $this->sf_order->toArray()['additionalFields']['shipping_tax'];
 			}
 
-			$tax = new \WC_Order_Item_Tax();
-			$tax->set_props(
-				[
-					'rate_code'          => 'SF-VAT',
-					'rate_id'            => self::RATE_ID,
-					'label'              => __( 'VAT', 'shopping-feed' ),
-					'tax_total'          => $total_product_tax,
-					'shipping_tax_total' => $total_shipping_tax,
-				]
-			);
-			$tax->save();
-			$wc_order->add_item( $tax );
+			if ( $total_product_tax > 0 || $total_shipping_tax > 0 ) {
+				$tax = new \WC_Order_Item_Tax();
+				$tax->set_props(
+					[
+						'rate_code'          => 'SF-VAT',
+						'rate_id'            => self::RATE_ID,
+						'label'              => __( 'VAT', 'shopping-feed' ),
+						'tax_total'          => $total_product_tax,
+						'shipping_tax_total' => $total_shipping_tax,
+					]
+				);
+				$tax->save();
+				$wc_order->add_item( $tax );
+			}
 		}
 
 		$wc_order->set_status( $this->status->get_name(), $this->status->get_note() );

src/Orders/Order/Products.php

@@ -101,7 +101,7 @@ private function mapping_product( $sf_product ) {
 			'quantity'     => $sf_product_quantity,
 		);
 
-		if ( $this->include_vat ) {
+		if ( $this->include_vat && $sf_product->getTaxAmount() > 0 ) {
 			$args['taxes'] = [
 				'subtotal' => [
 					Order::RATE_ID => $sf_product->getTaxAmount(),

src/Orders/Order/Shipping.php

@@ -34,9 +34,10 @@ class Shipping {
 	 */
 	private $total;
 
-	/**
-	 * @var bool $include_vat
-	 */
+	/** @var float $total_tax */
+	private $total_tax;
+
+	/** @var bool $include_vat */
 	private $include_vat;
 
 	/** @var array|\WC_Shipping_Rate $shipping_rate */
@@ -52,11 +53,12 @@ class Shipping {
 	 * @param bool $include_vat
 	 */
 	public function __construct( $sf_order, $include_vat = false ) {
-		$this->sf_order = $sf_order;
+		$this->sf_order    = $sf_order;
 		$this->include_vat = $include_vat;
 
 		$this->set_shipping_method_and_colis_number();
 		$this->set_total();
+		$this->set_total_tax();
 	}
 
 	/**
@@ -101,11 +103,11 @@ private function set_shipping_rate() {
 			$shipping_rate = $default_shipping_method;
 		}
 
-		$vat = [];
-		if ( $this->include_vat && isset( $this->sf_order->toArray()['additionalFields']['shipping_tax'] ) ) {
-			$vat = [
+		$taxes = [];
+		if ( $this->include_vat && $this->get_total_tax() > 0 ) {
+			$taxes = [
 				'total' => [
-					Order::RATE_ID => (float) $this->sf_order->toArray()['additionalFields']['shipping_tax'],
+					Order::RATE_ID => $this->get_total_tax(),
 				],
 			];
 		}
@@ -114,7 +116,7 @@ private function set_shipping_rate() {
 			$shipping_rate['method_rate_id'],
 			$shipping_rate['method_title'],
 			$this->get_total_shipping() ? $this->get_total_shipping() : ShoppingFeedHelper::get_sf_default_shipping_fees(),
-			$vat,
+			$taxes,
 			$shipping_rate['method_rate_id'],
 			$shipping_rate['method_id']
 		);
@@ -123,19 +125,37 @@ private function set_shipping_rate() {
 	}
 
 	/**
+	 * Get total shipping amount.
+	 *
 	 * @return float
 	 */
 	public function get_total() {
 		return $this->total;
 	}
 
 	/**
-	 * Set total
+	 * Set total shipping amount.
 	 */
 	public function set_total() {
 		$this->total = $this->get_total_shipping();
 	}
 
+	/**
+	 * Get total shipping tax amount.
+	 *
+	 * @return float
+	 */
+	public function get_total_tax() {
+		return $this->total_tax;
+	}
+
+	/**
+	 * Set total shipping tax amount.
+	 */
+	public function set_total_tax() {
+		$this->total_tax = isset( $this->sf_order->toArray()['additionalFields']['shipping_tax'] ) ? (float) $this->sf_order->toArray()['additionalFields']['shipping_tax'] : 0;
+	}
+
 	/**
 	 * @return array|\WC_Shipping_Rate $shipping_rate
 	 */