Merge branch 'develop' into ver/6.11.0

Author: stephane-gillot

readme.md

@@ -315,7 +315,36 @@ function your_custom_fields_function($fields, $wc_product) {
 ```
 
 ### Variation Images
+
+#### Main image
+By default the variation's thumbnail is used as the main image in the feed.
+
+You can customize the main image using the filter "shopping_feed_variation_main_image".
+
+```php
+add_filter( 'shopping_feed_variation_main_image', 'your_custom_variation_main_images_function', 10, 3 );
+
+/**
+ * Use the parent's thumbnail if the variation doesn't have one.
+ * 
+ * @param string $main_image The main image of the variation.
+ * @param \WC_Product_Variation $variation The variation.
+ * @param \WC_Product_Variable $product The product.
+ *
+ * @return string
+ */
+function your_custom_variation_main_images_function( $main_image, $variation, $product ) {
+    if ( empty( $main_image ) && has_post_thumbnail( $product->get_id() ) ) {
+      $main_image = get_the_post_thumbnail_url( $product->get_id(), 'full' );
+    }
+
+    return $main_image;
+}
+```
+
+#### Additional images
 By default, we don’t support any custom plugin for adding images to WC Product Variation, with this filter you can set the desired images to each variation, you can use the following snippet
+
 ```php
 add_filter( 'shopping_feed_variation_images', 'your_custom_variation_images_function', 10, 3 );
 

readme.txt

@@ -320,6 +320,34 @@ function your_custom_fields_function($fields, $wc_product) {
 `
 
 ### Variation Images
+
+#### Main image
+By default the variation's thumbnail is used as the main image in the feed.
+
+You can customize the main image using the filter "shopping_feed_variation_main_image".
+
+`
+add_filter( 'shopping_feed_variation_main_image', 'your_custom_variation_main_images_function', 10, 3 );
+
+/**
+ * Use the parent's thumbnail if the variation doesn't have one.
+ *
+ * @param string $main_image The main image of the variation.
+ * @param \WC_Product_Variation $variation The variation.
+ * @param \WC_Product_Variable $product The product.
+ *
+ * @return string
+ */
+function your_custom_variation_main_images_function( $main_image, $variation, $product ) {
+    if ( empty( $main_image ) && has_post_thumbnail( $product->get_id() ) ) {
+      $main_image = get_the_post_thumbnail_url( $product->get_id(), 'full' );
+    }
+
+    return $main_image;
+}
+`
+
+#### Additional images
 By default, we don’t support any custom plugin for adding images to WC Product Variation, with this filter you can set the desired images to each variation, you can use the following snippet
 
 `

src/Products/Product.php

@@ -477,10 +477,21 @@ public function get_variations( $for_feed = false ) {
 			$variation_data['width']    = $variation->get_width();
 			$variation_data['height']   = $variation->get_height();
 			$variation_data['length']   = $variation->get_length();
-			if ( ! empty( get_the_post_thumbnail_url( $variation->get_id(), 'full' ) ) ) {
-				$variation_data['image_main'] = get_the_post_thumbnail_url( $variation->get_id(), 'full' );
+
+			$main_image = '';
+			if ( has_post_thumbnail( $variation->get_id() ) ) {
+				$main_image = get_the_post_thumbnail_url( $variation->get_id(), 'full' );
 			}
 
+			/**
+			 * Filter the main image of the variation.
+			 *
+			 * @param string $main_image The main image of the variation.
+			 * @param \WC_Product_Variation $variation The variation.
+			 * @param \WC_Product_Variable $product The product.
+			 */
+			$variation_data['image_main'] = apply_filters( 'shopping_feed_variation_main_image', $main_image, $variation, $product );
+
 			$variation_data['attributes'] = $this->get_variation_attributes( $variation );
 			$variations[]                 = $variation_data;
 		}

tests/_data/images/image1.png

@@ -346,7 +346,7 @@ public function test_get_simple_product_dimensions_when_not_defined(){
 	public function test_get_variation_dimensions_when_it_not_defined() {
 
 		// Prepare the variable product object
-		$wc_variable_product = New \WC_Product_Variable();
+		$wc_variable_product = new \WC_Product_Variable();
 		$wc_variable_product->set_length( 5 );
 		$wc_variable_product->set_height( 10 );
 		$wc_variable_product->set_width( 15 );
@@ -366,7 +366,7 @@ public function test_get_variation_dimensions_when_it_not_defined() {
 	public function test_get_variation_dimensions_when_it_overrides_parent_dimensions(){
 
 		// Prepare the variable product object
-		$wc_variable_product = New \WC_Product_Variable();
+		$wc_variable_product = new \WC_Product_Variable();
 		$wc_variable_product->set_length( 5 );
 		$wc_variable_product->set_height( 10 );
 		$wc_variable_product->set_width( 15 );
@@ -386,4 +386,83 @@ public function test_get_variation_dimensions_when_it_overrides_parent_dimension
 		$this->assertEquals( 30, $sf_product->get_height(), 'Product height should be 30.' );
 		$this->assertEquals( 40, $sf_product->get_width(), 'Product width should be 40.' );
 	}
+
+	public function test_variation_set_custom_main_image() {
+		add_filter(
+			'shopping_feed_variation_main_image',
+			function( $image, $variation, $product ) {
+				return 'https://example.com/image.jpg';
+			},
+			10,
+			3
+		);
+
+		$image_id = $this->factory()->attachment->create_object(
+			[
+				'file' => codecept_data_dir( 'images/image1.png' ),
+				'post_mime_type' => 'image/png',
+				'post_title' => 'Test Image',
+				'post_content' => '',
+				'post_status' => 'inherit',
+			]
+		);
+		
+		$variable_product = new \WC_Product_Variable();
+		$variable_product_id = $variable_product->save();
+
+		WC_Helper_Product::create_product_variation_object( $variable_product_id, 'variation-1', 10, [], true );
+
+		$sf_product = new Product( $variable_product_id );
+		$this->assertCount( 1, $sf_product->get_variations(), 'Variable product should have 1 variation.' );
+		$this->assertArrayHasKey( 'image_main', $sf_product->get_variations()[0], 'Variation should have an image_main key.' );
+		$this->assertEquals( 'https://example.com/image.jpg', $sf_product->get_variations()[0]['image_main'], 'Product main image should be equal to the custom value from the filter.' );
+	}
+
+	public function test_variation_use_thumbnail_as_main_image() {
+		$image_id = $this->factory()->attachment->create_object(
+			[
+				'file' => codecept_data_dir( 'images/image1.png' ),
+				'post_mime_type' => 'image/png',
+				'post_title' => 'Test Image',
+				'post_content' => '',
+				'post_status' => 'inherit',
+			]
+		);
+		$image_url = wp_get_attachment_image_url( $image_id, 'full' );
+		
+		$variable_product = new \WC_Product_Variable();
+		$variable_product_id = $variable_product->save();
+
+		$variation_product = WC_Helper_Product::create_product_variation_object( $variable_product_id, 'variation-1', 10, [], true );
+		$variation_product->set_image_id( $image_id );
+		$variation_product->save();
+
+		$sf_product = new Product( $variable_product_id );
+		$this->assertCount( 1, $sf_product->get_variations(), 'Variable product should have 1 variation.' );
+		$this->assertArrayHasKey( 'image_main', $sf_product->get_variations()[0], 'Variation should have an image_main key.' );
+		$this->assertEquals( $image_url, $sf_product->get_variations()[0]['image_main'], 'Product main image should be empty.' );
+	}
+
+	public function test_variation_empty_main_image_if_no_image_set() {
+		$image_id = $this->factory()->attachment->create_object(
+			[
+				'file' => codecept_data_dir( 'images/image1.png' ),
+				'post_mime_type' => 'image/png',
+				'post_title' => 'Test Image',
+				'post_content' => '',
+				'post_status' => 'inherit',
+			]
+		);
+		
+		$variable_product = new \WC_Product_Variable();
+		$variable_product->set_image_id( $image_id );
+		$variable_product_id = $variable_product->save();
+
+		WC_Helper_Product::create_product_variation_object( $variable_product_id, 'variation-1', 10, [], true );
+
+		$sf_product = new Product( $variable_product_id );
+		$this->assertCount( 1, $sf_product->get_variations(), 'Variable product should have 1 variation.' );
+		$this->assertArrayHasKey( 'image_main', $sf_product->get_variations()[0], 'Variation should have an image_main key.' );
+		$this->assertEquals( '', $sf_product->get_variations()[0]['image_main'], 'Product main image should be empty.' );
+	}
 }